Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename PartnersURLs to ApplicationURLs #5244

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

isaacroldan
Copy link
Contributor

@isaacroldan isaacroldan commented Jan 21, 2025

WHY are these changes introduced?

Just because it makes more sense to call it ApplicationURLs than PartnersURLs

WHAT is this pull request doing?

  • Renames PartnersURLs interface to ApplicationURLs
  • Updates generatePartnersURLs function to generateApplicationURLs
  • Updates validatePartnersURLs function to validateApplicationURLs
  • Updates all related function calls and type references throughout the codebase

How to test your changes?

  1. The CLI still works?

Measuring impact

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor

github-actions bot commented Jan 21, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.36% (-0.01% 🔻)
8904/11815
🟡 Branches
70.59% (-0.02% 🔻)
4329/6133
🟡 Functions 75.14% 2340/3114
🟡 Lines 75.9% 8415/11087
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / app-event-watcher.ts
93.83% (-1.23% 🔻)
86.49% (-2.7% 🔻)
90.48% 98.61%
🟢
... / ConcurrentOutput.tsx
98.36% (-1.64% 🔻)
88% (-4% 🔻)
100%
98.33% (-1.67% 🔻)

Test suite run success

2005 tests passing in 905 suites.

Report generated by 🧪jest coverage report action from 546e633

@isaacroldan isaacroldan marked this pull request as ready for review January 21, 2025 13:12
@isaacroldan isaacroldan requested a review from a team as a code owner January 21, 2025 13:12
Copy link
Contributor

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

@isaacroldan isaacroldan force-pushed the 01-21-rename_partnersurls_to_applicationurls branch from 8e1b613 to d905f26 Compare January 21, 2025 16:35
@isaacroldan isaacroldan force-pushed the 01-21-rename_partnersurls_to_applicationurls branch from d905f26 to 546e633 Compare January 24, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants