Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch the app manifest with the development URLs, add tests #5245

Open
wants to merge 3 commits into
base: 01-21-rename_partnersurls_to_applicationurls
Choose a base branch
from

Conversation

isaacroldan
Copy link
Contributor

@isaacroldan isaacroldan commented Jan 21, 2025

WHY are these changes introduced?

Enables the CLI to patch app manifests with development URLs during local development, ensuring that app home, app proxy, and app access configurations use the correct development URLs instead of production URLs.

WHAT is this pull request doing?

  • Adds support for patching app manifests with development URLs during local development
  • Introduces new test data helpers for app home and app proxy extensions
  • Updates the app model to store and use development URLs when generating manifests

How to test your changes?

  1. Create an app with app home, app proxy, and app access extensions
  2. Run the dev command
  3. Verify that the manifest (inside ./shopify/bundle) includes the correct development URLs.

Measuring impact

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor Author

isaacroldan commented Jan 21, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

@isaacroldan isaacroldan force-pushed the 01-21-rename_partnersurls_to_applicationurls branch from 8e1b613 to d905f26 Compare January 21, 2025 16:35
@isaacroldan isaacroldan force-pushed the 01-21-patch_the_app_manifest_with_the_development_urls_add_tests branch from b965907 to 6f9b1e8 Compare January 21, 2025 16:35
Copy link
Contributor

github-actions bot commented Jan 21, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.43% (+0.1% 🔼)
8936/11847
🟡 Branches
70.62% (+0.05% 🔼)
4338/6143
🟡 Functions
75.21% (+0.11% 🔼)
2348/3122
🟡 Lines
75.95% (+0.09% 🔼)
8441/11114
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / app.ts
88.02% (+1.54% 🔼)
70.33% (-0.04% 🔻)
92.73% (+0.57% 🔼)
89.44% (+1.25% 🔼)
🔴
... / dev.ts
19.53% (-0.15% 🔻)
15.38% 24.39%
20.17% (-0.34% 🔻)
🔴
... / extension.ts
56.9% (-0.25% 🔻)
57.14% (-0.55% 🔻)
50%
57.89% (-0.29% 🔻)

Test suite run success

2008 tests passing in 906 suites.

Report generated by 🧪jest coverage report action from 3eae494

@isaacroldan isaacroldan force-pushed the 01-21-rename_partnersurls_to_applicationurls branch from d905f26 to 546e633 Compare January 24, 2025 10:15
@isaacroldan isaacroldan force-pushed the 01-21-patch_the_app_manifest_with_the_development_urls_add_tests branch from 1662daa to 3eae494 Compare January 24, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant