-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch the app manifest with the development URLs, add tests #5245
base: 01-21-rename_partnersurls_to_applicationurls
Are you sure you want to change the base?
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
We detected some changes at packages/*/src and there are no updates in the .changeset. |
8e1b613
to
d905f26
Compare
b965907
to
6f9b1e8
Compare
Coverage report
Show files with reduced coverage 🔻
Test suite run success2008 tests passing in 906 suites. Report generated by 🧪jest coverage report action from 3eae494 |
d905f26
to
546e633
Compare
1662daa
to
3eae494
Compare
WHY are these changes introduced?
Enables the CLI to patch app manifests with development URLs during local development, ensuring that app home, app proxy, and app access configurations use the correct development URLs instead of production URLs.
WHAT is this pull request doing?
How to test your changes?
./shopify/bundle
) includes the correct development URLs.Measuring impact
Checklist