Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Slideshow] Fixing an issue with block attributes #3663

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Slideshow] Fixing an issue with block attributes #3663

wants to merge 1 commit into from

Conversation

alexandcote
Copy link

PR Summary:

  1. The attributes were rendered multiple times per block

Why are these changes introduced?

Improving the Theme Editor experience.

Testing steps/scenarios

  1. Open the theme editor
  2. Add the slideshow section
  3. Hover the block in the sidebar, be sure the power preview outlines the block properly.

Checklist

@ludoboludo
Copy link
Contributor

cc: @Roi-Arthur could we get your review on this too :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoboludo ludoboludo ludoboludo approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandcote @ludoboludo