Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralize Ruby Version to .ruby-version #12

Merged
merged 9 commits into from
May 23, 2024
Merged

Conversation

george-ma
Copy link
Contributor

@george-ma george-ma commented May 19, 2024

What are you trying to accomplish?

The .ruby-version file is the ecosystem standard for defining a Ruby version. This PR adds the .ruby-version file, ensures a required_ruby_version is set, and removes all other references to Ruby in this repository, aligning it with the standard.

What should reviewers focus on?

Important

Please verify the following before merging:

Verify that the changes in the PR meets the following requirements or adjust manually to make it compliant:

  • .ruby-version file is present with the correct Ruby version defined
  • A required_ruby_version in your gemspec is set
  • There is no Ruby version present in the dev.yml Ruby task (before: - ruby: x.x.x, after: - ruby)
  • There is no Ruby version/requirement referenced in the Gemfile (no lines with ruby <some-version>)
  • A Gemfile.lock is built with the defined Ruby version Can't and won't do this since this is a gem that is used across different versions.
  • The version of Rubocop installed is 1.61.0 or greater Can't do this because the gem needs to support Ruby 2.6.
  • There is no TargetRubyVersion defined in rubocop.yml (reads from required_ruby_version on Rubocop 1.61.0) Can't do this. Need to support 2.6.
  • There is no Ruby argument present in ruby/setup-ruby Github Actions that do not run on a Ruby matrix (no lines with ruby-version: “x.x”)

To establish consistency, the required_ruby_versionis set to 2.7. If you think that another version is a better fit, please make the applicable changes. Set to 2.6.

Please merge this PR if it looks good, this PR will be addressed if there isn't any activity after 4 weeks.

@george-ma george-ma requested a review from atesgoral May 19, 2024 19:35
@atesgoral
Copy link
Contributor

We can't drop 2.6 support since ruby-openai still supports it (and other gems also might): https://rubygems.org/gems/event_stream_parser/reverse_dependencies

@george-ma
Copy link
Contributor Author

thanks for tackling this! 🙌🏻

@george-ma george-ma merged commit 1e3c849 into main May 23, 2024
11 checks passed
@george-ma george-ma deleted the centralize_ruby_version branch May 23, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants