Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action needed] support RN 0.77 #1466

Open
1 of 2 tasks
vonovak opened this issue Jan 7, 2025 · 6 comments · May be fixed by #1484
Open
1 of 2 tasks

[action needed] support RN 0.77 #1466

vonovak opened this issue Jan 7, 2025 · 6 comments · May be fixed by #1484
Labels
bug Something isn't working

Comments

@vonovak
Copy link

vonovak commented Jan 7, 2025

Hello,
because of facebook/react-native#46809 there are changes that need to be done, similar to AppAndFlow/react-native-safe-area-context#566. This is a heads up for the maintainers.

Current behavior

build with old architecture on RN 0.77 fails with

e: file:@shopify/flash-list/android/src/main/kotlin/com/shopify/reactnative/flash_list/AutoLayoutViewManager.kt:16:74 Type argument is not within its bounds: should be subtype of 'it(BaseViewManagerInterface & com.facebook.react.viewmanagers.AutoLayoutViewManagerInterface<com.shopify.reactnative.flash_list.AutoLayoutView!>)!'.
e: file:@shopify/flash-list/android/src/main/kotlin/com/shopify/reactnative/flash_list/AutoLayoutViewManager.kt:17:39 Argument type mismatch: actual type is 'com.shopify.reactnative.flash_list.AutoLayoutViewManager', but 'U!' was expected.
e: file:@shopify/flash-list/android/src/main/kotlin/com/shopify/reactnative/flash_list/CellContainerManager.kt:13:76 Type argument is not within its bounds: should be subtype of 'it(BaseViewManagerInterface & com.facebook.react.viewmanagers.CellContainerManagerInterface<com.shopify.reactnative.flash_list.CellContainerImpl!>)!'.
e: file:@shopify/flash-list/android/src/main/kotlin/com/shopify/reactnative/flash_list/CellContainerManager.kt:14:40 Argument type mismatch: actual type is 'com.shopify.reactnative.flash_list.CellContainerManager', but 'U!' was expected.

Expected behavior

build should pass

To Reproduce

upgrade to latest RN 0.77 and build an app with flash list dep, with old arch

Platform:

  • iOS
  • Android

Environment

x.y.z

@vonovak vonovak added the bug Something isn't working label Jan 7, 2025
@tomekzaw
Copy link

Here's a patch that adds support for RN 0.77: @shopify-flash-list-npm-1.7.2-2a363895ca.patch

github-merge-queue bot pushed a commit to software-mansion/react-native-reanimated that referenced this issue Jan 13, 2025
## Summary

This PR bumps `react-native` in paper-example and fabric-example from
`0.76.5` to `0.77.0-rc.6` (golden RC) accordingly to
https://react-native-community.github.io/upgrade-helper/?from=0.76.5&to=0.77.0-rc.6.

Apart from this, changes have been made in macos-example, tvos-example
and web-example to align versions of common native dependencies so they
are hoisted by yarn.

I had to patch `@shopify/flash-list`:
* Shopify/flash-list#1466 – fixes Android
build
* Shopify/flash-list#1041 – fixes `scrollTo`
example

Changes required by Reanimated to support RN 0.77 have been moved to
separate PRs for the sake of atomicity and transparency:
* #6875
* #6876
* #6883
* #6884

## Test plan

---------

Co-authored-by: Krzysztof Piaskowy <krzysztof.piaskowy@swmansion.com>
@RohovDmytro
Copy link

RohovDmytro commented Jan 21, 2025

The patch works perfectly and today React Native 0.77.0 was released. :)

@ChronoByteCosmonaut
Copy link

Here's a patch that adds support for RN 0.77: @shopify-flash-list-npm-1.7.2-2a363895ca.patch

At least someone cares 🙏

@huextrat huextrat linked a pull request Jan 22, 2025 that will close this issue
1 task
@efstathiosntonas
Copy link
Contributor

@tomekzaw thanks for the patch, I guess this is not backwards compatible for older versions of rn, correct?

@tomekzaw
Copy link

@efstathiosntonas To be honest I haven't checked that, I would safely assume that it's not.

@vonovak
Copy link
Author

vonovak commented Jan 23, 2025

Hello, I believe that it is backward compatible (question is, down to which version?). RN SVG and others had to do the same change and they didn't do a major bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants