-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[action needed] support RN 0.77 #1466
Comments
Here's a patch that adds support for RN 0.77: @shopify-flash-list-npm-1.7.2-2a363895ca.patch |
## Summary This PR bumps `react-native` in paper-example and fabric-example from `0.76.5` to `0.77.0-rc.6` (golden RC) accordingly to https://react-native-community.github.io/upgrade-helper/?from=0.76.5&to=0.77.0-rc.6. Apart from this, changes have been made in macos-example, tvos-example and web-example to align versions of common native dependencies so they are hoisted by yarn. I had to patch `@shopify/flash-list`: * Shopify/flash-list#1466 – fixes Android build * Shopify/flash-list#1041 – fixes `scrollTo` example Changes required by Reanimated to support RN 0.77 have been moved to separate PRs for the sake of atomicity and transparency: * #6875 * #6876 * #6883 * #6884 ## Test plan --------- Co-authored-by: Krzysztof Piaskowy <krzysztof.piaskowy@swmansion.com>
The patch works perfectly and today React Native 0.77.0 was released. :) |
At least someone cares 🙏 |
@tomekzaw thanks for the patch, I guess this is not backwards compatible for older versions of rn, correct? |
@efstathiosntonas To be honest I haven't checked that, I would safely assume that it's not. |
Hello, I believe that it is backward compatible (question is, down to which version?). RN SVG and others had to do the same change and they didn't do a major bump. |
Hello,
because of facebook/react-native#46809 there are changes that need to be done, similar to AppAndFlow/react-native-safe-area-context#566. This is a heads up for the maintainers.
Current behavior
build with old architecture on RN 0.77 fails with
Expected behavior
build should pass
To Reproduce
upgrade to latest RN 0.77 and build an app with flash list dep, with old arch
Platform:
Environment
x.y.z
The text was updated successfully, but these errors were encountered: