Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix resuming state without inline verifier #185

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix resuming state without inline verifier #185

wants to merge 1 commit into from

Commits on May 12, 2020

  1. Fix resuming state without inline verifier 

    If the inline-verifier is not enabled (as is the case for various
production uses of ghostferry), its binlog position can grow stale. In
some cases it points to such an old position that resuming from it
fails (if the source has already deleted such old replication logs).

This commit fixes this by relying solely on the binlog writer resume
position if the inline verifier is not enabled.

We still fail if the inline verifier *is* enabled and the position is
stale, but there is nothing one can do about that. If verification is
enabled, one must ensure that it's able to keep up with migration.

This fixes Shopify#184

Change-Id: I24cef00bb78c266705107b2b8b4008171186940d
    @kolbitsch-lastline
    kolbitsch-lastline committed May 12, 2020
    Configuration menu
    Copy the full SHA
    fd85ae0 View commit details
    Browse the repository at this point in the history