remove public routes from account

[jamalsoueidan]

Apply underscores to all public account routes. Since we don't need the account layout, this practice will result in cleaner code.

1. rename account.login > account_.login.tsx
2. rename account.register > account_.register.tsx
   etc.

Account loader becomes simpler, and the useLoaderData() is no longer a union type, eliminating the need for TmpRemixFix.

From:

// Combining json + Response + defer in a loader breaks the
// types returned by useLoaderData. This is a temporary fix.
type TmpRemixFix = ReturnType<typeof defer<{isAuthenticated: false}>>;

export const headers = routeHeaders;

export async function loader({request, context, params}: LoaderArgs) {
  const {pathname} = new URL(request.url);
  const locale = params.locale;
  const customerAccessToken = await context.session.get('customerAccessToken');
  const isAuthenticated = Boolean(customerAccessToken);
  const loginPath = locale ? `/${locale}/account/login` : '/account/login';
  const isAccountPage = /^\/account\/?$/.test(pathname);

  if (!isAuthenticated) {
    if (isAccountPage) {
      return redirect(loginPath) as unknown as TmpRemixFix;
    }
    // pass through to public routes
    return json({isAuthenticated: false}) as unknown as TmpRemixFix;
 }

To:

  const customerAccessToken = await context.session.get('customerAccessToken');
  const isAuthenticated = Boolean(customerAccessToken);

  if (!isAuthenticated) {
    return redirect(`/${params.locale || ''}/account/login`);
  }

This code block can also be removed from the component.

// Public routes
  if (!data.isAuthenticated) {
    return <Outlet />;
  }

I would like to contribute to the demo store, I just need to figure out how to do it? Just clone the repos, create a branch and push?

[blittle]

This sounds like a great change @jamalsoueidan and we'd love a PR! The process should be:

1. Fork the repository under your own username
2. Make the code changes on your own branch
3. Push the code changes to your own repo
4. Create a pull request from your repo to ours

Some other general guidelines: https://github.com/Shopify/hydrogen/blob/2023-04/CONTRIBUTING.md