Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version to v0.22.2 #595

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Update version to v0.22.2 #595

merged 2 commits into from
Aug 21, 2024

Conversation

Shariatj
Copy link
Contributor

Releasing a new version of Kubeaudit for the depracation notice.
Related issue:#593 (comment)

@jacobmichels
Copy link

In the interest of maintaining a clean commit history, would you mind squashing these commits into one?

@jacobmichels
Copy link

Does bumping this version automatically trigger a GH release once merged to main? Or is there a separate process for that

@Shariatj
Copy link
Contributor Author

Does bumping this version automatically trigger a GH release once merged to main? Or is there a separate process for that

No we have to manually relaese it by creating a tag, ref: https://github.com/Shopify/kubeaudit/blob/main/docs/release.md

@@ -1 +1 @@
0.22.1
0.23.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: shouldn't this be a patch bump? we're not introducing new functionality and it's backwards compatible

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this isn't a bug fix, adding a deprecation notice (considered a minor update without breaking functionality), I thought the next version should be v0.23.0. Could be changed to a patch bump too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dani-santos-code changed it into patch bump now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a blocker at all

Copy link
Contributor

@dani-santos-code dani-santos-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! can we update the title of the PR? thanks!

@Shariatj Shariatj changed the title Update version to v0.23.0 Update version to v0.22.2 Aug 21, 2024
@Shariatj Shariatj enabled auto-merge (squash) August 21, 2024 18:32
@Shariatj Shariatj disabled auto-merge August 21, 2024 18:33
@Shariatj Shariatj enabled auto-merge (squash) August 21, 2024 18:44
@Shariatj Shariatj merged commit 92c3147 into main Aug 21, 2024
4 checks passed
@Shariatj Shariatj deleted the release23 branch August 21, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants