This repository has been archived by the owner on Apr 24, 2024. It is now read-only.
Centralize Ruby Version to .ruby-version
#76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm good with removing it. We're going to do a release anyway, so may as well bump the minor version and just say it's 3.1.0+. Will need to update the CI matrix: measured-rails/.github/workflows/ci.yml Line 14 in d9d4a7e And all these changes mirrored to |
I already fixed this problem on |
Ruby 2.7 is EOL and we are not testing against it anymore. I believe this line was missed in PR #75
The `.ruby-version` file is the ecosystem standard for defining a Ruby version. This commit adds the `.ruby-version` file and removes all other references as they will read from this file.
alexcrocha
force-pushed
the
centralize_ruby_version
branch
from
6cf57c1
to
3b14cc3
Compare
paracycle
approved these changes
Apr 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
The
.ruby-versionfile is the ecosystem standard for defining a Ruby version. This PR adds the.ruby-versionfile, ensures arequired_ruby_versionis set, and removes all other references to Ruby in this repository, aligning it with the standard.What should reviewers focus on?
Important
Please verify the following before merging:
Verify that the changes in the PR meets the following requirements or adjust manually to make it compliant:
.ruby-versionfile is present with the correct Ruby version definedrequired_ruby_versionin your gemspec is setdev.ymlRuby task (before:- ruby: x.x.x, after:- ruby)Gemfile(no lines withruby <some-version>)Gemfile.lockis built with the defined Ruby versionTargetRubyVersiondefined inrubocop.ymlruby/setup-rubyGithub Actions that do not run on a Ruby matrix (no lines withruby-version: “x.x”)This PR will be merged if there isn't any activity after 4 weeks.