Skip to content

Commit

Permalink
Remove mix blend mode on primary button (#9912)
Browse files Browse the repository at this point in the history
### WHY are these changes introduced?

Fixes Shopify/polaris-internal#1035

### WHAT is this pull request doing?

The `mix-blend-mode` was causing a visual regression on Android Chrome.

This was tested on a Google Pixel 6 Pro on Chrome

| Before | After |
| --- | --- |
| <img width="516" alt="before"
src="https://github.com/Shopify/polaris/assets/11774595/3387fee2-7b53-4dec-89b4-4cdd1ee7465a">
| <img width="516" alt="after"
src="https://github.com/Shopify/polaris/assets/11774595/358f61ea-c31a-4d95-bf73-c1b9e7c5db30">
|

---------

Co-authored-by: Sophie Schneider <thesophieschneider@gmail.com>
  • Loading branch information
sam-b-rose and sophschneider authored Aug 14, 2023
1 parent 65ad4e2 commit 00b8312
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changeset/young-dragons-switch.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/polaris': patch
---

Fixed primary Button styles for Chrome on Android devices
1 change: 0 additions & 1 deletion polaris-react/src/components/Button/Button.scss
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,6 @@
box-shadow: var(--p-shadow-button-primary-strong-experimental);
border-radius: 9px;
transition: opacity 75ms cubic-bezier(0.19, 0.91, 0.38, 1);
mix-blend-mode: luminosity;
// stylelint-enable
}

Expand Down

0 comments on commit 00b8312

Please sign in to comment.