[Button] Fix specificity issue with loading styles

Shopify · Aug 16, 2023 · 100a2b7 · 100a2b7
1 parent e74b708
commit 100a2b7
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/polaris-react/src/components/Button/Button.scss b/polaris-react/src/components/Button/Button.scss
@@ -335,11 +335,6 @@
     &::before {
       display: none;
     }
-
-    svg {
-      // stylelint-disable-next-line polaris/conventions/polaris/custom-property-allowed-list, declaration-no-important -- override Spinner fill color
-      fill: var(--pc-button-text) !important;
-    }
   }
 
   &.destructive,
@@ -690,7 +685,12 @@
 }
 
 .loading.disabled svg {
-  fill: var(--p-color-icon-subdued);
+  fill: var(--p-color-bg-interactive);
+}
+
+.primary.disabled svg {
+  // stylelint-disable-next-line polaris/conventions/polaris/custom-property-allowed-list -- override Spinner fill color
+  fill: var(--pc-button-text);
 }
 
 // The way the designs work, we need to do lots of reaching down to