Skip to content

Commit

Permalink
Lower z-index of Filters container to be below Card shadow bevel (#11462
Browse files Browse the repository at this point in the history
)

### WHY are these changes introduced?

Part of Shopify/polaris-internal#1343

### WHAT is this pull request doing?

Lower `Filter` container z-index (currently `100`) to be below `Card`'s
shadow bevel z-index which is `32`. This is a similar bug/fix as [this
issue](#11411).

|Before|After|
|-|-|
|<img width="503" alt="Screenshot 2024-01-17 at 3 53 30 PM"
src="https://github.com/Shopify/polaris/assets/20652326/88edab7c-aed8-44b8-9f5c-b9bd319405dc">|<img
width="382" alt="Screenshot 2024-01-17 at 4 48 45 PM"
src="https://github.com/Shopify/polaris/assets/20652326/7dc33fc8-333b-4e1d-afa7-f3efed5ad7a1">|

### How to 🎩


https://admin.web.web-kkgf.sophie-schneider.us.spin.dev/store/shop1/orders
1. Press search button on index table

or

verify shadow bevel is on the filter search bar in this story
https://5d559397bae39100201eedc1-vszwcambil.chromatic.com/?path=/story/all-components-indexfilters--with-filtering-by-default
(vs.[ on
prod](https://storybook.polaris.shopify.com/?path=/story/all-components-indexfilters--with-filtering-by-default))


### 🎩 checklist

- [x] Tested a
[snapshot](https://github.com/Shopify/polaris/blob/main/documentation/Releasing.md#-snapshot-releases)
- [x] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [x] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)

---------

Co-authored-by: Laura Griffee <laura@mailzone.com>
  • Loading branch information
sophschneider and lgriffee authored Jan 18, 2024
1 parent d26df7e commit 2febd60
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changeset/selfish-ads-reflect.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/polaris': patch
---

Lowered the z-index of `Filter`s container to be below `Card` shadow bevel
3 changes: 2 additions & 1 deletion polaris-react/src/components/Filters/Filters.module.scss
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@

.Container {
position: relative;
z-index: var(--p-z-index-1);
// stylelint-disable-next-line -- z-index below Card shadow bevel (32)
z-index: 30;
border-bottom: var(--p-border-width-025) solid var(--p-color-border-secondary);
border-top-left-radius: var(--p-border-radius-200);
border-top-right-radius: var(--p-border-radius-200);
Expand Down

0 comments on commit 2febd60

Please sign in to comment.