Skip to content

Commit

Permalink
[IconsPage] Fixed Facebook and Instagram icon not being shown in sear…
Browse files Browse the repository at this point in the history
…ch results (#11369)

### WHY are these changes introduced?

Fixes issue [#11368](#11368)
that I opened!

The `set` value for the facebook and instagram icons was set to `Minor`
instead of `minor`, which caused them to be missed in the minor icons
array on the `Icons` page.

### WHAT is this pull request doing?
I realized that the facebook and instagram icons weren't showing up
because of a casing issue. Now these icons should show up in both local
and global search!

<img width="1000" alt="Screenshot 2023-12-20 at 2 09 34 PM"
src="https://github.com/Shopify/polaris/assets/52360534/07f9abe5-ca7a-47b9-b4cb-d247c16144f3">

<img width="1000" alt="Screenshot 2023-12-20 at 2 10 58 PM"
src="https://github.com/Shopify/polaris/assets/52360534/4c955cc8-7831-4cf9-b705-e5a062119cdf">

### How to 🎩

🖥 [Local development
instructions](https://github.com/Shopify/polaris/blob/main/README.md#install-dependencies-and-build-workspaces)
🗒 [General tophatting
guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md)
📄 [Changelog
guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)

### 🎩 checklist

- [ ] Tested a
[snapshot](https://github.com/Shopify/polaris/blob/main/documentation/Releasing.md#-snapshot-releases)
- [ ] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [ ] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide
  • Loading branch information
isabelxklee authored Dec 21, 2023
1 parent b62cf73 commit 4b4d1ef
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions polaris-icons/icons/FacebookMinor.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
name: Facebook
set: Minor
description: Facebook logo
set: minor
description: Used to represent Facebook.
keywords:
- facebook
- Facebook
- social media
authors:
- Joe Thomas
Expand Down
6 changes: 3 additions & 3 deletions polaris-icons/icons/InstagramMinor.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
name: Instagram
set: Minor
description: Instagram logo
set: minor
description: Used to represent Instagram.
keywords:
- instagram
- Instagram
- social media
authors:
- Joe Thomas
Expand Down

0 comments on commit 4b4d1ef

Please sign in to comment.