From 4b4d1ef78083cede878a34626bca1087df3ddbf0 Mon Sep 17 00:00:00 2001 From: "isabel k. lee" <52360534+isabelxklee@users.noreply.github.com> Date: Thu, 21 Dec 2023 13:31:09 -0500 Subject: [PATCH] [IconsPage] Fixed Facebook and Instagram icon not being shown in search results (#11369) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ### WHY are these changes introduced? Fixes issue [#11368](https://github.com/Shopify/polaris/issues/11368) that I opened! The `set` value for the facebook and instagram icons was set to `Minor` instead of `minor`, which caused them to be missed in the minor icons array on the `Icons` page. ### WHAT is this pull request doing? I realized that the facebook and instagram icons weren't showing up because of a casing issue. Now these icons should show up in both local and global search! Screenshot 2023-12-20 at 2 09 34 PM Screenshot 2023-12-20 at 2 10 58 PM ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#install-dependencies-and-build-workspaces) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [ ] Tested a [snapshot](https://github.com/Shopify/polaris/blob/main/documentation/Releasing.md#-snapshot-releases) - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide --- polaris-icons/icons/FacebookMinor.yml | 6 +++--- polaris-icons/icons/InstagramMinor.yml | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/polaris-icons/icons/FacebookMinor.yml b/polaris-icons/icons/FacebookMinor.yml index 7ed2ed0d8d2..2eb575e46c1 100644 --- a/polaris-icons/icons/FacebookMinor.yml +++ b/polaris-icons/icons/FacebookMinor.yml @@ -1,8 +1,8 @@ name: Facebook -set: Minor -description: Facebook logo +set: minor +description: Used to represent Facebook. keywords: - - facebook + - Facebook - social media authors: - Joe Thomas diff --git a/polaris-icons/icons/InstagramMinor.yml b/polaris-icons/icons/InstagramMinor.yml index d0f5739b8bc..15a89b9f997 100644 --- a/polaris-icons/icons/InstagramMinor.yml +++ b/polaris-icons/icons/InstagramMinor.yml @@ -1,8 +1,8 @@ name: Instagram -set: Minor -description: Instagram logo +set: minor +description: Used to represent Instagram. keywords: - - instagram + - Instagram - social media authors: - Joe Thomas