Skip to content

Commit

Permalink
[ExceptionList] Manually migrate color custom properties for v11 to…
Browse files Browse the repository at this point in the history
… v12 (#10713)

### WHY are these changes introduced?

Resolves #10392.

### WHAT is this pull request doing?

Manually migrates `ExceptionList` component `color` custom properties.
    <details>
      <summary>ExceptionList — before</summary>
<img
src="https://github.com/Shopify/polaris/assets/26749317/4f99eaa5-4471-4a7b-9940-d4b6f742215b"
alt="ExceptionList — before">
    </details>
    <details>
      <summary>ExceptionList — after</summary>
<img
src="https://github.com/Shopify/polaris/assets/26749317/18de7848-25a8-4761-b848-779e6702ec3a"
alt="ExceptionList — after">
    </details>

### How to 🎩


[Storybook](https://5d559397bae39100201eedc1-vhfinvbqwa.chromatic.com/?path=/story/all-components-exceptionlist--all)
[Next branch
storybook](https://5d559397bae39100201eedc1-iqlmktwkqx.chromatic.com/?path=/story/all-components-exceptionlist--all)

🖥 [Local development
instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development)
🗒 [General tophatting
guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md)
📄 [Changelog
guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)

### 🎩 checklist

- [x] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [x] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide
  • Loading branch information
laurkim authored Sep 27, 2023
1 parent 4ab868e commit a3c9bfa
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions polaris-react/src/components/ExceptionList/ExceptionList.scss
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,12 @@

// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
.statusWarning & svg {
fill: var(--p-color-icon-caution);
fill: var(--p-color-text-caution);
}

// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
.statusCritical & svg {
fill: var(--p-color-icon-critical);
fill: var(--p-color-text-critical);
}
}

Expand All @@ -49,11 +49,11 @@
background-color: var(--p-color-icon-subdued);

.statusWarning & {
background-color: var(--p-color-icon-caution);
background-color: var(--p-color-text-caution);
}

.statusCritical & {
background-color: var(--p-color-icon-critical);
background-color: var(--p-color-text-critical);
}
}

Expand Down

0 comments on commit a3c9bfa

Please sign in to comment.