Skip to content

Commit

Permalink
fix rebase issues
Browse files Browse the repository at this point in the history
  • Loading branch information
kyledurand committed Aug 17, 2023
1 parent 8bb305c commit cb53f94
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 17 deletions.
22 changes: 11 additions & 11 deletions polaris-react/src/components/Banner/Banner.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import {CancelMinor} from '@shopify/polaris-icons';

import type {Action, DisableableAction, LoadableAction} from '../../types';
import {Text} from '../Text';
import {VerticalStack} from '../VerticalStack';
import type {InlineStackProps} from '../InlineStack';
import {InlineStack} from '../InlineStack';
import type {BoxProps} from '../Box';
Expand All @@ -27,6 +26,7 @@ import {classNames} from '../../utilities/css';
import {useBreakpoints} from '../../utilities/breakpoints';
import {useI18n} from '../../utilities/i18n';
import {useEventListener} from '../../utilities/use-event-listener';
import {BlockStack} from '../BlockStack';

import styles from './Banner.scss';
import type {BannerHandles} from './utilities';
Expand Down Expand Up @@ -198,7 +198,7 @@ export function DefaultBanner({

return (
<Box width="100%">
<VerticalStack align="space-between">
<BlockStack align="space-between">
<Box
background={backgroundColor}
color={textColor}
Expand All @@ -223,13 +223,13 @@ export function DefaultBanner({
</Box>
{hasContent && (
<Box padding={{xs: '3', md: '4'}} paddingBlockStart="3">
<VerticalStack gap="2">
<BlockStack gap="2">
<div>{children}</div>
{actionButtons}
</VerticalStack>
</BlockStack>
</Box>
)}
</VerticalStack>
</BlockStack>
</Box>
);
}
Expand Down Expand Up @@ -273,10 +273,10 @@ export function InlineIconBanner({
</div>
) : null}
<Box ref={contentNode} width="100%">
<VerticalStack gap="2">
<BlockStack gap="2">
<div>{children}</div>
{actionButtons}
</VerticalStack>
</BlockStack>
</Box>
</InlineStack>
</Box>
Expand Down Expand Up @@ -312,13 +312,13 @@ export function WithinContentContainerBanner({
<InlineStack gap="1_5-experimental" wrap={false}>
{bannerIcon}
<Box width="100%">
<VerticalStack gap="2">
<VerticalStack gap="05">
<BlockStack gap="2">
<BlockStack gap="05">
{bannerTitle}
<div>{children}</div>
</VerticalStack>
</BlockStack>
{actionButtons}
</VerticalStack>
</BlockStack>
</Box>
</InlineStack>
{dismissButton}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -139,10 +139,10 @@ function DefaultBanner({
<Box
background={backgroundColor}
color={textColor}
borderRadiusStartStart={smUp ? '3' : undefined}
borderRadiusStartEnd={smUp ? '3' : undefined}
borderRadiusEndStart={!hasContent && smUp ? '3' : undefined}
borderRadiusEndEnd={!hasContent && smUp ? '3' : undefined}
borderStartStartRadius={smUp ? '3' : undefined}
borderStartEndRadius={smUp ? '3' : undefined}
borderEndStartRadius={!hasContent && smUp ? '3' : undefined}
borderEndEndRadius={!hasContent && smUp ? '3' : undefined}
padding="3"
>
<InlineStack
Expand Down
2 changes: 1 addition & 1 deletion polaris-react/src/components/EmptyState/EmptyState.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {Box} from '../Box';
import {buttonFrom} from '../Button';
import {Image} from '../Image';
import {Text} from '../Text';
import {BlockStack} from '../VerticalStack';
import {BlockStack} from '../BlockStack';
import {InlineStack} from '../InlineStack';

import styles from './EmptyState.scss';
Expand Down
2 changes: 1 addition & 1 deletion polaris-react/src/components/SkeletonPage/SkeletonPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import React from 'react';

import {useI18n} from '../../utilities/i18n';
import {Box} from '../Box';
import {BlockStack} from '../VerticalStack';
import {BlockStack} from '../BlockStack';
import {InlineStack} from '../InlineStack';

import styles from './SkeletonPage.scss';
Expand Down

0 comments on commit cb53f94

Please sign in to comment.