Skip to content

Commit

Permalink
Remove preversion workaround for Changesets (#11449)
Browse files Browse the repository at this point in the history
Removes the `preversion` scripts that allowed us to call the
`preversion` npm script hook before creating a new release with
`@changesets/cli`.
  • Loading branch information
sam-b-rose authored Jan 17, 2024
1 parent 966d190 commit cc702cd
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 33 deletions.
4 changes: 1 addition & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,8 @@
"type-check": "tsc --build",
"changeset": "changeset",
"gen-assets": "turbo run gen-assets --filter=polaris.shopify.com",
"preversion-packages": "node scripts/preversion.js",
"version-packages": "yarn preversion-packages && changeset version",
"version-packages": "changeset version",
"release": "turbo run build --filter='!polaris.shopify.com' && changeset publish",
"preversion": "echo \"Error: use @changsets/cli to version packages\" && exit 1",
"new-migration": "yarn workspace @shopify/polaris-migrator generate",
"postinstall": "patch-package"
},
Expand Down
24 changes: 0 additions & 24 deletions scripts/preversion.js

This file was deleted.

18 changes: 12 additions & 6 deletions turbo.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,25 +3,31 @@
"baseBranch": "origin/main",
"pipeline": {
"build": {
"outputs": ["dist/**", ".next/**", "build/**", ".cache/**"],
"dependsOn": ["^build"]
"outputs": [
"dist/**",
".next/**",
"build/**",
".cache/**"
],
"dependsOn": [
"^build"
]
},
"test": {
"outputs": [],
"dependsOn": []
},
"lint": {
"outputs": [".eslintcache"]
"outputs": [
".eslintcache"
]
},
"dev": {
"cache": false
},
"clean": {
"cache": false
},
"preversion": {
"cache": false
},
"gen-assets": {
"cache": false
}
Expand Down

0 comments on commit cc702cd

Please sign in to comment.