Skip to content

Commit

Permalink
@shopify/polaris-icons v8.0.0 (#11138)
Browse files Browse the repository at this point in the history
> [!Warning]
> This includes multiple breaking changes to `@shopify/polaris-icons`.
Do not merge until this is thoroughly tested and approved by internal
consuming teams.

### What this PR does

Removed Major and Minor icon sizing. All icons are the same size.

Added `BillIcon`, `BillFilledIcon`, `LogoCriteo`, `LogoMeta`,
`LogoGoogle`, `MetaobjectFilledIcon`, `PriceListIcon` and
`PriceListFilledIcon`

Updated icon design for `JobsIcon`, `JobsFilledIcon`, `AutomationIcon`,
`AutomationFilledIcon`, `GiftCardIcon`, `InventoryFilledIcon`,
`ReportsIcon`, `ShipmentFilledIcon`, `AppsFilledIcon`, `MarketsIcon`,
`MarketsFilledIcon`, `BillingStatementDollarFilledIcon`,
`BillingStatementEuroFilledIcon`, `BillingStatementPoundFilledIcon`,
`BillingStatementRupeeFilledIcon`, `BillingStatementYenFilledIcon`,
`LegalFilledIcon`, `IdentityCardIcon`, `IdentityCardFilledIcon`,
`DomainsIcon`, `DomainNewIcon`, `DomainsFilledIcon`, `StoreIcon`,
`OnlineStoreIcon`, `ManagedStoreIcon`, `ImportStoreIcon`, `TaxIcon`,
`TaxFilledIcon`, `PackageFilledIcon`, `LocationIcon`,
`LocationFilledIcon`, `InactiveLocationIcon`, `PinIcon`, `GlobeIcon`,
`TransportIcon`, `NatureIcon`, `FoodIcon`, `ColorsIcon`

Removed icons `ReportFilledMinor`, `ReportMinor`, `ListMajor`,
`ListFilledMajor`

Removed `version` and `set` from icon `.yml` files

---

Closes #11259
Closes #11088

---------

Co-authored-by: Sam Rose <11774595+sam-b-rose@users.noreply.github.com>
Co-authored-by: Aaron Casanova <aaron.casanova@shopify.com>
Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com>
Co-authored-by: Alex Bratsos <12677111+bratsos@users.noreply.github.com>
  • Loading branch information
5 people authored Jan 15, 2024
1 parent 297c69e commit f91c4b6
Show file tree
Hide file tree
Showing 2,017 changed files with 12,747 additions and 9,966 deletions.
5 changes: 5 additions & 0 deletions .changeset/heavy-cougars-listen.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/polaris-migrator': minor
---

Added `icons-v8-update-names` migration. This migration will update all icons from `@shopfiy/polaris-icons` from the deprecated Major and Minor suffixes to the new Icon suffix (ex: `AppsMajor` -> `AppsIcon`).
1,047 changes: 1,047 additions & 0 deletions .changeset/wild-ties-join.md

Large diffs are not rendered by default.

2 changes: 0 additions & 2 deletions .github/CODEOWNERS

This file was deleted.

10 changes: 0 additions & 10 deletions .github/ISSUE_TEMPLATE/NEW_ICON.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,16 +20,6 @@ body:
label: Icon name
validations:
required: true
- type: dropdown
id: icon-set
attributes:
label: What type of icon set?
options:
- Major (20x20)
- Minor (16x16)
- Unsure
validations:
required: true
- type: textarea
id: icon-description
attributes:
Expand Down
10 changes: 0 additions & 10 deletions .github/ISSUE_TEMPLATE/UPDATE_ICON.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,16 +20,6 @@ body:
label: Icon name
validations:
required: true
- type: dropdown
id: icon-set
attributes:
label: What type of icon set?
options:
- Major (20x20)
- Minor (16x16)
- Unsure
validations:
required: true
- type: textarea
id: icon-figma-link
attributes:
Expand Down
27 changes: 0 additions & 27 deletions polaris-icons/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,30 +25,3 @@ If you can’t find the icons you need, you can [propose new icons](https://gith
## Proposing updates to existing icons

If you notice existing icons that are out-of-date or need improvements, you can [propose an update](https://github.com/Shopify/polaris/issues/new?assignees=&labels=Icon&template=UPDATE_ICON.yml&title=%5BIcon%5D%3A+Update+icon+%3Cicon-name%3E) to these icons.

## Deprecation guidelines

Sometimes icons need to be renamed or removed. Both of these actions are breaking changes from a developer’s perspective. In order to not erode trust with our consumers and ensure painless update paths we will reduce the impact of these breaking changes by batching them up.

### Deleting an icon

When you deprecate an icon with no replacement (that is, the icon should be deleted in the future), add `deprecated: true` to the icon’s metadata:

```yml
deprecated: true
```
### Renaming an icon
When you deprecate an icon with a replacement (that is, you rename an icon), rename the icon’s SVGs and metadata file, then add a `deprecated_aliases` key to the metadata with an array containing each of the icon’s previous names. For instance, if you were to rename `OldMajor.yml` to `NewMajor.yml`, add these lines to `NewMajor.yml`:

```yml
# NewMajor.yml
---
deprecated_aliases:
- OldMajor
```

This will maintain an export with the original name but mark it as deprecated and instruct consumers to use the new name.

Every 6 months or so, we’ll consider releasing a new major version that removes any deprecated icons and aliases.
4 changes: 2 additions & 2 deletions polaris-icons/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,13 @@ Import the [`Icon`](https://polaris.shopify.com/components/images-and-icons/icon
2. Import an icon from Polaris icons:

```tsx
import {AddMajor} from '@shopify/polaris-icons';
import {PlusIcon} from '@shopify/polaris-icons';
```

3. Pass the imported Polaris icon to the `source` prop of the `Icon` component:

```tsx
<Icon source={AddMajor} />
<Icon source={PlusIcon} />
```

### SVG files
Expand Down
13 changes: 0 additions & 13 deletions polaris-icons/icons/AbandonedCartFilledMajor.yml

This file was deleted.

14 changes: 0 additions & 14 deletions polaris-icons/icons/AbandonedCartMajor.yml

This file was deleted.

18 changes: 0 additions & 18 deletions polaris-icons/icons/AccessibilityMajor.yml

This file was deleted.

16 changes: 0 additions & 16 deletions polaris-icons/icons/ActivitiesMajor.yml

This file was deleted.

12 changes: 0 additions & 12 deletions polaris-icons/icons/AddCodeMajor.yml

This file was deleted.

12 changes: 0 additions & 12 deletions polaris-icons/icons/AddImageMajor.yml

This file was deleted.

14 changes: 0 additions & 14 deletions polaris-icons/icons/AddMajor.yml

This file was deleted.

12 changes: 0 additions & 12 deletions polaris-icons/icons/AddNoteMajor.yml

This file was deleted.

14 changes: 0 additions & 14 deletions polaris-icons/icons/AddProductMajor.yml

This file was deleted.

File renamed without changes
14 changes: 14 additions & 0 deletions polaris-icons/icons/AdjustIcon.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
name: Adjust
description: Used to denote that an adjustment can be made.
keywords:
- adjust
- adjustment
- controls
- dials
authors:
- James Findlater
- Chris Poirier
- Lauren Mayers
- Joe Thomas
date_added: 2022-02-02
date_modified: 2023-06-23
17 changes: 0 additions & 17 deletions polaris-icons/icons/AdjustMinor.yml

This file was deleted.

File renamed without changes
8 changes: 8 additions & 0 deletions polaris-icons/icons/AffiliateIcon.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
name: Affiliate
authors:
- Joe Thomas
description: N/A
keywords:
- N/A
date_added: 2019-03-15
date_modified: 2023-06-23
12 changes: 0 additions & 12 deletions polaris-icons/icons/AffiliateMajor.yml

This file was deleted.

1 change: 1 addition & 0 deletions polaris-icons/icons/AirplaneIcon.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
14 changes: 14 additions & 0 deletions polaris-icons/icons/AirplaneIcon.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
name: Airplane
description: Used as a navigation item in our emoji picker for the transport category.
keywords:
- transport
- plane
- airplane
- emoji
- navigation
authors:
- Adam Whitcroft
- Joe Thomas
- José Torre
date_added: 2019-03-15
date_modified: 2023-11-07
File renamed without changes
10 changes: 10 additions & 0 deletions polaris-icons/icons/AlertBubbleIcon.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
name: Alert bubble
description: Used to represent a dispute or important conversation or notification.
keywords:
- dispute
- claim
authors:
- Adam Whitcroft
- Joe Thomas
date_added: 2018-11-14
date_modified: 2023-06-23
File renamed without changes
15 changes: 15 additions & 0 deletions polaris-icons/icons/AlertCircleIcon.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
name: Alert circle
description: Used to alert merchants of a warning message.
keywords:
- attention
- alert
- warning
- exclamation
- bang
- circle
- round
authors:
- Adam Whitcroft
- Joe Thomas
date_added: 2019-02-21
date_modified: 2023-06-23
File renamed without changes
15 changes: 15 additions & 0 deletions polaris-icons/icons/AlertDiamondIcon.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
name: Alert diamond
description: Used to alert merchants of a critical error.
keywords:
- alert
- attention
- critical
- diamond
- error
- exclamation
- bang
authors:
- Jesse Bennett-Chamberlain
- Joe Thomas
date_added: 2023-01-16
date_modified: 2023-06-23
1 change: 0 additions & 1 deletion polaris-icons/icons/AlertMinor.svg

This file was deleted.

18 changes: 0 additions & 18 deletions polaris-icons/icons/AlertMinor.yml

This file was deleted.

File renamed without changes
12 changes: 12 additions & 0 deletions polaris-icons/icons/AlertTriangleIcon.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
name: Alert triangle
description: Used to represent risk associated with orders.
keywords:
- risk
- warning
- triangle
- alert
authors:
- Adam Whitcroft
- Joe Thomas
date_added: 2018-11-14
date_modified: 2023-06-23
13 changes: 0 additions & 13 deletions polaris-icons/icons/AnalyticsBarHorizontalMinor.yml

This file was deleted.

Loading

0 comments on commit f91c4b6

Please sign in to comment.