Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification on why Grid#areas is deprecated #10080

Closed
slack-github-archiver bot opened this issue Aug 16, 2023 · 0 comments · Fixed by #10079
Closed

Clarification on why Grid#areas is deprecated #10080

slack-github-archiver bot opened this issue Aug 16, 2023 · 0 comments · Fixed by #10079

Comments

@slack-github-archiver
Copy link

⚠️🚨⚠️ Project/labels may still need to be added ⚠️🚨⚠️

Summary

  • Sydney noticed that the grid component has deprecated "areas" and was unsure about what nested layout components to use instead.
  • Olivier found a reference to the change on GitHub and suggested that it might be related to the Shopify API documentation.
  • Sydney was uncertain if the suggested solution could be used to rearrange the cells based on screen size.
  • Olivier suggested trying with rows set to auto or fill.
  • Jess clarified that nested layout components refer to nesting any of the "Layout and Structure" components within the grid cells.

This summary was generated using OpenAI's gpt-4 with a temperature of 0.5.

🧵 Slack Thread
User Message
Sydney Rhude
2023‑08‑15 15:31
We noticed that the grid component has deprecated "areas" and suggests using "nested layout components instead" and we're just wondering what nested layout components are suggested? (We thought maybe Layout but that component doesn't allow a similar behaviour so we're just trying to figure out what t o use instead)
Sydney Rhude
2023‑08‑15 16:07
cc: @zeachco @suarezgary
Olivier Rousseau-Guyot
2023‑08‑15 16:14
found something: #8984 which refers to https://shopify.dev/docs/api/[…]/structure/grid maybe it should have been in the doc
Sydney Rhude
2023‑08‑15 16:15
Oh interesting, but that still can't be used to re-arrange the cells depending on the screen size can it? It's just for re-sizing?
Olivier Rousseau-Guyot
2023‑08‑15 16:18
I think in your case, which is not exactly a grid with a template matching height for each cell, it doesn't work well, no. But maybe, worth trying with rows to auto or fill
Jess Telford
2023‑08‑16 01:43
Nested layout components refers to nesting any of the "Layout and Structure" components within your grid cells.

Jess Telford archived this conversation from polaris at 2023‑08‑16 01:45.
All times are in UTC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant