Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add migration for prop renaming and allow for adding prop values #10084

Closed
Tracked by #9914
kyledurand opened this issue Aug 16, 2023 · 0 comments · Fixed by #10071
Closed
Tracked by #9914

Add migration for prop renaming and allow for adding prop values #10084

kyledurand opened this issue Aug 16, 2023 · 0 comments · Fixed by #10071
Assignees
@kyledurand
Labels
#gsd:36573 Polaris API Alignment

Comments

@kyledurand
Copy link
Member

kyledurand commented Aug 16, 2023 •
edited
Loading

<Layout.Section oneHalf /> => <Layout.Seciton variant="oneHalf" />
@kyledurand kyledurand mentioned this issue Aug 16, 2023
Closed
@kyledurand kyledurand self-assigned this Aug 16, 2023
@kyledurand kyledurand added #gsd:36573 Polaris API Alignment and removed untriaged labels Aug 16, 2023
@kyledurand kyledurand mentioned this issue Aug 16, 2023
Merged
@kyledurand kyledurand changed the title Modify prop renaming migration to allow for adding prop values Add migration for prop renaming and allow for adding prop values Aug 16, 2023
kyledurand added a commit that referenced this issue Aug 17, 2023
@kyledurand
Allow migrator to target subcomponents and change prop values (#10071)
23c1391 
Closes #10084

First pass at allowing prop values to be changed through migrations. 
Also needed to allow support for finding compound components in the
rename prop migration

**Question**
Should this be merged into main? Or left in next until it's tested?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kyledurand kyledurand

Labels
#gsd:36573 Polaris API Alignment
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow migrator to target subcomponents and change prop values Shopify/polaris
1 participant
@kyledurand