Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button - Remove or deprecate connectedDisclosure #10126

Closed
3 tasks done
Tracked by #9914
kyledurand opened this issue Aug 18, 2023 · 0 comments
Closed
3 tasks done
Tracked by #9914

Button - Remove or deprecate connectedDisclosure #10126

kyledurand opened this issue Aug 18, 2023 · 0 comments
Assignees
@kyledurand
Labels
#gsd:36573 Polaris API Alignment

Comments

@kyledurand
Copy link
Member

kyledurand commented Aug 18, 2023 •
edited
Loading

Investigate how difficult it might be to replicate this prop using existing components. I don't think creating a migration would be possible because it would likely involve a button group, popover, and icon import

  • Investigate alternatives to this UX
  • Remove connectedDisclosure on the next branch
  • Deprecate connectedDisclosure on the main branch
@kyledurand kyledurand mentioned this issue Aug 18, 2023
Closed
@kyledurand kyledurand added #gsd:36573 Polaris API Alignment and removed untriaged labels Aug 18, 2023
@kyledurand kyledurand self-assigned this Aug 23, 2023
@kyledurand kyledurand mentioned this issue Aug 23, 2023
Merged
@sam-b-rose sam-b-rose mentioned this issue Aug 23, 2023
Merged
@kyledurand kyledurand mentioned this issue Aug 23, 2023
Merged
kyledurand added a commit that referenced this issue Aug 23, 2023
@kyledurand
[Button] Deprecate connectedDisclosure (#10183)
7891c7e 
<!--
  ☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
  - Start with a verb, for example: Add, Delete, Improve, Fix…
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

### WHY are these changes introduced?

Part of #10126
kyledurand added a commit that referenced this issue Aug 24, 2023
@kyledurand
[Button] Remove connectedDisclosure (#10182)
e814c0e 
<!--
  ☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
  - Start with a verb, for example: Add, Delete, Improve, Fix…
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

### WHY are these changes introduced?

Fixes #10126

<!--
  Context about the problem that’s being addressed.
-->

### WHAT is this pull request doing?

Removes all code related to connectedDisclosure
Updates the split example to use Popover, ActionList, and ButtonGroup
sophschneider pushed a commit that referenced this issue Sep 19, 2023
@kyledurand @sophschneider
[Button] Remove connectedDisclosure (#10182)
4d15e25 
<!--
  ☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
  - Start with a verb, for example: Add, Delete, Improve, Fix…
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

Fixes #10126

<!--
  Context about the problem that’s being addressed.
-->

Removes all code related to connectedDisclosure
Updates the split example to use Popover, ActionList, and ButtonGroup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kyledurand kyledurand

Labels
#gsd:36573 Polaris API Alignment
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kyledurand