Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Buttons] Make sure button have sufficient click target #10128

Closed
yesenia-perezcruz opened this issue Aug 18, 2023 · 5 comments
Closed

[Buttons] Make sure button have sufficient click target #10128

yesenia-perezcruz opened this issue Aug 18, 2023 · 5 comments
Labels
Needs design This issue requires some design definition before implementing Uplift polish Fast follow fixes and polish post Summer Editions

Comments

@yesenia-perezcruz
Copy link

We've received some merchant feedback that the smaller Uplift buttons are harder to click. I think this has less to do with the size and more to do about the space around it, especially Button Group.

Image

Logging this so a designer can have a lot to see if there's any places where Buttons don't have sufficient padding.

@yesenia-perezcruz yesenia-perezcruz added untriaged Uplift polish Fast follow fixes and polish post Summer Editions labels Aug 18, 2023
@yurm04 yurm04 added the Needs design This issue requires some design definition before implementing label Dec 4, 2023
@heyjoethomas
Copy link
Contributor

Looking at the most common ButtonGroup instances in the admin, I see they all have 8px of space between buttons. Not sure adding more space between buttons would really solve much as click target sizes would remain the same.

@heyjoethomas heyjoethomas removed the Needs design This issue requires some design definition before implementing label Dec 7, 2023
@yesenia-perezcruz
Copy link
Author

@heyjoethomas I'm wondering if this feedback was initial change aversion to the buttons getting smaller. I haven't heard it being an issue recently.

@heyjoethomas
Copy link
Contributor

@heyjoethomas I'm wondering if this feedback was initial change aversion to the buttons getting smaller. I haven't heard it being an issue recently.

That is my best guess. The buttons did get a bit smaller for uplift. Basic buttons went from 36px tall -> 28px tall. So my guess is that just threw people off.

@yurm04 yurm04 added the Needs design This issue requires some design definition before implementing label Dec 8, 2023
@yurm04
Copy link
Contributor

yurm04 commented Dec 8, 2023

Want to make sure before i close: is there any action to be taken to address this issue?

@heyjoethomas
Copy link
Contributor

heyjoethomas commented Dec 8, 2023 via email

@lgriffee lgriffee closed this as completed Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs design This issue requires some design definition before implementing Uplift polish Fast follow fixes and polish post Summer Editions
Projects
None yet
Development

No branches or pull requests

5 participants