Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Icon]: Update icon DragHandle #11372

Closed
Rusty-UX opened this issue Dec 21, 2023 · 6 comments
Closed

[Icon]: Update icon DragHandle #11372

Rusty-UX opened this issue Dec 21, 2023 · 6 comments
Labels
Icon Polaris iconography untriaged

Comments

@Rusty-UX
Copy link
Contributor

Rusty-UX commented Dec 21, 2023

Why are you proposing this update?

New DragHandle Icon

Design by @Rusty-UX and @heyjoethomas

The existing drag handle icon is designed to have visual weight and harmony amongst other icons. We've received feedback from @CynthiaSavard that it appears as decorative or as informational, when really it's UI control. Because it's a UI control, it should be presented as such.

Approach

New drag handle has tighter spacing, sizing, and mass to make it feel more like a native UI control. We’ve also adjusted the alignment and even though it’s slightly smaller it has better edge clarity rendering on 1x than the current icon.

Render Tests

Icons - 2x
Icons - 1x
Render-Test

Icon name

DragHandle

What type of icon set?

Major (20x20)

Icon Figma link

https://www.figma.com/file/CqnyPihLh00JfkpjuDQjQq/Untitled?type=design&node-id=1%3A13359&mode=design&t=vkh6ej4oen6qwIfN-1

Icon SVG code

<svg width="20" height="20" viewBox="0 0 20 20" fill="none" xmlns="http://www.w3.org/2000/svg">
<path d="M6.75 3.75C6.33579 3.75 6 4.08579 6 4.5V5.5C6 5.91421 6.33579 6.25 6.75 6.25H7.75C8.16421 6.25 8.5 5.91421 8.5 5.5V4.5C8.5 4.08579 8.16421 3.75 7.75 3.75H6.75Z" fill="#8A8A8A"/>
<path d="M6.75 8.75C6.33579 8.75 6 9.08579 6 9.5V10.5C6 10.9142 6.33579 11.25 6.75 11.25H7.75C8.16421 11.25 8.5 10.9142 8.5 10.5V9.5C8.5 9.08579 8.16421 8.75 7.75 8.75H6.75Z" fill="#8A8A8A"/>
<path d="M6 14.5C6 14.0858 6.33579 13.75 6.75 13.75H7.75C8.16421 13.75 8.5 14.0858 8.5 14.5V15.5C8.5 15.9142 8.16421 16.25 7.75 16.25H6.75C6.33579 16.25 6 15.9142 6 15.5V14.5Z" fill="#8A8A8A"/>
<path d="M12.25 3.75C11.8358 3.75 11.5 4.08579 11.5 4.5V5.5C11.5 5.91421 11.8358 6.25 12.25 6.25H13.25C13.6642 6.25 14 5.91421 14 5.5V4.5C14 4.08579 13.6642 3.75 13.25 3.75H12.25Z" fill="#8A8A8A"/>
<path d="M11.5 9.5C11.5 9.08579 11.8358 8.75 12.25 8.75H13.25C13.6642 8.75 14 9.08579 14 9.5V10.5C14 10.9142 13.6642 11.25 13.25 11.25H12.25C11.8358 11.25 11.5 10.9142 11.5 10.5V9.5Z" fill="#8A8A8A"/>
<path d="M12.25 13.75C11.8358 13.75 11.5 14.0858 11.5 14.5V15.5C11.5 15.9142 11.8358 16.25 12.25 16.25H13.25C13.6642 16.25 14 15.9142 14 15.5V14.5C14 14.0858 13.6642 13.75 13.25 13.75H12.25Z" fill="#8A8A8A"/>
</svg>

Are there any other important details?

No response

@Rusty-UX Rusty-UX added Icon Polaris iconography untriaged labels Dec 21, 2023
@isabelxklee
Copy link
Contributor

hey @Rusty-UX! i'm interested in working on this. 👀 do you mind assigning this issue to me? also i just requested access to the figma icon link from my email, isabelxklee@gmail.com!

@Rusty-UX Rusty-UX assigned isabelxklee and unassigned isabelxklee Jan 4, 2024
@Rusty-UX
Copy link
Contributor Author

Rusty-UX commented Jan 4, 2024

Awesome! Thanks so much @isabelxklee - Will follow up with you asap, just need to do a round of review with @CynthiaSavard first!

@isabelxklee
Copy link
Contributor

@Rusty-UX awesome, sounds good!

@Rusty-UX
Copy link
Contributor Author

Rusty-UX commented Jan 9, 2024

Ok @isabelxklee this one is ready to go. Let me know if you need anything else - granted access to figma.
Is it possible to share a tophatting link once you have something ready?

@isabelxklee
Copy link
Contributor

@Rusty-UX perfect! i'll work on this, this week. and yes, will share a tophat link when i'm ready. :-)

@isabelxklee
Copy link
Contributor

isabelxklee commented Jan 15, 2024

@Rusty-UX heyo! i updated the icon in this PR, but i can't figure out how to create a link for tophatting. 🤔

UPDATE: this issue should be closed since @alex-page has updated this icon in this commit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Icon Polaris iconography untriaged
Projects
None yet
Development

No branches or pull requests

3 participants