adds IncentivesIcon #11420
adds IncentivesIcon #11420
Conversation
jonarnaldo
force-pushed
the
adds_incentive_icon
branch
2 times, most recently
from
6c0afee
to
af4c3bb
Compare
|
@jonarnaldo what is the urgency on this icon request? |
|
@jonarnaldo as discussed in Slack. We are about to ship a major release for icons (this week or next week). Adding this icon is going to be delayed until that icon ships. There are work arounds you can do in mobile and shopify/web to use this icon ASAP. When this ships we can come back and clean up the work arounds. |
|
Wanted to circle back and see if this is good to go yet? We'd love to get this up there as it unblocks this ticket for our team and closes this earlier icon request |
|
The major release of icons is released and we need to update this PR to follow the new naming conventions. We also removed version exclusive_use and set from icon .yml files. Take a look here for more information: #11138 |
cody-robinson-shopify
force-pushed
the
adds_incentive_icon
branch
from
2a63567
to
c23f695
Compare
|
Please add the live, unflattened svg to this file. Let me know when it's in there and I can approve. |
|
@heyjoethomas - Icon I believe has been added to the figma!
|
|
@jonarnaldo this should be good to merge if you'd like! All ✅'s have passed |
|
/shipit |
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-icons@8.2.0 ### Minor Changes - [#11420](#11420) [`7bb7054e8`](7bb7054) Thanks [@jonarnaldo](https://github.com/jonarnaldo)! - Added `IncentiveIcon` ## @shopify/polaris@12.11.2 ### Patch Changes - [#11523](#11523) [`9486e487e`](9486e48) Thanks [@oksanashopify](https://github.com/oksanashopify)! - fix z-index for IndexTable rows of type `child` - [#11525](#11525) [`09b4f00b3`](09b4f00) Thanks [@laurkim](https://github.com/laurkim)! - Fixed border radius styles for `Button` within `ButtonGroup` when `connectedTop` prop applied - [#11524](#11524) [`a0283410a`](a028341) Thanks [@mrcthms](https://github.com/mrcthms)! - Updated logic in IndexTable to recalculate sticky position when children changes - Updated dependencies \[[`7bb7054e8`](7bb7054)]: - @shopify/polaris-icons@8.2.0 ## polaris.shopify.com@0.62.2 ### Patch Changes - Updated dependencies \[[`9486e487e`](9486e48), [`09b4f00b3`](09b4f00), [`7bb7054e8`](7bb7054), [`a0283410a`](a028341)]: - @shopify/polaris@12.11.2 - @shopify/polaris-icons@8.2.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
### WHY are these changes introduced? Adds a new incentives icon to the Polaris Icons library as part of [US GPV Acquisition Incentive](https://vault.shopify.io/gsd/projects/37720) closes Shopify/incentives#1640 ### WHAT is this pull request doing? Adding `IncentivesMajor` so it can be used for any incentives notifications/banners etc.  ### How to 🎩 n/a --------- Co-authored-by: Cody Robinson <cody.robinson@shopify.com> Co-authored-by: Sam Rose <11774595+sam-b-rose@users.noreply.github.com>
WHY are these changes introduced?
Adds a new incentives icon to the Polaris Icons library as part of US GPV Acquisition Incentive
closes https://github.com/Shopify/incentives/issues/1640
WHAT is this pull request doing?
Adding
IncentivesMajorso it can be used for any incentives notifications/banners etc.How to 🎩
n/a