Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Toast] Deprecate error prop in favour of tone+leadingIcon prop. #11451

Closed
lone-star opened this issue Jan 16, 2024 · 1 comment
Closed

[Toast] Deprecate error prop in favour of tone+leadingIcon prop. #11451

lone-star opened this issue Jan 16, 2024 · 1 comment

Comments

@lone-star
Copy link
Contributor

Feature request summary

We must remove the error prop from the Toast component. The error styling will be achievable by using new props that are being introduced to the Toast component: tone and leadingIcon.

Rationale

Currently the error property in the toast component will activate the styling of the Toast for errors. With the introduction of additional styles (such as magic), we need a more generic way to specify custom colour schemes. Since the tone style is being introduced across Polaris, we will should migrate the Toast component from a dedicated property to using the tone style.

This first PR introduces the magic styles to the Toast component: #11431 as well as the base props.


Work to be done:

  1. Add the tone and leadingIcon props to the Toast component: [Toast] Add tone, actionOnComponent and leadingIcon props to Toast #11431
  2. Add error styles to the tone prop and migrate all error usages to tone+leadingIcon. Mark the error prop as deprecated.
  3. Remove the error prop in v13
@lone-star lone-star changed the title [Toast] Deprecate error prop in favour of tone prop. [Toast] Deprecate error prop in favour of tone+leadingIcon prop. Jan 16, 2024
@lone-star lone-star self-assigned this Jan 16, 2024
Copy link
Contributor

Hi! We noticed there hasn’t been activity on this issue in a while. After 30 days, it will close automatically.

If it’s still relevant, or you have updates, comment and let us know. And don’t worry, you can always re-open later if needed.

@lone-star lone-star removed their assignment Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant