You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We must remove the error prop from the Toast component. The error styling will be achievable by using new props that are being introduced to the Toast component: tone and leadingIcon.
Rationale
Currently the error property in the toast component will activate the styling of the Toast for errors. With the introduction of additional styles (such as magic), we need a more generic way to specify custom colour schemes. Since the tone style is being introduced across Polaris, we will should migrate the Toast component from a dedicated property to using the tone style.
This first PR introduces the magic styles to the Toast component: #11431 as well as the base props.
lone-star
changed the title
[Toast] Deprecate error prop in favour of tone prop.
[Toast] Deprecate error prop in favour of tone+leadingIcon prop.
Jan 16, 2024
Feature request summary
We must remove the
error
prop from the Toast component. The error styling will be achievable by using new props that are being introduced to the Toast component:tone
andleadingIcon
.Rationale
Currently the
error
property in the toast component will activate the styling of the Toast for errors. With the introduction of additional styles (such asmagic
), we need a more generic way to specify custom colour schemes. Since thetone
style is being introduced across Polaris, we will should migrate theToast
component from a dedicated property to using thetone
style.This first PR introduces the
magic
styles to the Toast component: #11431 as well as the base props.Work to be done:
tone
andleadingIcon
props to the Toast component: [Toast] Add tone, actionOnComponent and leadingIcon props to Toast #11431error
styles to thetone
prop and migrate allerror
usages totone
+leadingIcon
. Mark theerror
prop asdeprecated
.error
prop in v13The text was updated successfully, but these errors were encountered: