Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PositionedOverlay with original AlphaHovercard changes and release independently #11748

Closed
3 tasks
Tracked by #8931
yurm04 opened this issue Mar 15, 2024 · 1 comment
Closed
3 tasks
Tracked by #8931
Assignees

Comments

@yurm04
Copy link
Contributor

yurm04 commented Mar 15, 2024

Rip out changes to PositionedOverlay and all related changes from these two PRs (1, 2) and put them in their own PR. May be able to move all this into the existing PR that Chloe's opened

THOROUGHLY tophat these changes because PositionedOverlay is used for popovers and tooltips as well. When properly vetted, merge to main and bump the version of @shopify/polaris in Web

Make PositionedOverlay updates available to HoverCard in @shopify/web

@yurm04 yurm04 added the #gsd:38846 Admin Quality Improvements (Q1 2024) label Mar 15, 2024
@yurm04 yurm04 self-assigned this Mar 20, 2024
@lgriffee lgriffee removed the #gsd:38846 Admin Quality Improvements (Q1 2024) label Mar 29, 2024
Copy link
Contributor

Hi! We noticed there hasn’t been activity on this issue in a while. After 30 days, it will close automatically.

If it’s still relevant, or you have updates, comment and let us know. And don’t worry, you can always re-open later if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants