Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Spinner component #12450

Open
bernardojoaogarcia opened this issue Jul 24, 2024 · 3 comments
Open

New Spinner component #12450

bernardojoaogarcia opened this issue Jul 24, 2024 · 3 comments
Assignees
Labels
#gsd:38420 Top bar and global reframe project Priority: Medium Non-blocking regression, noticable inconcistency, or important feature

Comments

@bernardojoaogarcia
Copy link

bernardojoaogarcia commented Jul 24, 2024

Add new Spinner component to the Topbar. Either contribute new spinner component to Polaris internal or keep it isolated for topbar for the time being.

Image

Image

We will need to change the color of the spinner depending on where it is used. This should be baked into the component that is using it because of one off contextual changes. Admin UI foundations UX work is aligned with this.

@bernardojoaogarcia bernardojoaogarcia added #gsd:38420 Top bar and global reframe project Priority: Medium Non-blocking regression, noticable inconcistency, or important feature labels Jul 24, 2024
@alex-page
Copy link
Member

alex-page commented Jul 25, 2024

Consider this timeless design

Screenshot 2024-07-25 at 21 29 08

@sophschneider sophschneider removed their assignment Jul 25, 2024
@bernardojoaogarcia
Copy link
Author

Image

Here is some progress work to unify tokens for the new spinner. I'll review these concepts beginning of next week with @sarahill

@sophschneider sophschneider added Priority: Low Small, subtle details Priority: Medium Non-blocking regression, noticable inconcistency, or important feature and removed Priority: Medium Non-blocking regression, noticable inconcistency, or important feature Priority: Low Small, subtle details labels Jul 29, 2024
@sophschneider
Copy link
Contributor

moving this to ice box as we are discussing if this is worth investing in now or waiting for ui foundations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#gsd:38420 Top bar and global reframe project Priority: Medium Non-blocking regression, noticable inconcistency, or important feature
Projects
None yet
Development

No branches or pull requests

3 participants