Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPIC] Implement new HoverCard on Orders index table in the admin #8931

Closed
12 of 16 tasks
alex-page opened this issue Apr 12, 2023 · 5 comments
Closed
12 of 16 tasks

[EPIC] Implement new HoverCard on Orders index table in the admin #8931

alex-page opened this issue Apr 12, 2023 · 5 comments
Assignees
Labels
#gsd:35526 Orders Split Cart HoverCard no-issue-activity Priority: Urgent Bug blocking merchants, or critical directive

Comments

@alex-page
Copy link
Member

alex-page commented Apr 12, 2023

  1. Look into what Chloe has shipped so far
  2. Read context below
  3. Scope out work to actually ship the action tooltip to web
  4. Ship

=== context ===

Prototype: https://tooltip-prototype.shopifycloud.com/6/action
Figma: https://www.figma.com/file/64twmvaeh0gEXs3pZcueRe/Tooltips?node-id=461-11097&viewport=-417%2C318%2C0.15
Parent issue: https://github.com/Shopify/web/issues/78351.
Raised by: @Shopify/core-operate-workflows-quality-crew

Remaining Tasks

  1. #gsd:38846
    gwyneplaine lgriffee
    yurm04
  2. 2 of 2
    #gsd:38846
    yurm04
  3. 2 of 3
    no-issue-activity
    yurm04
  4. no-issue-activity
  5. 0 of 3
    no-issue-activity
    yurm04
  6. gwyneplaine
  7. no-issue-activity
  8. no-issue-activity
  9. #gsd:38846
    gwyneplaine yurm04

Pending decisions

  1. no-issue-activity
    yoummyy

Decisions

** Caveat:
If we require a delay for queries, it needs to be consistent across all hover cards. We can't have some that open instantly, some that are delayed
Demo the above and confirm alignment

@martenbjork
Copy link
Contributor

martenbjork commented Apr 12, 2023

I have a take on this :)

TLDR: The admin needs a global hover card component that takes care of all the heavy lifting. That way, we can add hover cards across the admin in a consistent and scalable way. CodeSandbox that's mentioned in the video

global-hover-thingies.mp4

@yesenia-perezcruz
Copy link

I really love that proposal @martenbjork. It's a great example of a solution that's scaleable but also specific to Shopify's admin. I also like that you're looking at the problem with another zoom level.

@chloerice @alex-page How do you think this would impact the near-term work? We had talked about shipping the IndexTable tooltip in one place and then asking teams to adopt it in their IndexTables.

Do you think we should continue with that plan and then later ask teams to adopt the hover card pattern? Or do you think we should roll it out ourselves throughout IndexTables and then later ask teams to adopt the hover card pattern? For me the question comes down to how many times we'd ask teams to adopt a new pattern, but if the near-term and long-term solutions are spaced out enough, it might be fine.

@alex-page
Copy link
Member Author

I think we should continue with the above plan focusing on one IndexTable. We should ensure that the "link" that opens the tooltip can be used in multiple places across the admin and not be a one-off solution inside the IndexTable component.

@chloerice chloerice linked a pull request Nov 29, 2023 that will close this issue
23 tasks
@lgriffee lgriffee added #gsd:38846 Admin Quality Improvements (Q1 2024) Priority: High Clear visual regression, broken logic, or feature UX will feel broken without labels Jan 12, 2024
@alex-page
Copy link
Member Author

@chloerice @lgriffee lets ship this in shopify/web first then follow up shipping this to Polaris. Shipping this new component to Polaris will require API alignment and we don't need to block shipping this with that alignment right now.

@lgriffee lgriffee added Priority: Urgent Bug blocking merchants, or critical directive and removed #gsd:37811 Roadmap Priority: High Clear visual regression, broken logic, or feature UX will feel broken without labels Jan 22, 2024
@lgriffee lgriffee added the #gsd:35526 Orders Split Cart label Mar 13, 2024
@yurm04 yurm04 changed the title Implement new "Action tooltip" on IndexTable in the admin [EPIC] Implement new HoverCard on Orders index table in the admin Mar 15, 2024
@lgriffee lgriffee removed the #gsd:38846 Admin Quality Improvements (Q1 2024) label Mar 29, 2024
Copy link
Contributor

Hi! We noticed there hasn’t been activity on this issue in a while. After 30 days, it will close automatically.

If it’s still relevant, or you have updates, comment and let us know. And don’t worry, you can always re-open later if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#gsd:35526 Orders Split Cart HoverCard no-issue-activity Priority: Urgent Bug blocking merchants, or critical directive
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants