-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EPIC] Implement new HoverCard
on Orders index table in the admin
#8931
Comments
I have a take on this :) TLDR: The admin needs a global hover card component that takes care of all the heavy lifting. That way, we can add hover cards across the admin in a consistent and scalable way. CodeSandbox that's mentioned in the video global-hover-thingies.mp4 |
I really love that proposal @martenbjork. It's a great example of a solution that's scaleable but also specific to Shopify's admin. I also like that you're looking at the problem with another zoom level. @chloerice @alex-page How do you think this would impact the near-term work? We had talked about shipping the IndexTable tooltip in one place and then asking teams to adopt it in their IndexTables. Do you think we should continue with that plan and then later ask teams to adopt the hover card pattern? Or do you think we should roll it out ourselves throughout IndexTables and then later ask teams to adopt the hover card pattern? For me the question comes down to how many times we'd ask teams to adopt a new pattern, but if the near-term and long-term solutions are spaced out enough, it might be fine. |
I think we should continue with the above plan focusing on one IndexTable. We should ensure that the "link" that opens the tooltip can be used in multiple places across the admin and not be a one-off solution inside the IndexTable component. |
@chloerice @lgriffee lets ship this in |
HoverCard
on Orders index table in the admin
Hi! We noticed there hasn’t been activity on this issue in a while. After 30 days, it will close automatically. If it’s still relevant, or you have updates, comment and let us know. And don’t worry, you can always re-open later if needed. |
=== context ===
Prototype: https://tooltip-prototype.shopifycloud.com/6/action
Figma: https://www.figma.com/file/64twmvaeh0gEXs3pZcueRe/Tooltips?node-id=461-11097&viewport=-417%2C318%2C0.15
Parent issue: https://github.com/Shopify/web/issues/78351.
Raised by: @Shopify/core-operate-workflows-quality-crew
Remaining Tasks
HoverCard
component to@Shopify/web
shared components directory #11743HoverCard
in@Shopify/web
#11744HoverCard
toDestination
column in orders index #11746PositionedOverlay
with originalAlphaHovercard
changes and release independently #11748HoverCard
inshopify/web
#11749OrdersIndexEditableTable
. #11750Pending decisions
preferred-reduce-motion
or no animations at all? #11742Decisions
** Caveat:
If we require a delay for queries, it needs to be consistent across all hover cards. We can't have some that open instantly, some that are delayed
Demo the above and confirm alignment
The text was updated successfully, but these errors were encountered: