Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Epic] Remove conditional se23 logic from polaris-react components #9913

Closed
63 tasks done
Tracked by #9899
sophschneider opened this issue Aug 9, 2023 · 0 comments
Closed
63 tasks done
Tracked by #9899
Assignees

Comments

@sophschneider
Copy link
Contributor

sophschneider commented Aug 9, 2023

  1. Branch off of next
  2. Remove any polarisSummerEditions2023 flag in tsx files. Keep the code with the boolean set to true), remove the hook and hook import.
  3. Make styles inside se23 & blocks in the scss files the mainline styles, delete any styles that were being overridden or are unused. Be careful about specificity and regressions.
  4. Make sure to do steps 2-3 for any subcomponents, you can search within the component folder to make sure all se23 and polarisSummerEditions2023 are removed (be wary of flag renames/aliases)
  5. Tophat on storybook that the styles look like the new language with the flag both on and off. You can also compare with the production storybook , set the breakpoint size, then compare the two tabs

Edit: with the flag turned off there may be some token related difference or imported polaris components that haven't been fixed yet. You can ignore those for now as they should be covered by different projects/issues

  1. In tests, remove any polarisSummerEditions2023 false describe blocks and delete any polarisSummerEditions2023: true in the app mounts (more info here)
    7. Add the component you've cleaned up to the changelog list (https://github.com/Shopify/polaris/blob/next/.changeset/tall-chicken-repeat.md)
  2. Create a PR pointing to the next branch```[tasklist]
  3. Skip Changelog on the PR (see Update tall-chickens-repeat changelog with all the consolidated components #10035 for more info why)

Tasks

  1. #gsd:36579
    sam-b-rose
  2. #gsd:36579
    laurkim
  3. #gsd:36579
    laurkim
  4. #gsd:36579
    laurkim
  5. #gsd:36579
    laurkim
  6. #gsd:36579
    sophschneider
  7. #gsd:36579
    sophschneider
  8. #gsd:36579
    laurkim
  9. #gsd:36579
    sophschneider
  10. #gsd:36579
    laurkim
  11. #gsd:36579
    laurkim
  12. #gsd:36579
    sophschneider
  13. #gsd:36579
    gwyneplaine
  14. #gsd:36579
    jesstelford
  15. #gsd:36579
    gwyneplaine
  16. #gsd:36579
    gwyneplaine
  17. #gsd:36579
    sophschneider
  18. #gsd:36579
    sophschneider
  19. #gsd:36579
    sophschneider
  20. #gsd:36579
    sophschneider
  21. #gsd:36579
    sophschneider
  22. #gsd:36579
    gwyneplaine
  23. #gsd:36579
    sophschneider
  24. #gsd:36579
    sophschneider
  25. #gsd:36579
    sophschneider
  26. #gsd:36579
    gwyneplaine
  27. #gsd:36579
    chloerice gwyneplaine
  28. #gsd:36579
    sophschneider
  29. #gsd:36579
    sophschneider
  30. #gsd:36579
    sophschneider
  31. #gsd:36579
    sophschneider
  32. #gsd:36579
    sophschneider
  33. #gsd:36579
    sophschneider
  34. #gsd:36579
    laurkim
  35. #gsd:36579
    gwyneplaine
  36. #gsd:36579
    laurkim
  37. #gsd:36579
    laurkim
  38. #gsd:36579
    sophschneider
  39. #gsd:36579
    laurkim
  40. #gsd:36579
    laurkim
  41. #gsd:36579
    gwyneplaine
  42. #gsd:36579
    laurkim
  43. #gsd:36579
    sophschneider
  44. #gsd:36579
    laurkim
  45. #gsd:36579
    gwyneplaine
  46. #gsd:36579
    sophschneider
  47. #gsd:36579
    gwyneplaine
  48. #gsd:36579
    sophschneider
  49. #gsd:36579
    jesstelford
  50. #gsd:36579
    gwyneplaine
  51. #gsd:36579
    sophschneider
  52. #gsd:36579
    sophschneider
  53. #gsd:36579
    sophschneider
  54. #gsd:36579
    sophschneider
  55. #gsd:36579
    laurkim
  56. #gsd:36579
    laurkim
  57. #gsd:36579
    laurkim
  58. #gsd:36579
    gwyneplaine
  59. #gsd:36579
    gwyneplaine
  60. #gsd:36579
    sophschneider
  61. #gsd:36579
    laurkim
  62. #gsd:36579
    laurkim
  63. #gsd:36579
    laurkim
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants