Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VerticalStack to BlockStack #9984

Closed
3 tasks done
Tracked by #9914
kyledurand opened this issue Aug 9, 2023 · 0 comments
Closed
3 tasks done
Tracked by #9914

VerticalStack to BlockStack #9984

kyledurand opened this issue Aug 9, 2023 · 0 comments
Assignees
@kyledurand
Labels
#gsd:36573 Polaris API Alignment

Comments

@kyledurand
Copy link
Member

kyledurand commented Aug 9, 2023 •
edited
Loading

  • Rename component throughout codebase
  • Improve documentation
  • Add migrations to migration guide
@kyledurand kyledurand mentioned this issue Aug 9, 2023
Closed
@kyledurand kyledurand self-assigned this Aug 10, 2023
@kyledurand kyledurand added v12 and removed untriaged labels Aug 10, 2023
@kyledurand kyledurand mentioned this issue Aug 11, 2023
Merged
5 tasks
@yurm04 yurm04 mentioned this issue Aug 14, 2023
Closed
@sam-b-rose sam-b-rose added the #gsd:36573 Polaris API Alignment label Aug 15, 2023
kyledurand added a commit that referenced this issue Aug 18, 2023
@kyledurand
Rename vertical stack to block stack (#10032)
cfb3054 
<!--
  ☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
  - Start with a verb, for example: Add, Delete, Improve, Fix…
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

### WHY are these changes introduced?

Part of #9984

Documentation improvement will be done in a follow up

<!--
  Context about the problem that’s being addressed.
-->

### WHAT is this pull request doing?

<!--
  Summary of the changes committed.

Before / after screenshots are appreciated for UI changes. Make sure to
include alt text that describes the screenshot.

If you include an animated gif showing your change, wrapping it in a
details tag is recommended. Gifs usually autoplay, which can cause
accessibility issues for people reviewing your PR:

    <details>
      <summary>Summary of your gif(s)</summary>
      <img src="..." alt="Description of what the gif shows">
    </details>
-->

<!-- ℹ️ Delete the following for small / trivial changes -->

### How to 🎩

🖥 [Local development
instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development)
🗒 [General tophatting
guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md)
📄 [Changelog
guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)

<!--
  Give as much information as needed to experiment with the component
  in the playground.
-->

<details>
<summary>Copy-paste this code in
<code>playground/Playground.tsx</code>:</summary>

```jsx
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}
```

</details>

### 🎩 checklist

- [ ] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [ ] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide
@kyledurand kyledurand mentioned this issue Aug 18, 2023
Merged
kyledurand added a commit that referenced this issue Aug 18, 2023
@kyledurand
Add migration notes for layout components (#10115)
454bdd5 
### WHY are these changes introduced?

Part of #9984 #9985 #9983
@kyledurand kyledurand mentioned this issue Sep 15, 2023
Merged
kyledurand added a commit that referenced this issue Sep 15, 2023
@kyledurand @laurkim
Improve layout component documentation (#10494)
0407409 
### WHY are these changes introduced?

Closes what was remaining for:

Fixes #9983
Fixes #9984
Fixes #9985

---------

Co-authored-by: Lo Kim <lo.kim@shopify.com>
sophschneider pushed a commit that referenced this issue Sep 19, 2023
@kyledurand @sophschneider
Rename vertical stack to block stack (#10032)
1824482 
<!--
  ☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
  - Start with a verb, for example: Add, Delete, Improve, Fix…
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

### WHY are these changes introduced?

Part of #9984

Documentation improvement will be done in a follow up

<!--
  Context about the problem that’s being addressed.
-->

### WHAT is this pull request doing?

<!--
  Summary of the changes committed.

Before / after screenshots are appreciated for UI changes. Make sure to
include alt text that describes the screenshot.

If you include an animated gif showing your change, wrapping it in a
details tag is recommended. Gifs usually autoplay, which can cause
accessibility issues for people reviewing your PR:

    <details>
      <summary>Summary of your gif(s)</summary>
      <img src="..." alt="Description of what the gif shows">
    </details>
-->

<!-- ℹ️ Delete the following for small / trivial changes -->

### How to 🎩

🖥 [Local development
instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development)
🗒 [General tophatting
guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md)
📄 [Changelog
guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)

<!--
  Give as much information as needed to experiment with the component
  in the playground.
-->

<details>
<summary>Copy-paste this code in
<code>playground/Playground.tsx</code>:</summary>

```jsx
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}
```

</details>

### 🎩 checklist

- [ ] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [ ] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide
sophschneider pushed a commit that referenced this issue Sep 19, 2023
@kyledurand @sophschneider
Add migration notes for layout components (#10115)
ea3a499 
### WHY are these changes introduced?

Part of #9984 #9985 #9983
sophschneider pushed a commit that referenced this issue Sep 19, 2023
@kyledurand @laurkim @sophschneider
Improve layout component documentation (#10494)
529e048 
### WHY are these changes introduced?

Closes what was remaining for:

Fixes #9983
Fixes #9984
Fixes #9985

---------

Co-authored-by: Lo Kim <lo.kim@shopify.com>
AnnaCheba pushed a commit to AnnaCheba/polaris that referenced this issue Apr 22, 2024
@kyledurand
Add migration notes for layout components (Shopify#10115)
006c66b 
### WHY are these changes introduced?

Part of Shopify#9984 Shopify#9985 Shopify#9983
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kyledurand kyledurand

Labels
#gsd:36573 Polaris API Alignment
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kyledurand @sam-b-rose