Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DescriptionList] Replace spacing prop with gap #10003

Closed
wants to merge 2 commits into from

Conversation

yurm04
Copy link
Contributor

@yurm04 yurm04 commented Aug 10, 2023

WHY are these changes introduced?

Fixes #10002

Moving to the gap prop for consistency

WHAT is this pull request doing?

  • remove spacing and replace with gap
  • update story to reflect prop change

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

Copy-paste this code in playground/Playground.tsx:
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}

🎩 checklist

@yurm04 yurm04 changed the title [DescriptionList] Replaced spacing prop with gap [DescriptionList] Replac spacing prop with gap Aug 10, 2023
@yurm04 yurm04 changed the title [DescriptionList] Replac spacing prop with gap [DescriptionList] Replace spacing prop with gap Aug 10, 2023
@yurm04 yurm04 linked an issue Aug 10, 2023 that may be closed by this pull request
Copy link
Member

@kyledurand kyledurand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should err on the side of caution for now and deprecate these older props but have them do the same things. Can you leave the spacing prop but deprecate it?

@sam-b-rose
Copy link
Member

Can you leave the spacing prop but deprecate it?

Agreed. Should we add the @deprecated in a PR to main? We should be able to remove spacing in v12

Base automatically changed from next to main October 9, 2023 03:02
Copy link
Contributor

github-actions bot commented Apr 6, 2024

Hi! We noticed there hasn’t been activity on this PR in a while. After 30 days, it will close automatically.

If it’s still relevant, or you have updates, comment and let us know. And don’t worry, you can always re-open later if needed.

@yurm04 yurm04 requested a review from alex-page as a code owner April 19, 2024 21:52
@github-actions github-actions bot added the cla-needed Added by a bot. Contributor needs to sign the CLA Agreement. label Apr 19, 2024
@@ -28,10 +28,15 @@
"warning": "Warning",
"critical": "Critical",
"attention": "Attention",
"new": "New"
"new": "New",
"readOnly": "Read-only",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Localization quality issue found

The following issues may affect the quality of localized translations if they are not addressed:

  • The value Read-only for key Polaris.Badge.STATUS_LABELS.readOnly is very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.

Please look out for other instances of this issue in your PR and fix them as well if possible.

Questions about these messages? Hop in the #help-localization Slack channel.

"new": "New"
"new": "New",
"readOnly": "Read-only",
"enabled": "Enabled"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Localization quality issue found

The following issues may affect the quality of localized translations if they are not addressed:

  • The value Enabled for key Polaris.Badge.STATUS_LABELS.enabled is very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.

Please look out for other instances of this issue in your PR and fix them as well if possible.

Questions about these messages? Hop in the #help-localization Slack channel.

},
"progressAndStatus": "{statusLabel} {progressLabel}"
},
"Banner": {
"dismissButton": "Dismiss notification"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Localization quality issue found

The following issues may affect the quality of localized translations if they are not addressed:

  • The value Dismiss notification for key Polaris.Banner.dismissButton is very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.

Please look out for other instances of this issue in your PR and fix them as well if possible.

Questions about these messages? Hop in the #help-localization Slack channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-needed Added by a bot. Contributor needs to sign the CLA Agreement. no-pr-activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DescriptionList - spacing to gap
3 participants