-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DescriptionList
] Replace spacing
prop with gap
#10003
Conversation
DescriptionList
] Replaced spacing
prop with gap
DescriptionList
] Replac spacing
prop with gap
DescriptionList
] Replac spacing
prop with gap
DescriptionList
] Replace spacing
prop with gap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should err on the side of caution for now and deprecate these older props but have them do the same things. Can you leave the spacing prop but deprecate it?
5d459f8
to
700a72f
Compare
Agreed. Should we add the |
d67fa9a
to
7bbc5ad
Compare
7bbc5ad
to
2a715b9
Compare
9cc8232
to
48ca178
Compare
Hi! We noticed there hasn’t been activity on this PR in a while. After 30 days, it will close automatically. If it’s still relevant, or you have updates, comment and let us know. And don’t worry, you can always re-open later if needed. |
2a715b9
to
6010abd
Compare
polaris-react/locales/en.json
Outdated
@@ -28,10 +28,15 @@ | |||
"warning": "Warning", | |||
"critical": "Critical", | |||
"attention": "Attention", | |||
"new": "New" | |||
"new": "New", | |||
"readOnly": "Read-only", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Localization quality issue found
The following issues may affect the quality of localized translations if they are not addressed:
- The value
Read-only
for keyPolaris.Badge.STATUS_LABELS.readOnly
is very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.
Please look out for other instances of this issue in your PR and fix them as well if possible.
Questions about these messages? Hop in the #help-localization Slack channel.
polaris-react/locales/en.json
Outdated
"new": "New" | ||
"new": "New", | ||
"readOnly": "Read-only", | ||
"enabled": "Enabled" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Localization quality issue found
The following issues may affect the quality of localized translations if they are not addressed:
- The value
Enabled
for keyPolaris.Badge.STATUS_LABELS.enabled
is very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.
Please look out for other instances of this issue in your PR and fix them as well if possible.
Questions about these messages? Hop in the #help-localization Slack channel.
polaris-react/locales/en.json
Outdated
}, | ||
"progressAndStatus": "{statusLabel} {progressLabel}" | ||
}, | ||
"Banner": { | ||
"dismissButton": "Dismiss notification" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Localization quality issue found
The following issues may affect the quality of localized translations if they are not addressed:
- The value
Dismiss notification
for keyPolaris.Banner.dismissButton
is very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.
Please look out for other instances of this issue in your PR and fix them as well if possible.
Questions about these messages? Hop in the #help-localization Slack channel.
WHY are these changes introduced?
Fixes #10002
Moving to the
gap
prop for consistencyWHAT is this pull request doing?
spacing
and replace withgap
How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
Copy-paste this code in
playground/Playground.tsx
:🎩 checklist
README.md
with documentation changes