[KeyboardKey] Consolidate se23 logic and styles #10010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophschneider
requested review from
jesstelford,
sam-b-rose,
gwyneplaine and
laurkim
gwyneplaine
approved these changes
Aug 10, 2023
laurkim
reviewed
Aug 11, 2023
sophschneider
force-pushed
the
sophie/keyboard-key-cleanup
branch
from
f1661d9
to
bceb574
Compare
sophschneider
force-pushed
the
sophie/keyboard-key-cleanup
branch
from
bceb574
to
c66d52a
Compare
sophschneider
added a commit
that referenced
this pull request
Aug 15, 2023
### WHY are these changes introduced? Fixes #9941 ### WHAT is this pull request doing? Consolidates se23 beta styles for `KeyboardKey`. ### How to 🎩 Compare: * This PR's [Storybook](https://5d559397bae39100201eedc1-xmguxoqurw.chromatic.com/?path=/story/all-components-keyboardkey--all) * [Production Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-keyboardkey--all&globals=polarisSummerEditions2023:true)
sam-b-rose
pushed a commit
that referenced
this pull request
Aug 15, 2023
### WHY are these changes introduced? Fixes #9941 ### WHAT is this pull request doing? Consolidates se23 beta styles for `KeyboardKey`. ### How to 🎩 Compare: * This PR's [Storybook](https://5d559397bae39100201eedc1-xmguxoqurw.chromatic.com/?path=/story/all-components-keyboardkey--all) * [Production Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-keyboardkey--all&globals=polarisSummerEditions2023:true)
sam-b-rose
pushed a commit
that referenced
this pull request
Aug 15, 2023
### WHY are these changes introduced? Fixes #9941 ### WHAT is this pull request doing? Consolidates se23 beta styles for `KeyboardKey`. ### How to 🎩 Compare: * This PR's [Storybook](https://5d559397bae39100201eedc1-xmguxoqurw.chromatic.com/?path=/story/all-components-keyboardkey--all) * [Production Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-keyboardkey--all&globals=polarisSummerEditions2023:true)
sam-b-rose
pushed a commit
that referenced
this pull request
Aug 15, 2023
### WHY are these changes introduced? Fixes #9941 ### WHAT is this pull request doing? Consolidates se23 beta styles for `KeyboardKey`. ### How to 🎩 Compare: * This PR's [Storybook](https://5d559397bae39100201eedc1-xmguxoqurw.chromatic.com/?path=/story/all-components-keyboardkey--all) * [Production Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-keyboardkey--all&globals=polarisSummerEditions2023:true)
sam-b-rose
pushed a commit
that referenced
this pull request
Aug 15, 2023
### WHY are these changes introduced? Fixes #9941 ### WHAT is this pull request doing? Consolidates se23 beta styles for `KeyboardKey`. ### How to 🎩 Compare: * This PR's [Storybook](https://5d559397bae39100201eedc1-xmguxoqurw.chromatic.com/?path=/story/all-components-keyboardkey--all) * [Production Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-keyboardkey--all&globals=polarisSummerEditions2023:true)
sam-b-rose
pushed a commit
that referenced
this pull request
Aug 15, 2023
### WHY are these changes introduced? Fixes #9941 ### WHAT is this pull request doing? Consolidates se23 beta styles for `KeyboardKey`. ### How to 🎩 Compare: * This PR's [Storybook](https://5d559397bae39100201eedc1-xmguxoqurw.chromatic.com/?path=/story/all-components-keyboardkey--all) * [Production Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-keyboardkey--all&globals=polarisSummerEditions2023:true)
kyledurand
pushed a commit
that referenced
this pull request
Aug 16, 2023
### WHY are these changes introduced? Fixes #9941 ### WHAT is this pull request doing? Consolidates se23 beta styles for `KeyboardKey`. ### How to 🎩 Compare: * This PR's [Storybook](https://5d559397bae39100201eedc1-xmguxoqurw.chromatic.com/?path=/story/all-components-keyboardkey--all) * [Production Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-keyboardkey--all&globals=polarisSummerEditions2023:true)
kyledurand
pushed a commit
that referenced
this pull request
Aug 17, 2023
### WHY are these changes introduced? Fixes #9941 ### WHAT is this pull request doing? Consolidates se23 beta styles for `KeyboardKey`. ### How to 🎩 Compare: * This PR's [Storybook](https://5d559397bae39100201eedc1-xmguxoqurw.chromatic.com/?path=/story/all-components-keyboardkey--all) * [Production Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-keyboardkey--all&globals=polarisSummerEditions2023:true)
sophschneider
added a commit
that referenced
this pull request
Sep 19, 2023
### WHY are these changes introduced? Fixes #9941 ### WHAT is this pull request doing? Consolidates se23 beta styles for `KeyboardKey`. ### How to 🎩 Compare: * This PR's [Storybook](https://5d559397bae39100201eedc1-xmguxoqurw.chromatic.com/?path=/story/all-components-keyboardkey--all) * [Production Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-keyboardkey--all&globals=polarisSummerEditions2023:true)
Merged
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
### WHY are these changes introduced? Fixes Shopify#9941 ### WHAT is this pull request doing? Consolidates se23 beta styles for `KeyboardKey`. ### How to 🎩 Compare: * This PR's [Storybook](https://5d559397bae39100201eedc1-xmguxoqurw.chromatic.com/?path=/story/all-components-keyboardkey--all) * [Production Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-keyboardkey--all&globals=polarisSummerEditions2023:true)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #9941
WHAT is this pull request doing?
Consolidates se23 beta styles for
KeyboardKey.How to 🎩
Compare: