Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sophie/chromatic test #10037

Closed
wants to merge 19 commits into from
Closed

Sophie/chromatic test #10037

wants to merge 19 commits into from

Conversation

sophschneider
Copy link
Contributor

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

Copy-paste this code in playground/Playground.tsx: 
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}

🎩 checklist

sam-b-rose and others added 14 commits August 8, 2023 13:45
@sam-b-rose
Update release workflow
b087399
@sam-b-rose
Enable the Summer Editions 2023 feature flag by default (#9821)
3f88152
@sam-b-rose
Only release beta for tokens, icons, and React packages
c1d1520
@github-actions @sam-b-rose
Version Packages (beta)
3ef89a2
@sam-b-rose
Remove se23 styles and code from Avatar (#9906)
d0038b4 
### WHY are these changes introduced?

Related to #9899 

<!--
  Context about the problem that’s being addressed.
-->

### WHAT is this pull request doing?

Removes beta flag logic and merge override styles for Avatar component.
@laurkim
[AccountConnection] Remove se23 conditional logic (#9908)
8259ea7 
### WHY are these changes introduced?

Resolves #9909.

### WHAT is this pull request doing?

Removes se23 beta conditional logic for `AccountConnection`.

### How to 🎩


[Storybook](https://5d559397bae39100201eedc1-ljctfsyeaf.chromatic.com/?path=/story/all-components-accountconnection--all)

🖥 [Local development
instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development)
🗒 [General tophatting
guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md)
📄 [Changelog
guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)

### 🎩 checklist

- [x] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [x] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide
@laurkim
[ActionList] Consolidate se23 logic and styles (#9911)
053dba2 
### WHY are these changes introduced?

Resolves #9910 .

### WHAT is this pull request doing?

Removes se23 beta conditional logic for `ActionList`.
Consolidates se23 beta styles for `ActionList`.

### How to 🎩


[Storybook](https://5d559397bae39100201eedc1-xfazrnicvb.chromatic.com/?path=/story/all-components-actionlist--all)

🖥 [Local development
instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development)
🗒 [General tophatting
guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md)
📄 [Changelog
guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)

### 🎩 checklist

- [x] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [x] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide
@laurkim
Merge branch 'main' into next
97d9ee5
@laurkim
[ActionMenu] Consolidate se23 logic and styles (#9999)
ae12da9 
### WHY are these changes introduced?

Resolves #9916.

### WHAT is this pull request doing?

Removes se23 beta conditional logic for `ActionMenu`.
Consolidates se23 beta styles for `ActionMenu`.

### How to 🎩


[Storybook](https://5d559397bae39100201eedc1-okamtncmqt.chromatic.com/?path=/story/all-components-page--default)
<img width="1025" alt="10-20-em6hu-q856q"
src="https://github.com/Shopify/polaris/assets/26749317/6075dd5a-ff6e-4b86-aec4-fa935600e841">
> Note: There is no storybook specifically for ActionMenu but it is used
in the Page Header subcomponent.

🖥 [Local development
instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development)
🗒 [General tophatting
guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md)
📄 [Changelog
guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)

### 🎩 checklist

- [x] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [x] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide
@gwyneplaine
[Text] Remove se23 conditional logic (#9992)
cb3486a 
<!--
  ☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
  - Start with a verb, for example: Add, Delete, Improve, Fix…
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

### WHY are these changes introduced?

Fixes #9971

<!--
  Context about the problem that’s being addressed.
-->

### WHAT is this pull request doing?

<!--
  Summary of the changes committed.

Before / after screenshots are appreciated for UI changes. Make sure to
include alt text that describes the screenshot.

If you include an animated gif showing your change, wrapping it in a
details tag is recommended. Gifs usually autoplay, which can cause
accessibility issues for people reviewing your PR:

    <details>
      <summary>Summary of your gif(s)</summary>
      <img src="..." alt="Description of what the gif shows">
    </details>
-->

<!-- ℹ️ Delete the following for small / trivial changes -->

### How to 🎩

🖥 [Local development
instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development)
🗒 [General tophatting
guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md)
📄 [Changelog
guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)

<!--
  Give as much information as needed to experiment with the component
  in the playground.
-->

<details>
<summary>Copy-paste this code in
<code>playground/Playground.tsx</code>:</summary>

```jsx
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}
```

</details>

### 🎩 checklist

- [ ] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [ ] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide
@laurkim
[Autocomplete] Consolidate se23 styles (#10007)
de9bae3 
### WHY are these changes introduced?

Resolves #9917 .

### WHAT is this pull request doing?

Consolidates se23 beta styles for `Autocomplete`.

### How to 🎩


[Storybook](https://5d559397bae39100201eedc1-ztmfqwvbxv.chromatic.com/?path=/story/all-components-autocomplete--with-action)

🖥 [Local development
instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development)
🗒 [General tophatting
guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md)
📄 [Changelog
guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)

### 🎩 checklist

- [x] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [x] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide
@laurkim
[Breadcrumbs] Consolidate se23 logic and styles (#10030)
efc5305 
### WHY are these changes introduced?

Resolves #9920.

### WHAT is this pull request doing?

Consolidates se23 beta logic styles for `Breadcrumbs`.

### How to 🎩


[Storybook](https://5d559397bae39100201eedc1-eghgntjqfq.chromatic.com/?path=/story/all-components-page--with-back-action-on-action)
[Prod
Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-page--with-back-action-on-action&globals=polarisSummerEditions2023:true)

🖥 [Local development
instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development)
🗒 [General tophatting
guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md)
📄 [Changelog
guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)

### 🎩 checklist

- [x] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [x] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide
@sophschneider
[KeyboardKey] Consolidate se23 logic and styles (#10010)
59e9058 
### WHY are these changes introduced?

Fixes #9941

### WHAT is this pull request doing?

Consolidates se23 beta styles for `KeyboardKey`.

### How to 🎩

Compare:

* This PR's
[Storybook](https://5d559397bae39100201eedc1-xmguxoqurw.chromatic.com/?path=/story/all-components-keyboardkey--all)
* [Production
Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-keyboardkey--all&globals=polarisSummerEditions2023:true)
@sophschneider
[EmptyState] Consolidate se23 logic and styles (#10009)
d901d92 
### WHY are these changes introduced?

Fixes #9933

### WHAT is this pull request doing?

Consolidates se23 beta styles for `EmptyState`.

### How to 🎩

Compare and make sure they are the same:

* This PR's
[Storybook](https://5d559397bae39100201eedc1-xyztablchw.chromatic.com/?path=/story/all-components-emptystate--default)
* [Production
Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-emptystate--default&globals=polarisSummerEditions2023:true)
@sophschneider sophschneider changed the base branch from main to next August 11, 2023 16:56
@sophschneider sophschneider added the 🤖Skip Changelog Causes CI to ignore changelog update check. label Aug 11, 2023
sophschneider and others added 5 commits August 11, 2023 12:58
@sophschneider
[BulkActions] Consolidate se23 logic and styles (#10008)
4004305 
### WHY are these changes introduced?

Fixes #9921

### WHAT is this pull request doing?

Consolidates se23 beta styles for `BulkActions`.

### How to 🎩

Compare the bulk actions shadow bevel (make sure they are the same):

* This PR's
[Storybook](https://5d559397bae39100201eedc1-vxezcfotko.chromatic.com/?path=/story/all-components-indextable--default)
* [Production
Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-indextable--default&globals=polarisSummerEditions2023:true)
@sophschneider
[Badge] Consolidate se23 logic and styles (#10004)
f2210b3 
### WHY are these changes introduced?

Fixes #9918

### WHAT is this pull request doing?

Removing flagged se23 code from badge

### How to 🎩

Compare and make sure they are the same:

* This PR's
[Storybook](https://5d559397bae39100201eedc1-fqebvmxjcw.chromatic.com/?path=/story/all-components-badge--all&globals=polarisSummerEditions2023:false)
* [Production
Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-badge--all&globals=polarisSummerEditions2023:true)
@sophschneider
Preload inter on Storybook
781e838
@sophschneider
Run a11y vrt CI on storybook changes
a33b39a
@sophschneider
Chromatic test
8896c14
@sophschneider sophschneider changed the base branch from next to sophie/storybook-inter-font-preload August 14, 2023 20:47
Base automatically changed from sophie/storybook-inter-font-preload to next August 15, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🤖Skip Changelog Causes CI to ignore changelog update check.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sophschneider @sam-b-rose @laurkim @gwyneplaine