[CheckableButton] Make se23 styles the default #10054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesstelford
commented
Aug 15, 2023
| margin-left: calc(var(--p-space-5) - var(--p-border-width-2)); | ||
|
|
||
| #{$se23} & { | ||
| margin-left: calc(var(--p-space-3) + var(--p-space-025)); |
There was a problem hiding this comment.
Changed this to a gap declaration on the containing flex element.
gwyneplaine
approved these changes
Aug 15, 2023
sophschneider
approved these changes
Aug 15, 2023
sam-b-rose
force-pushed
the
next
branch
4 times, most recently
from
5d459f8
to
700a72f
Compare
jesstelford
force-pushed
the
checkable-button-se23-cleanup
branch
from
28656c1
to
dd585a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes #9926
<CheckableButton>is used in the "Select All" section of ResourceList and IndexTable.NOTE: There's some existing layout jank in
<ResourceList>that I've fixed separately in #10056