[ButtonGroup] Consolidate se23 styles #10058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurkim
requested review from
jesstelford,
sam-b-rose,
gwyneplaine and
sophschneider
sophschneider
approved these changes
Aug 15, 2023
laurkim
force-pushed
the
lo/rm-uplift-button-group
branch
2 times, most recently
from
e2ca857
to
7df8453
Compare
|
Moving this back to draft, some of the latest changes off next have affected button styling |
sam-b-rose
force-pushed
the
next
branch
4 times, most recently
from
5d459f8
to
700a72f
Compare
laurkim
force-pushed
the
lo/rm-uplift-button-group
branch
from
7df8453
to
2716a50
Compare
kyledurand
pushed a commit
that referenced
this pull request
Aug 16, 2023
### WHY are these changes introduced? Resolves #9923 . ### WHAT is this pull request doing? Consolidates se23 beta styles for `ButtonGroup`. ### How to 🎩 [Storybook](https://5d559397bae39100201eedc1-rxozizhawo.chromatic.com/?path=/story/all-components-buttongroup--default) [Prod Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-buttongroup--default&globals=polarisSummerEditions2023:true) 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
kyledurand
pushed a commit
that referenced
this pull request
Aug 17, 2023
### WHY are these changes introduced? Resolves #9923 . ### WHAT is this pull request doing? Consolidates se23 beta styles for `ButtonGroup`. ### How to 🎩 [Storybook](https://5d559397bae39100201eedc1-rxozizhawo.chromatic.com/?path=/story/all-components-buttongroup--default) [Prod Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-buttongroup--default&globals=polarisSummerEditions2023:true) 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
sophschneider
pushed a commit
that referenced
this pull request
Sep 19, 2023
Resolves #9923 . Consolidates se23 beta styles for `ButtonGroup`. [Storybook](https://5d559397bae39100201eedc1-rxozizhawo.chromatic.com/?path=/story/all-components-buttongroup--default) [Prod Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-buttongroup--default&globals=polarisSummerEditions2023:true) 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Merged
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
### WHY are these changes introduced? Resolves Shopify#9923 . ### WHAT is this pull request doing? Consolidates se23 beta styles for `ButtonGroup`. ### How to 🎩 [Storybook](https://5d559397bae39100201eedc1-rxozizhawo.chromatic.com/?path=/story/all-components-buttongroup--default) [Prod Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-buttongroup--default&globals=polarisSummerEditions2023:true) 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Resolves #9923 .
WHAT is this pull request doing?
Consolidates se23 beta styles for
ButtonGroup.How to 🎩
Storybook
Prod Storybook
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
🎩 checklist
README.mdwith documentation changes