Font migration #10630
Merged
Font migration #10630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aveline
force-pushed
the
font-migration
branch
3 times, most recently
from
6c1c342
to
cd3ee52
Compare
|
/snapit |
|
🫰✨ Thanks @aveline! Your snapshot has been published to npm. Test the snapshot by updating your yarn add @shopify/polaris@0.0.0-snapshot-release-20230922185935 |
lgriffee
approved these changes
Sep 22, 2023
lgriffee
approved these changes
Sep 22, 2023
sophschneider
approved these changes
Sep 26, 2023
aveline
force-pushed
the
font-migration
branch
from
e0832bd
to
674a1cc
Compare
Merged
aaronccasanova
pushed a commit
that referenced
this pull request
Sep 26, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris@11.23.0 ### Minor Changes - [#10630](#10630) [`3987c0e48`](3987c0e) Thanks [@aveline](https://github.com/aveline)! - Migrated font custom properties - [#10632](#10632) [`4ab148ee6`](4ab148e) Thanks [@fabiormoura](https://github.com/fabiormoura)! - Added a `warning` `status` to the `IndexTable.Row` ### Patch Changes - Updated dependencies \[[`f23af6fdd`](f23af6f)]: - @shopify/polaris-tokens@7.12.1 ## @shopify/polaris-migrator@0.22.8 ### Patch Changes - Updated dependencies \[[`f23af6fdd`](f23af6f)]: - @shopify/polaris-tokens@7.12.1 - @shopify/stylelint-polaris@14.1.1 ## @shopify/polaris-tokens@7.12.1 ### Patch Changes - [#10671](#10671) [`f23af6fdd`](f23af6f) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Updated the `toValues` token utility to resolve token name references in the `theme` to their unit values ## @shopify/stylelint-polaris@14.1.1 ### Patch Changes - Updated dependencies \[[`f23af6fdd`](f23af6f)]: - @shopify/polaris-tokens@7.12.1 ## polaris.shopify.com@0.58.2 ### Patch Changes - Updated dependencies \[[`3987c0e48`](3987c0e), [`4ab148ee6`](4ab148e), [`f23af6fdd`](f23af6f)]: - @shopify/polaris@11.23.0 - @shopify/polaris-tokens@7.12.1 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
### WHY are these changes introduced? Fixes Shopify#10498 ### WHAT is this pull request doing? Handles automatic and manual migrations for font tokens Ran the following migration ``` npx @shopify/polaris-migrator@0.0.0-snapshot-release-20230921230145 \ v12-styles-replace-custom-property-font \ 'src/**/*.scss' ``` ~Used the following regex to search for manually migrations~ Omitting manual migrations at this point ``` (?:--p-font-size-70-experimental|--p-font-size-80-experimental|--p-font-size-100|--p-font-size-700|--p-font-line-height-075-experimental|--p-font-line-height-1|--p-font-line-height-2|--p-font-line-height-3|--p-font-line-height-4|--p-font-line-height-5|--p-font-line-height-6|--p-font-line-height-7)(?![\w-]) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #10498
WHAT is this pull request doing?
Handles automatic and manual migrations for font tokens
Ran the following migration
Used the following regex to search for manually migrationsOmitting manual migrations at this point