[polaris.shopify.com] Update Colors content #10657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurm04
suggested changes
Sep 25, 2023
There was a problem hiding this comment.
Concerned with the color palette not utilizing react to make it interactive. Can we quickly rewrite it in react so that we're not reaching into the dom document? Not sure if related or a side effect of the current implementation but there is an error when trying to interact with the color palette. If this is too big a lift we should roll back this change to the old color palette and punt to after v12 launch
| @@ -26,4 +26,9 @@ | |||
| 1px 0px 0px 0px color(display-p3 0.8902 0.8902 0.8902) inset, | |||
| -1px 0px 0px 0px color(display-p3 0.8902 0.8902 0.8902) inset, | |||
| 0px -1px 0px 0px color(display-p3 0.8314 0.8314 0.8314) inset; | |||
|
|
|||
| .Card { | |||
There was a problem hiding this comment.
is this getting used anywhere?
| @@ -1,5 +1,7 @@ | |||
| import * as colorsObj from '../../../../../../polaris-tokens/dist/esm/src/colors.mjs'; | |||
| import {Grid} from '@shopify/polaris'; | |||
There was a problem hiding this comment.
seeing this error when clicking on the color palette
polaris.shopify.com/src/components/Markdown/components/Colors/index.tsx
Outdated
Show resolved
Hide resolved
sophschneider
force-pushed
the
next
branch
2 times, most recently
from
9cc8232
to
48ca178
Compare
kyledurand
force-pushed
the
tjonx/add-color-content-etc
branch
from
084aca0
to
bd0a588
Compare
kyledurand
approved these changes
Oct 3, 2023
sam-b-rose
force-pushed
the
tjonx/add-color-content-etc
branch
from
bd0a588
to
303b7b1
Compare
sam-b-rose
force-pushed
the
tjonx/add-color-content-etc
branch
from
3b369f9
to
4be49ed
Compare
mrcthms
pushed a commit
that referenced
this pull request
Oct 12, 2023
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Closes #10020 <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? - Updates `Color` and moves it to an `Overview` page - Adds `Palettes and roles` subpage - Adds `Using color` subpage - Adds images and layout for all three pages - Updates the `Colors` component in `mdx` to become an interactive color contrast checker. <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide --------- Co-authored-by: kyledurand <kyle.durand@shopify.com> Co-authored-by: Sam Rose <11774595+sam-b-rose@users.noreply.github.com>
mrcthms
pushed a commit
that referenced
this pull request
Oct 12, 2023
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Closes #10020 <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? - Updates `Color` and moves it to an `Overview` page - Adds `Palettes and roles` subpage - Adds `Using color` subpage - Adds images and layout for all three pages - Updates the `Colors` component in `mdx` to become an interactive color contrast checker. <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide --------- Co-authored-by: kyledurand <kyle.durand@shopify.com> Co-authored-by: Sam Rose <11774595+sam-b-rose@users.noreply.github.com>
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Closes Shopify#10020 <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? - Updates `Color` and moves it to an `Overview` page - Adds `Palettes and roles` subpage - Adds `Using color` subpage - Adds images and layout for all three pages - Updates the `Colors` component in `mdx` to become an interactive color contrast checker. <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide --------- Co-authored-by: kyledurand <kyle.durand@shopify.com> Co-authored-by: Sam Rose <11774595+sam-b-rose@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Closes #10020
WHAT is this pull request doing?
Colorand moves it to anOverviewpagePalettes and rolessubpageUsing colorsubpageColorscomponent inmdxto become an interactive color contrast checker.How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
Copy-paste this code in
playground/Playground.tsx:🎩 checklist
README.mdwith documentation changes