Lower z-index of Filters container to be below Card shadow bevel #11462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/snapit |
|
🫰✨ Thanks @sophschneider! Your snapshot has been published to npm. Test the snapshot by updating your yarn add @shopify/polaris@0.0.0-snapshot-release-20240117175124 |
sophschneider
force-pushed
the
sophie/filters-container-z
branch
from
001b572
to
572d3eb
Compare
sophschneider
requested review from
lgriffee,
aaronccasanova,
yurm04,
davidlng and
chloerice
davidlng
approved these changes
Jan 17, 2024
Co-authored-by: Laura Griffee <laura@mailzone.com>
sophschneider
changed the title
Merged
6 tasks
chloerice
pushed a commit
that referenced
this pull request
Jan 26, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-icons@8.1.0 ### Minor Changes - [#11478](#11478) [`b786bb93c`](b786bb9) Thanks [@Rusty-UX](https://github.com/Rusty-UX)! - Added DatabaseConnectIcon ## @shopify/polaris@12.11.0 ### Minor Changes - [#11474](#11474) [`26b3afb3d`](26b3afb) Thanks [@mrcthms](https://github.com/mrcthms)! - [BulkActions and SelectAllActions] Ensure backwards compatibilility after prop reorganisation between components - [#11497](#11497) [`d50cc6d91`](d50cc6d) Thanks [@mrcthms](https://github.com/mrcthms)! - Improved test reliability for non-rolled up actions in `ActionMenu` - [#10981](#10981) [`2dcc73f1a`](2dcc73f) Thanks [@mrcthms](https://github.com/mrcthms)! - Updated the sticky behaviour of BulkActions, SelectAllActions, and Pagination for our tables and lists - [#11441](#11441) [`74174b6c1`](74174b6) Thanks [@mrcthms](https://github.com/mrcthms)! - Improved the logic of action rollup and calculation of available space in `ActionMenu` and `Tabs` - [#11491](#11491) [`ac004fc97`](ac004fc) Thanks [@lgriffee](https://github.com/lgriffee)! - [`Button`] Remove underline from `monochromePlain` default state - [#11486](#11486) [`02a6d9b18`](02a6d9b) Thanks [@translation-platform](https://github.com/apps/translation-platform)! - Updated translations for SearchField suffix within IndexFilters - [#11344](#11344) [`c9abd3c0c`](c9abd3c) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Added Polaris Tokens for Mobile typography - [#11412](#11412) [`f1b44ab57`](f1b44ab) Thanks [@mrcthms](https://github.com/mrcthms)! - [TextField] Updated the TextField with new `autoSize` and `loading` props - [#11431](#11431) [`f9b9fa4e8`](f9b9fa4) Thanks [@lone-star](https://github.com/lone-star)! - Added `tone`, `icon`, and `onClick` props to `Toast` ### Patch Changes - [#11464](#11464) [`2ee7dbd30`](2ee7dbd) Thanks [@sam-b-rose](https://github.com/sam-b-rose)! - Updated `Button` shadow tokens and replaced hardcoded box-shadow values - [#11504](#11504) [`1910c6975`](1910c69) Thanks [@mrcthms](https://github.com/mrcthms)! - Updated Page Header to only ensure no wrapping of the title when the title is relatively short - [#11473](#11473) [`6579537e4`](6579537) Thanks [@sam-b-rose](https://github.com/sam-b-rose)! - Fixed focus ring size for plain and plain monochrome Button variants - [#11487](#11487) [`4aabf7c1a`](4aabf7c) Thanks [@yurm04](https://github.com/yurm04)! - [Modal] Fixed Footer position to bottom of container - [#11466](#11466) [`1953b6935`](1953b69) Thanks [@mrcthms](https://github.com/mrcthms)! - [TextField] Fixed positional issue of loading indicator when no clear button is present - [#11462](#11462) [`2febd60f1`](2febd60) Thanks [@sophschneider](https://github.com/sophschneider)! - Lowered the z-index of `Filter`s container to be below `Card` shadow bevel - [#11467](#11467) [`75cbcd70b`](75cbcd7) Thanks [@kyledurand](https://github.com/kyledurand)! - Increased contrast on Tooltip underline - [#11482](#11482) [`59371946c`](5937194) Thanks [@translation-platform](https://github.com/apps/translation-platform)! - [SearchField] Updated translation - Updated dependencies \[[`2ee7dbd30`](2ee7dbd), [`c9abd3c0c`](c9abd3c), [`b786bb93c`](b786bb9)]: - @shopify/polaris-tokens@8.6.0 - @shopify/polaris-icons@8.1.0 ## @shopify/polaris-tokens@8.6.0 ### Minor Changes - [#11344](#11344) [`c9abd3c0c`](c9abd3c) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Added Polaris Tokens for Mobile typography ### Patch Changes - [#11464](#11464) [`2ee7dbd30`](2ee7dbd) Thanks [@sam-b-rose](https://github.com/sam-b-rose)! - Updated `Button` shadow tokens and replaced hardcoded box-shadow values ## @shopify/stylelint-polaris@15.1.0 ### Minor Changes - [#11344](#11344) [`c9abd3c0c`](c9abd3c) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Updated `typography` `declaration-property-value-disallowed-list` to support Polaris Tokens `text` variants ### Patch Changes - Updated dependencies \[[`2ee7dbd30`](2ee7dbd), [`c9abd3c0c`](c9abd3c)]: - @shopify/polaris-tokens@8.6.0 ## @shopify/polaris-migrator@0.27.1 ### Patch Changes - Updated dependencies \[[`c9abd3c0c`](c9abd3c), [`2ee7dbd30`](2ee7dbd), [`c9abd3c0c`](c9abd3c)]: - @shopify/stylelint-polaris@15.1.0 - @shopify/polaris-tokens@8.6.0 ## polaris.shopify.com@0.62.0 ### Minor Changes - [#11506](#11506) [`c19b0f638`](c19b0f6) Thanks [@lgriffee](https://github.com/lgriffee)! - Added ability to mark prop values as deprecated ### Patch Changes - [#11457](#11457) [`966d1901e`](966d190) Thanks [@sam-b-rose](https://github.com/sam-b-rose)! - Added fallback to no active icon on Icons page when not a valid icon name is used in the search param - [#11466](#11466) [`1953b6935`](1953b69) Thanks [@mrcthms](https://github.com/mrcthms)! - [TextField] Fixed positional issue of loading indicator when no clear button is present - [#11461](#11461) [`d26df7eb0`](d26df7e) Thanks [@sam-b-rose](https://github.com/sam-b-rose)! - Added deprecation warning to old icon names informing users to use the new icon name - [#11467](#11467) [`75cbcd70b`](75cbcd7) Thanks [@kyledurand](https://github.com/kyledurand)! - Increased contrast on Tooltip underline - Updated dependencies \[[`26b3afb3d`](26b3afb), [`2ee7dbd30`](2ee7dbd), [`1910c6975`](1910c69), [`d50cc6d91`](d50cc6d), [`6579537e4`](6579537), [`2dcc73f1a`](2dcc73f), [`74174b6c1`](74174b6), [`4aabf7c1a`](4aabf7c), [`ac004fc97`](ac004fc), [`1953b6935`](1953b69), [`02a6d9b18`](02a6d9b), [`c9abd3c0c`](c9abd3c), [`2febd60f1`](2febd60), [`b786bb93c`](b786bb9), [`75cbcd70b`](75cbcd7), [`f1b44ab57`](f1b44ab), [`f9b9fa4e8`](f9b9fa4), [`59371946c`](5937194)]: - @shopify/polaris@12.11.0 - @shopify/polaris-tokens@8.6.0 - @shopify/polaris-icons@8.1.0 ## polaris-for-vscode@0.9.4 ### Patch Changes - Updated dependencies \[[`2ee7dbd30`](2ee7dbd), [`c9abd3c0c`](c9abd3c)]: - @shopify/polaris-tokens@8.6.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
…pify#11462) ### WHY are these changes introduced? Part of Shopify/polaris-internal#1343 ### WHAT is this pull request doing? Lower `Filter` container z-index (currently `100`) to be below `Card`'s shadow bevel z-index which is `32`. This is a similar bug/fix as [this issue](Shopify#11411). |Before|After| |-|-| |<img width="503" alt="Screenshot 2024-01-17 at 3 53 30 PM" src="https://github.com/Shopify/polaris/assets/20652326/88edab7c-aed8-44b8-9f5c-b9bd319405dc">|<img width="382" alt="Screenshot 2024-01-17 at 4 48 45 PM" src="https://github.com/Shopify/polaris/assets/20652326/7dc33fc8-333b-4e1d-afa7-f3efed5ad7a1">| ### How to 🎩 https://admin.web.web-kkgf.sophie-schneider.us.spin.dev/store/shop1/orders 1. Press search button on index table or verify shadow bevel is on the filter search bar in this story https://5d559397bae39100201eedc1-vszwcambil.chromatic.com/?path=/story/all-components-indexfilters--with-filtering-by-default (vs.[ on prod](https://storybook.polaris.shopify.com/?path=/story/all-components-indexfilters--with-filtering-by-default)) ### 🎩 checklist - [x] Tested a [snapshot](https://github.com/Shopify/polaris/blob/main/documentation/Releasing.md#-snapshot-releases) - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) --------- Co-authored-by: Laura Griffee <laura@mailzone.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Part of https://github.com/Shopify/polaris-internal/issues/1343
Part of https://github.com/Shopify/polaris-internal/issues/1354
WHAT is this pull request doing?
Lower
Filtercontainer z-index (currently100) to be belowCard's shadow bevel z-index which is32. This is a similar bug/fix as this issue.How to 🎩
https://admin.web.web-kkgf.sophie-schneider.us.spin.dev/store/shop1/orders
or
verify shadow bevel is on the filter search bar in this story https://5d559397bae39100201eedc1-vszwcambil.chromatic.com/?path=/story/all-components-indexfilters--with-filtering-by-default (vs. on prod)
🎩 checklist