Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lower z-index of Filters container to be below Card shadow bevel #11462

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Lower z-index of Filters container to be below Card shadow bevel #11462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
572d3eb
Raise z-index of Filters container to be below Card shadow bevel
sophschneider Jan 17, 2024
ea0ad37
Update .changeset/selfish-ads-reflect.md
sophschneider Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/selfish-ads-reflect.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/polaris': patch
---

Lowered the z-index of `Filter`s container to be below `Card` shadow bevel
3 changes: 2 additions & 1 deletion polaris-react/src/components/Filters/Filters.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@

.Container {
position: relative;
z-index: var(--p-z-index-1);
// stylelint-disable-next-line -- z-index below Card shadow bevel (32)
z-index: 30;
border-bottom: var(--p-border-width-025) solid var(--p-color-border-secondary);
border-top-left-radius: var(--p-border-radius-200);
border-top-right-radius: var(--p-border-radius-200);
Expand Down
Loading