Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Icon] Add dynamic source connect icon #11469

Closed
wants to merge 3 commits into from
Closed

Conversation

Rusty-UX
Copy link
Contributor

datasource-connect

Adds support for dynamic source connect icon

  • This icon is used when a dynamic source is connected, and powering part of the experience: either data, or functionality.
  • This icon is used in context of Shopify Admin, and Shopify Mobile for merchandising flows.

WHY are these changes introduced?

  • Provides additional specificity in how we communicate dynamic source connections in admin and online store

WHAT is this pull request doing?

  • Adds support for dynamic source connect icon
  • Updates description for add dynamic source icon

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

🎩 checklist

@Rusty-UX Rusty-UX self-assigned this Jan 18, 2024
@kyledurand
Copy link
Member

@Rusty-UX I think tests are failing because this icon has some unwanted svg attribute bloat.

Can you try:

  1. cd polaris-icons
  2. yarn optimize
  3. Then push up the changes?

If that's still failing let me know and I'll take another look

@Rusty-UX Rusty-UX closed this Jan 19, 2024
@Rusty-UX Rusty-UX deleted the connect-datasource-icon branch January 19, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants