Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Page] Align back action button icon with title on small screens #11479

Closed
wants to merge 1 commit into from
Closed

[Page] Align back action button icon with title on small screens #11479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/hot-news-mix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/polaris': minor
---

[`Page`] Aligned `Page` back action button icon with title on small screens
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[`Page`] Aligned `Page` back action button icon with title on small screens
Fixed `Page` `backAction` icon misalignment with `title` on small screens

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to convert this issue back into a draft while possible options are explored!

5 changes: 5 additions & 0 deletions polaris-react/src/components/Page/components/Header/Header.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@ $action-menu-rollup-computed-width: 40px;

.BreadcrumbWrapper {
grid-area: breadcrumbs;
margin-left: calc(-1 * var(--p-space-200));

@media (--p-breakpoints-md-up) {
margin-left: 0;
}

a,
button {
Expand Down
Loading