[PageSkeleton] Add subtitle prop #11513

ryanrphillips · 2024-01-27T02:55:22Z

WHY are these changes introduced?

If a page has static content for Title and Subtitle and displays a component while the page is loading, the user will experience a jump when the component renders. This PR resolves that issue by adding subtitle support to the component.

WHAT is this pull request doing?

This PR adds a new subtitle prop to the PageSkeleton component.

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

🎩 checklist

Tested a snapshot
Tested on mobile
Tested on multiple browsers
Tested for accessibility
Updated the component's README.md with documentation changes
Tophatted documentation changes in the style guide

Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.21.3 to 7.23.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/babel/babel/releases"><code>@babel/traverse</code>'s releases</a>.</em></p> <blockquote> <h2>v7.23.2 (2023-10-11)</h2> <p><strong>NOTE</strong>: This release also re-publishes <code>@babel/core</code>, even if it does not appear in the linked release commit.</p> <p>Thanks <a href="https://github.com/jimmydief"><code>@jimmydief</code></a> for your first PR!</p> <h4>:bug: Bug Fix</h4> <ul> <li><code>babel-traverse</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/16033">#16033</a> Only evaluate own String/Number/Math methods (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-preset-typescript</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/16022">#16022</a> Rewrite <code>.tsx</code> extension when using <code>rewriteImportExtensions</code> (<a href="https://github.com/jimmydief"><code>@jimmydief</code></a>)</li> </ul> </li> <li><code>babel-helpers</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/16017">#16017</a> Fix: fallback to typeof when toString is applied to incompatible object (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> <li><code>babel-helpers</code>, <code>babel-plugin-transform-modules-commonjs</code>, <code>babel-runtime-corejs2</code>, <code>babel-runtime-corejs3</code>, <code>babel-runtime</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/16025">#16025</a> Avoid override mistake in namespace imports (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> </ul> <h4>Committers: 5</h4> <ul> <li>Babel Bot (<a href="https://github.com/babel-bot"><code>@babel-bot</code></a>)</li> <li>Huáng Jùnliàng (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> <li>James Diefenderfer (<a href="https://github.com/jimmydief"><code>@jimmydief</code></a>)</li> <li>Nicolò Ribaudo (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> <li><a href="https://github.com/liuxingbaoyu"><code>@liuxingbaoyu</code></a></li> </ul> <h2>v7.23.1 (2023-09-25)</h2> <p>Re-publishing <code>@babel/helpers</code> due to a publishing error in 7.23.0.</p> <h2>v7.23.0 (2023-09-25)</h2> <p>Thanks <a href="https://github.com/lorenzoferre"><code>@lorenzoferre</code></a> and <a href="https://github.com/RajShukla1"><code>@RajShukla1</code></a> for your first PRs!</p> <h4>:rocket: New Feature</h4> <ul> <li><code>babel-plugin-proposal-import-wasm-source</code>, <code>babel-plugin-syntax-import-source</code>, <code>babel-plugin-transform-dynamic-import</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15870">#15870</a> Support transforming <code>import source</code> for wasm (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-helper-module-transforms</code>, <code>babel-helpers</code>, <code>babel-plugin-proposal-import-defer</code>, <code>babel-plugin-syntax-import-defer</code>, <code>babel-plugin-transform-modules-commonjs</code>, <code>babel-runtime-corejs2</code>, <code>babel-runtime-corejs3</code>, <code>babel-runtime</code>, <code>babel-standalone</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15878">#15878</a> Implement <code>import defer</code> proposal transform support (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-generator</code>, <code>babel-parser</code>, <code>babel-types</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15845">#15845</a> Implement <code>import defer</code> parsing support (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> <li><a href="https://redirect.github.com/babel/babel/pull/15829">#15829</a> Add parsing support for the "source phase imports" proposal (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-generator</code>, <code>babel-helper-module-transforms</code>, <code>babel-parser</code>, <code>babel-plugin-transform-dynamic-import</code>, <code>babel-plugin-transform-modules-amd</code>, <code>babel-plugin-transform-modules-commonjs</code>, <code>babel-plugin-transform-modules-systemjs</code>, <code>babel-traverse</code>, <code>babel-types</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15682">#15682</a> Add <code>createImportExpressions</code> parser option (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> <li><code>babel-standalone</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15671">#15671</a> Pass through nonce to the transformed script element (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> <li><code>babel-helper-function-name</code>, <code>babel-helper-member-expression-to-functions</code>, <code>babel-helpers</code>, <code>babel-parser</code>, <code>babel-plugin-proposal-destructuring-private</code>, <code>babel-plugin-proposal-optional-chaining-assign</code>, <code>babel-plugin-syntax-optional-chaining-assign</code>, <code>babel-plugin-transform-destructuring</code>, <code>babel-plugin-transform-optional-chaining</code>, <code>babel-runtime-corejs2</code>, <code>babel-runtime-corejs3</code>, <code>babel-runtime</code>, <code>babel-standalone</code>, <code>babel-types</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15751">#15751</a> Add support for optional chain in assignments (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-helpers</code>, <code>babel-plugin-proposal-decorators</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15895">#15895</a> Implement the "decorator metadata" proposal (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-traverse</code>, <code>babel-types</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15893">#15893</a> Add <code>t.buildUndefinedNode</code> (<a href="https://github.com/liuxingbaoyu"><code>@liuxingbaoyu</code></a>)</li> </ul> </li> <li><code>babel-preset-typescript</code></li> </ul>  </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/babel/babel/blob/main/CHANGELOG.md"><code>@babel/traverse</code>'s changelog</a>.</em></p> <blockquote> <h2>v7.23.2 (2023-10-11)</h2> <h4>:bug: Bug Fix</h4> <ul> <li><code>babel-traverse</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/16033">#16033</a> Only evaluate own String/Number/Math methods (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-preset-typescript</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/16022">#16022</a> Rewrite <code>.tsx</code> extension when using <code>rewriteImportExtensions</code> (<a href="https://github.com/jimmydief"><code>@jimmydief</code></a>)</li> </ul> </li> <li><code>babel-helpers</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/16017">#16017</a> Fix: fallback to typeof when toString is applied to incompatible object (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> <li><code>babel-helpers</code>, <code>babel-plugin-transform-modules-commonjs</code>, <code>babel-runtime-corejs2</code>, <code>babel-runtime-corejs3</code>, <code>babel-runtime</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/16025">#16025</a> Avoid override mistake in namespace imports (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> </ul> <h2>v7.23.0 (2023-09-25)</h2> <h4>:rocket: New Feature</h4> <ul> <li><code>babel-plugin-proposal-import-wasm-source</code>, <code>babel-plugin-syntax-import-source</code>, <code>babel-plugin-transform-dynamic-import</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15870">#15870</a> Support transforming <code>import source</code> for wasm (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-helper-module-transforms</code>, <code>babel-helpers</code>, <code>babel-plugin-proposal-import-defer</code>, <code>babel-plugin-syntax-import-defer</code>, <code>babel-plugin-transform-modules-commonjs</code>, <code>babel-runtime-corejs2</code>, <code>babel-runtime-corejs3</code>, <code>babel-runtime</code>, <code>babel-standalone</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15878">#15878</a> Implement <code>import defer</code> proposal transform support (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-generator</code>, <code>babel-parser</code>, <code>babel-types</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15845">#15845</a> Implement <code>import defer</code> parsing support (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> <li><a href="https://redirect.github.com/babel/babel/pull/15829">#15829</a> Add parsing support for the "source phase imports" proposal (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-generator</code>, <code>babel-helper-module-transforms</code>, <code>babel-parser</code>, <code>babel-plugin-transform-dynamic-import</code>, <code>babel-plugin-transform-modules-amd</code>, <code>babel-plugin-transform-modules-commonjs</code>, <code>babel-plugin-transform-modules-systemjs</code>, <code>babel-traverse</code>, <code>babel-types</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15682">#15682</a> Add <code>createImportExpressions</code> parser option (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> <li><code>babel-standalone</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15671">#15671</a> Pass through nonce to the transformed script element (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> <li><code>babel-helper-function-name</code>, <code>babel-helper-member-expression-to-functions</code>, <code>babel-helpers</code>, <code>babel-parser</code>, <code>babel-plugin-proposal-destructuring-private</code>, <code>babel-plugin-proposal-optional-chaining-assign</code>, <code>babel-plugin-syntax-optional-chaining-assign</code>, <code>babel-plugin-transform-destructuring</code>, <code>babel-plugin-transform-optional-chaining</code>, <code>babel-runtime-corejs2</code>, <code>babel-runtime-corejs3</code>, <code>babel-runtime</code>, <code>babel-standalone</code>, <code>babel-types</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15751">#15751</a> Add support for optional chain in assignments (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-helpers</code>, <code>babel-plugin-proposal-decorators</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15895">#15895</a> Implement the "decorator metadata" proposal (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-traverse</code>, <code>babel-types</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15893">#15893</a> Add <code>t.buildUndefinedNode</code> (<a href="https://github.com/liuxingbaoyu"><code>@liuxingbaoyu</code></a>)</li> </ul> </li> <li><code>babel-preset-typescript</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15913">#15913</a> Add <code>rewriteImportExtensions</code> option to TS preset (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-parser</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15896">#15896</a> Allow TS tuples to have both labeled and unlabeled elements (<a href="https://github.com/yukukotani"><code>@yukukotani</code></a>)</li> </ul> </li> </ul> <h4>:bug: Bug Fix</h4> <ul> <li><code>babel-plugin-transform-block-scoping</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15962">#15962</a> fix: <code>transform-block-scoping</code> captures the variables of the method in the loop (<a href="https://github.com/liuxingbaoyu"><code>@liuxingbaoyu</code></a>)</li> </ul> </li> </ul> <h4>:nail_care: Polish</h4> <ul> <li><code>babel-traverse</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15797">#15797</a> Expand evaluation of global built-ins in <code>@babel/traverse</code> (<a href="https://github.com/lorenzoferre"><code>@lorenzoferre</code></a>)</li> </ul> </li> <li><code>babel-plugin-proposal-explicit-resource-management</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15985">#15985</a> Improve source maps for blocks with <code>using</code> declarations (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> </ul> <h4>:microscope: Output optimization</h4> <ul> <li><code>babel-core</code>, <code>babel-helper-module-transforms</code>, <code>babel-plugin-transform-async-to-generator</code>, <code>babel-plugin-transform-classes</code>, <code>babel-plugin-transform-dynamic-import</code>, <code>babel-plugin-transform-function-name</code>, <code>babel-plugin-transform-modules-amd</code>, <code>babel-plugin-transform-modules-commonjs</code>, <code>babel-plugin-transform-modules-umd</code>, <code>babel-plugin-transform-parameters</code>, <code>babel-plugin-transform-react-constant-elements</code>, <code>babel-plugin-transform-react-inline-elements</code>, <code>babel-plugin-transform-runtime</code>, <code>babel-plugin-transform-typescript</code>, <code>babel-preset-env</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15984">#15984</a> Inline <code>exports.XXX =</code> update in simple variable declarations (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> </ul> <h2>v7.22.20 (2023-09-16)</h2>  </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/babel/babel/commit/b4b9942a6cde0685c222eb3412347880aae40ad5"><code>b4b9942</code></a> v7.23.2</li> <li><a href="https://github.com/babel/babel/commit/b13376b346946e3f62fc0848c1d2a23223314c82"><code>b13376b</code></a> Only evaluate own String/Number/Math methods (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-traverse/issues/16033">#16033</a>)</li> <li><a href="https://github.com/babel/babel/commit/ca58ec15cb6dde6812c36997477e44880bec0bba"><code>ca58ec1</code></a> v7.23.0</li> <li><a href="https://github.com/babel/babel/commit/0f333dafcf470f1970083e4e695ced6aec8bead0"><code>0f333da</code></a> Add <code>createImportExpressions</code> parser option (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-traverse/issues/15682">#15682</a>)</li> <li><a href="https://github.com/babel/babel/commit/3744545649fdc21688a2f3c97e1e39dbebff0d21"><code>3744545</code></a> Fix linting</li> <li><a href="https://github.com/babel/babel/commit/c7e6806e2194deb36c330f543409c792592b22d4"><code>c7e6806</code></a> Add <code>t.buildUndefinedNode</code> (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-traverse/issues/15893">#15893</a>)</li> <li><a href="https://github.com/babel/babel/commit/38ee8b4dd693f1e2bd00107bbc1167ce84736ea0"><code>38ee8b4</code></a> Expand evaluation of global built-ins in <code>@babel/traverse</code> (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-traverse/issues/15797">#15797</a>)</li> <li><a href="https://github.com/babel/babel/commit/9f3dfd90211472cf0083a3234dd1a1b857ce3624"><code>9f3dfd9</code></a> v7.22.20</li> <li><a href="https://github.com/babel/babel/commit/3ed28b29c1fb15588369bdd55187b69f1248e87d"><code>3ed28b2</code></a> Fully support <code>||</code> and <code>&&</code> in <code>pluginToggleBooleanFlag</code> (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-traverse/issues/15961">#15961</a>)</li> <li><a href="https://github.com/babel/babel/commit/77b0d7359909c94f3797c24006f244847fbc8d6d"><code>77b0d73</code></a> v7.22.19</li> <li>Additional commits viewable in <a href="https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=@babel/traverse&package-manager=npm_and_yarn&previous-version=7.21.3&new-version=7.23.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/Shopify/polaris/network/alerts). </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

### WHAT is this pull request doing? Adds missing images back to: - Listbox - Combobox - Index filters - Skeleton Display Text - Skeleton Body Text - Skeleton Page - Modal ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)  <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide

### WHY are these changes introduced? Fixes point 3 in Shopify#10897 The `monochromePlain` variant, was using `currentColor` when `disabled`. ### WHAT is this pull request doing? This PR replaces the `currentColor` with the `text-disabled` token as outlined in Shopify#10897. In addition, storybook has been updated to include the `monochromePlain` variant in the disabled preview. | Before | After | | ----------- | ----------- | | <img width="130" alt="Screenshot 2023-10-09 at 20 47 44" src="https://github.com/Shopify/polaris/assets/50641262/5c209557-ee3a-47cc-9195-0cb33e452fc4"> | <img width="136" alt="Screenshot 2023-10-09 at 20 45 00" src="https://github.com/Shopify/polaris/assets/50641262/ebb27d1d-0516-4c0d-988f-887b9e25ebdd">| ### 🎩 checklist - [X] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [X] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [X] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide

Do should be a Don't

)

### WHY are these changes introduced? Keeps our stylelint-polaris version matchups chart up to date with the latest releases. ### WHAT is this pull request doing? Adds the following versions to the stylelint-polaris version matchups chart: | @shopify/stylelint-polaris | @shopify/polaris | | -------------------------- | ---------------- | | 14.0.0 | 11.12.0 | | 15.0.0 | 12.0.0 |

### WHY are these changes introduced? Fixes Shopify#10995 Fixes Shopify#11006  ### WHAT is this pull request doing? Fixes the `buttonFrom` util not mapping the action parameter's boolean variant properties to `variant` and `tone`. | Before | [After]() | |--------|--------| | <img width="665" alt="Screenshot 2023-10-25 at 4 03 52 PM" src="https://github.com/Shopify/polaris/assets/18447883/a3dfa184-c0ce-465c-97ea-32e5f6cfff86">| <img width="671" alt="Screenshot 2023-10-25 at 4 02 41 PM" src="https://github.com/Shopify/polaris/assets/18447883/1b85d1ed-4804-4776-a168-a551ff298102">| ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [x] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide

@SMAKSS

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-migrator@0.26.1 ### Patch Changes - Updated dependencies \[[`f1d256fce`](Shopify@f1d256f)]: - @shopify/polaris-tokens@8.0.1 - @shopify/stylelint-polaris@15.0.1 ## @shopify/polaris@12.0.1 ### Patch Changes - [Shopify#10792](Shopify#10792) [`2980e9d26`](Shopify@2980e9d) Thanks [@SMAKSS](https://github.com/SMAKSS)! - Fixed typos and `editOnGithubUrl` in docs - [Shopify#10960](Shopify#10960) [`d7e4aa7f9`](Shopify@d7e4aa7) Thanks [@oksanashopify](https://github.com/oksanashopify)! - fixed background-color for unselectable tabel first-child cell - [Shopify#10975](Shopify#10975) [`00952a33a`](Shopify@00952a3) Thanks [@kyledurand](https://github.com/kyledurand)! - Fixed loading button spinner color - [Shopify#10935](Shopify#10935) [`8568e5141`](Shopify@8568e51) Thanks [@gazjones00](https://github.com/gazjones00)! - Fixed an issue with the `primary` variant styles conflicting with the `tertiary` variant in `Button` - [Shopify#10934](Shopify#10934) [`de419ba2b`](Shopify@de419ba) Thanks [@gazjones00](https://github.com/gazjones00)! - Fixed disabled state for `monochromePlain` variant in `Button` - [Shopify#10993](Shopify#10993) [`fb508b91c`](Shopify@fb508b9) Thanks [@FCalabria](https://github.com/FCalabria)! - Fixed incompatible type between IndexTable and useIndexResourceState - [Shopify#10998](Shopify#10998) [`bb310cd3a`](Shopify@bb310cd) Thanks [@alisterdev](https://github.com/alisterdev)! - Update SkeletonThumbnail size values to correspond to Thumbnail - [Shopify#10999](Shopify#10999) [`e34a4db32`](Shopify@e34a4db) Thanks [@kyledurand](https://github.com/kyledurand)! - Updated `Checkbox` icon to use tokens vs hard coded value - [Shopify#10910](Shopify#10910) [`65998488f`](Shopify@6599848) Thanks [@chloerice](https://github.com/chloerice)! - Fixed negative margin of `segmented` `ButtonGroup.Item` when child `Button` is `primary` - [Shopify#11028](Shopify#11028) [`9fb367afd`](Shopify@9fb367a) Thanks [@chloerice](https://github.com/chloerice)! - Fixed `buttonFrom` utility function not mapping boolean variant properties to `variant` and `tone` - Updated dependencies \[[`f1d256fce`](Shopify@f1d256f)]: - @shopify/polaris-tokens@8.0.1 ## @shopify/polaris-tokens@8.0.1 ### Patch Changes - [Shopify#10976](Shopify#10976) [`f1d256fce`](Shopify@f1d256f) Thanks [@sarahill](https://github.com/sarahill)! - Added descriptions to color tokens ## @shopify/stylelint-polaris@15.0.1 ### Patch Changes - Updated dependencies \[[`f1d256fce`](Shopify@f1d256f)]: - @shopify/polaris-tokens@8.0.1 ## polaris.shopify.com@0.59.0 ### Minor Changes - [Shopify#11030](Shopify#11030) [`f55a84ce7`](Shopify@f55a84c) Thanks [@lgriffee](https://github.com/lgriffee)! - Update stylelint-polaris version matchups chart ### Patch Changes - [Shopify#10792](Shopify#10792) [`2980e9d26`](Shopify@2980e9d) Thanks [@SMAKSS](https://github.com/SMAKSS)! - Fixed typos and `editOnGithubUrl` in docs - [Shopify#10974](Shopify#10974) [`2b3b61069`](Shopify@2b3b610) Thanks [@sam-b-rose](https://github.com/sam-b-rose)! - Removed autoplay from all videos on Motion design guidance pages - [Shopify#10925](Shopify#10925) [`4590fd828`](Shopify@4590fd8) Thanks [@MohammedEsafi](https://github.com/MohammedEsafi)! - Improved the visibility of shadows in Dark Mode for token previews - Updated dependencies \[[`2980e9d26`](Shopify@2980e9d), [`d7e4aa7f9`](Shopify@d7e4aa7), [`00952a33a`](Shopify@00952a3), [`8568e5141`](Shopify@8568e51), [`de419ba2b`](Shopify@de419ba), [`fb508b91c`](Shopify@fb508b9), [`bb310cd3a`](Shopify@bb310cd), [`e34a4db32`](Shopify@e34a4db), [`f1d256fce`](Shopify@f1d256f), [`65998488f`](Shopify@6599848), [`9fb367afd`](Shopify@9fb367a)]: - @shopify/polaris@12.0.1 - @shopify/polaris-tokens@8.0.1 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

### WHY are these changes introduced? `/design/*/index.md` were missing from the grid e.g. `/design/colors/index.md`. Adding some middleware logic to make sure they are added in the correct order specified in the `.md` files  ### WHAT is this pull request doing? Before <img width="1624" alt="Screenshot 2023-10-10 at 3 55 44 PM" src="https://github.com/Shopify/polaris/assets/4642404/178645a4-cb20-4b01-aee9-877c3701a020"> After <img width="1624" alt="Screenshot 2023-10-10 at 3 55 11 PM" src="https://github.com/Shopify/polaris/assets/4642404/1bcf2ae1-e86f-4905-8cc8-63974fcb3a9e">   ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)  <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide --------- Co-authored-by: Jess Telford <jess.telford@shopify.com>

### WHY are these changes introduced? To prevent type errors from slipping through as Button API undergoes continued alignment, the `buttonFrom` utility needs tests. Right now in v12 the Button boolean props no longer exist as they were replaced with `variant` and `tone`, but `Action` and its extended types still support `destructive`, `plain`, etc. `buttonFrom` takes a `ComplexAction` as its first param and a `Partial<ButtonProps>` object as an optional second param. The utility was not mapping the action boolean properties to `variant` and `tone` as expected (fixed in Shopify#11028). This went uncaught because there were no tests and no stories rendering button variants created with the utility (like Modal's `primaryAction`). ### WHAT is this pull request doing? This PR adds tests for `buttonFrom` and `buttonsFrom`.

… box. (Shopify#10808) Related to Shopify/polaris-internal#999 **Before** ![image](https://github.com/Shopify/polaris/assets/612020/683395dc-e9b2-467f-9ffd-5e2240b97b00) **This PR** ![index-filters-loading-demo](https://github.com/Shopify/polaris/assets/612020/b103aca2-85d0-4564-bf98-db1d3c92bd29) | | | |---|---| | Filters mode | ![index-filters-loading-1](https://github.com/Shopify/polaris/assets/612020/b1aa9dae-ff56-4908-bf7b-241520e4b611) | | Search mode, no input | ![index-filters-loading-2](https://github.com/Shopify/polaris/assets/612020/e96fa14a-e719-40fb-8c8d-b12892c6f388) | | Search mode, with input | ![index-filters-loading-3](https://github.com/Shopify/polaris/assets/612020/4c392f3d-373f-4a01-a793-1882fdf8c741) |

### WHY are these changes introduced? Fixes Shopify#10794   ### WHAT is this pull request doing?   Fix variant tokens in `<Text />` docs. ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [x] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [x] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide

Closes Shopify#11019

### WHY are these changes introduced? While working on `color` migrations in one of the web deps I came across some `color` tokens that were in [this spreadsheet](https://docs.google.com/spreadsheets/d/1Bm3-a-e5BRCelz1VmPJHmjrGrd-ZtFVH_b0_yFpzBHc/edit#gid=2044767004) but not in our current migrations and charts. ### WHAT is this pull request doing? Adds the following `color` token replacement maps to `v12-styles-replace-custom-property-color` migration and our v11 to v12 migration guide: | Deprecated Token | Replacement Value | | -------------------------------------------------------- | ------------------------------------------ | | `--p-color-bg-interactive-active` | `--p-color-bg-fill-brand-active` | | `--p-color-bg-interactive-disabled` | `--p-color-bg-surface-disabled` | | `--p-color-bg-interactive-hover` | `--p-color-bg-fill-brand-hover` | | `--p-color-bg-interactive-subdued` | `--p-color-bg-surface-brand` | |`--p-color-border-strong-hover` | `--p-color-border-tertiary` | --------- Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com>

…`hideIcon` is true (Shopify#11049) ## Before When `<Banner hideIcon onDismiss={() => {}} />` [Sandbox demo](https://polaris.shopify.com/sandbox?code=N4Igxg9gJgpiBcIA8AhAhgOwzATgAgAsBLWASUgzwgwBEiBnAWwfoF5gAKASj1YD48wAL5C%2BAZRhQ8AVwAueAA656ComCJpZDGRlhVGGbQ1kw8GTdPp5cOCPnpF5ANwgAbaQtmaYjPGjBglpha0r5QbnY%2BAI7Spq5o0lDBRKEANHiyEF6%2BOD5%2BSjgajOkwaDGmRAr0aHgxaKZoAEZ4RK6uEC0YTjAYmbl43YVeWlYw8nUOfjhgxCZgmXiNpV6mTo71eFBqXnj00r3WAB4KrmpNEAB0eAByPh09RL6V1b4u7p7evjEaA24eXlYHPI0CpcOZZNJ8Al5NBHH45HgAGbSADmjnS9EktWkPwomJi%2Bwh%2BEYaBRhk2EVyowgVm%2BeBwmiI1FWfw%2BJl8%2BJxZhg9HUhKut3KijstmxDDqvh5snSdPC7VyTyqoTFNTldl2cLQjDG6TxMHmY0h6TQW1UvKIAxgp2luyx3xqGGoZlCEusKSsjFhGR8CjsNSIGHUUEJMnk8UakWs8jV-RJZK1flOrrquE0v3ewx8VwAqvIHr4TXhmIYSZbDFqZTirI76LIcMqYIdcOphkzsL5pG0E5AcL7CoDLOpVGHzoUaRWzAwLQi0EmcVJG9YapBGJ6tng9XUiQB%2BPAARSr8PZltc1mVKX6uQUuQIPVgQzFnSX6f%2B3hPcJ5mOxCcMxFPntcKUNFMTdpAsHB0m6U9WncL4uRjPIYGVZE0TTGIOjeV9q07eJFDQQpwO3JAAHp0CwXA%2BBAVIQFkW9tXoBAAG0QHaMBZxgeAehAABdaiAHcSFohj4EY7ihCAA) <img width="402" alt="Screenshot 2023-10-27 at 1 28 59 PM" src="https://github.com/Shopify/polaris/assets/20652326/5285e7e4-15f4-44d9-8e09-bed6e9ef4810"> ## After https://5d559397bae39100201eedc1-uuqgzxigsi.chromatic.com/?path=/story/all-components-banner--all <img width="1183" alt="Screenshot 2023-10-27 at 2 04 36 PM" src="https://github.com/Shopify/polaris/assets/20652326/f5e1e94d-6ede-4dfe-90a7-7bc983f38726">

### WHY are these changes introduced? Make it easier to find component migrations. ### WHAT is this pull request doing? Alphabetizes the component list in our v11 to v12 migration guide. | Before | After | | --- | --- | | <img width="304" alt="Screenshot 2023-10-27 at 11 49 03 AM" src="https://github.com/Shopify/polaris/assets/21976492/a9738d5a-bd41-4c89-bac0-5f2fa1c7c1ff">| <img width="314" alt="Screenshot 2023-10-27 at 11 48 54 AM" src="https://github.com/Shopify/polaris/assets/21976492/9cd71300-0e7a-44b5-9d50-cc462256e04d">|

### WHY are these changes introduced? Cleans up `experimental` flag from Badge `tone` types. ### WHAT is this pull request doing? [PR storybook](https://5d559397bae39100201eedc1-jgmoujeqeb.chromatic.com/?path=/story/all-components-badge--all) [Prod storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-badge--all) ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide

…er (tsc) when using Node16/Bundler Module Resolution. Fixes Shopify#10601

) ### WHAT is this pull request doing? Fixes: Shopify#11034 Matches v11 behaviour: https://codesandbox.io/s/naughty-resonance-23mqts?file=/App.tsx **v11** ![image](https://screenshot.click/27-46-nkg99-mvnpf.png) **v12 before** ![image](https://screenshot.click/27-45-8if4j-t6yey.png) **v12 after** ![image](https://screenshot.click/27-45-rw3u4-jrbre.png)  ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)  <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide

### WHY are these changes introduced? Updates examples for `gap` prop to use values that align with updated space tokens. ### WHAT is this pull request doing?   ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)  <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide

### WHY are these changes introduced? So far we've documented all of our migrations on the https://polaris.shopify.com/tools/polaris-migrator however we are missing documentation for v12. ### WHAT is this pull request doing? Adds v12 migration documentation to the https://polaris.shopify.com/tools/polaris-migrator page. --------- Co-authored-by: Lo Kim <lo.kim@shopify.com>

…opify#11021) This adds a condition to automatically release a new version of `polaris-for-vscode` after upldating the `@shopify/polaris-tokens` package. `@shopify/polaris-tokens` is the only package dependency in `polaris-for-vscode`. When we update our tokens, we should also publish a new version of the VS Code extension to the marketplace with the latest tokens. This will also keep the ability to trigger the workflow with the current process of creating a new release, but it changes the prefix from `vscode@x.x.x` to follow the convention of our other packages by using the package name `polaris-for-vscode@x.x.x`

…cripts/get-props (Shopify#11002) Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.18.13 to 7.23.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/babel/babel/releases"><code>@babel/traverse</code>'s releases</a>.</em></p> <blockquote> <h2>v7.23.2 (2023-10-11)</h2> <p><strong>NOTE</strong>: This release also re-publishes <code>@babel/core</code>, even if it does not appear in the linked release commit.</p> <p>Thanks <a href="https://github.com/jimmydief"><code>@jimmydief</code></a> for your first PR!</p> <h4>:bug: Bug Fix</h4> <ul> <li><code>babel-traverse</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/16033">#16033</a> Only evaluate own String/Number/Math methods (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-preset-typescript</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/16022">#16022</a> Rewrite <code>.tsx</code> extension when using <code>rewriteImportExtensions</code> (<a href="https://github.com/jimmydief"><code>@jimmydief</code></a>)</li> </ul> </li> <li><code>babel-helpers</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/16017">#16017</a> Fix: fallback to typeof when toString is applied to incompatible object (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> <li><code>babel-helpers</code>, <code>babel-plugin-transform-modules-commonjs</code>, <code>babel-runtime-corejs2</code>, <code>babel-runtime-corejs3</code>, <code>babel-runtime</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/16025">#16025</a> Avoid override mistake in namespace imports (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> </ul> <h4>Committers: 5</h4> <ul> <li>Babel Bot (<a href="https://github.com/babel-bot"><code>@babel-bot</code></a>)</li> <li>Huáng Jùnliàng (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> <li>James Diefenderfer (<a href="https://github.com/jimmydief"><code>@jimmydief</code></a>)</li> <li>Nicolò Ribaudo (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> <li><a href="https://github.com/liuxingbaoyu"><code>@liuxingbaoyu</code></a></li> </ul> <h2>v7.23.1 (2023-09-25)</h2> <p>Re-publishing <code>@babel/helpers</code> due to a publishing error in 7.23.0.</p> <h2>v7.23.0 (2023-09-25)</h2> <p>Thanks <a href="https://github.com/lorenzoferre"><code>@lorenzoferre</code></a> and <a href="https://github.com/RajShukla1"><code>@RajShukla1</code></a> for your first PRs!</p> <h4>:rocket: New Feature</h4> <ul> <li><code>babel-plugin-proposal-import-wasm-source</code>, <code>babel-plugin-syntax-import-source</code>, <code>babel-plugin-transform-dynamic-import</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15870">#15870</a> Support transforming <code>import source</code> for wasm (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-helper-module-transforms</code>, <code>babel-helpers</code>, <code>babel-plugin-proposal-import-defer</code>, <code>babel-plugin-syntax-import-defer</code>, <code>babel-plugin-transform-modules-commonjs</code>, <code>babel-runtime-corejs2</code>, <code>babel-runtime-corejs3</code>, <code>babel-runtime</code>, <code>babel-standalone</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15878">#15878</a> Implement <code>import defer</code> proposal transform support (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-generator</code>, <code>babel-parser</code>, <code>babel-types</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15845">#15845</a> Implement <code>import defer</code> parsing support (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> <li><a href="https://redirect.github.com/babel/babel/pull/15829">#15829</a> Add parsing support for the "source phase imports" proposal (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-generator</code>, <code>babel-helper-module-transforms</code>, <code>babel-parser</code>, <code>babel-plugin-transform-dynamic-import</code>, <code>babel-plugin-transform-modules-amd</code>, <code>babel-plugin-transform-modules-commonjs</code>, <code>babel-plugin-transform-modules-systemjs</code>, <code>babel-traverse</code>, <code>babel-types</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15682">#15682</a> Add <code>createImportExpressions</code> parser option (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> <li><code>babel-standalone</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15671">#15671</a> Pass through nonce to the transformed script element (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> <li><code>babel-helper-function-name</code>, <code>babel-helper-member-expression-to-functions</code>, <code>babel-helpers</code>, <code>babel-parser</code>, <code>babel-plugin-proposal-destructuring-private</code>, <code>babel-plugin-proposal-optional-chaining-assign</code>, <code>babel-plugin-syntax-optional-chaining-assign</code>, <code>babel-plugin-transform-destructuring</code>, <code>babel-plugin-transform-optional-chaining</code>, <code>babel-runtime-corejs2</code>, <code>babel-runtime-corejs3</code>, <code>babel-runtime</code>, <code>babel-standalone</code>, <code>babel-types</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15751">#15751</a> Add support for optional chain in assignments (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-helpers</code>, <code>babel-plugin-proposal-decorators</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15895">#15895</a> Implement the "decorator metadata" proposal (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-traverse</code>, <code>babel-types</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15893">#15893</a> Add <code>t.buildUndefinedNode</code> (<a href="https://github.com/liuxingbaoyu"><code>@liuxingbaoyu</code></a>)</li> </ul> </li> <li><code>babel-preset-typescript</code></li> </ul>  </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/babel/babel/blob/main/CHANGELOG.md"><code>@babel/traverse</code>'s changelog</a>.</em></p> <blockquote> <h2>v7.23.2 (2023-10-11)</h2> <h4>:bug: Bug Fix</h4> <ul> <li><code>babel-traverse</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/16033">#16033</a> Only evaluate own String/Number/Math methods (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-preset-typescript</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/16022">#16022</a> Rewrite <code>.tsx</code> extension when using <code>rewriteImportExtensions</code> (<a href="https://github.com/jimmydief"><code>@jimmydief</code></a>)</li> </ul> </li> <li><code>babel-helpers</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/16017">#16017</a> Fix: fallback to typeof when toString is applied to incompatible object (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> <li><code>babel-helpers</code>, <code>babel-plugin-transform-modules-commonjs</code>, <code>babel-runtime-corejs2</code>, <code>babel-runtime-corejs3</code>, <code>babel-runtime</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/16025">#16025</a> Avoid override mistake in namespace imports (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> </ul> <h2>v7.23.0 (2023-09-25)</h2> <h4>:rocket: New Feature</h4> <ul> <li><code>babel-plugin-proposal-import-wasm-source</code>, <code>babel-plugin-syntax-import-source</code>, <code>babel-plugin-transform-dynamic-import</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15870">#15870</a> Support transforming <code>import source</code> for wasm (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-helper-module-transforms</code>, <code>babel-helpers</code>, <code>babel-plugin-proposal-import-defer</code>, <code>babel-plugin-syntax-import-defer</code>, <code>babel-plugin-transform-modules-commonjs</code>, <code>babel-runtime-corejs2</code>, <code>babel-runtime-corejs3</code>, <code>babel-runtime</code>, <code>babel-standalone</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15878">#15878</a> Implement <code>import defer</code> proposal transform support (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-generator</code>, <code>babel-parser</code>, <code>babel-types</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15845">#15845</a> Implement <code>import defer</code> parsing support (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> <li><a href="https://redirect.github.com/babel/babel/pull/15829">#15829</a> Add parsing support for the "source phase imports" proposal (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-generator</code>, <code>babel-helper-module-transforms</code>, <code>babel-parser</code>, <code>babel-plugin-transform-dynamic-import</code>, <code>babel-plugin-transform-modules-amd</code>, <code>babel-plugin-transform-modules-commonjs</code>, <code>babel-plugin-transform-modules-systemjs</code>, <code>babel-traverse</code>, <code>babel-types</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15682">#15682</a> Add <code>createImportExpressions</code> parser option (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> <li><code>babel-standalone</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15671">#15671</a> Pass through nonce to the transformed script element (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> <li><code>babel-helper-function-name</code>, <code>babel-helper-member-expression-to-functions</code>, <code>babel-helpers</code>, <code>babel-parser</code>, <code>babel-plugin-proposal-destructuring-private</code>, <code>babel-plugin-proposal-optional-chaining-assign</code>, <code>babel-plugin-syntax-optional-chaining-assign</code>, <code>babel-plugin-transform-destructuring</code>, <code>babel-plugin-transform-optional-chaining</code>, <code>babel-runtime-corejs2</code>, <code>babel-runtime-corejs3</code>, <code>babel-runtime</code>, <code>babel-standalone</code>, <code>babel-types</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15751">#15751</a> Add support for optional chain in assignments (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-helpers</code>, <code>babel-plugin-proposal-decorators</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15895">#15895</a> Implement the "decorator metadata" proposal (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-traverse</code>, <code>babel-types</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15893">#15893</a> Add <code>t.buildUndefinedNode</code> (<a href="https://github.com/liuxingbaoyu"><code>@liuxingbaoyu</code></a>)</li> </ul> </li> <li><code>babel-preset-typescript</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15913">#15913</a> Add <code>rewriteImportExtensions</code> option to TS preset (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-parser</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15896">#15896</a> Allow TS tuples to have both labeled and unlabeled elements (<a href="https://github.com/yukukotani"><code>@yukukotani</code></a>)</li> </ul> </li> </ul> <h4>:bug: Bug Fix</h4> <ul> <li><code>babel-plugin-transform-block-scoping</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15962">#15962</a> fix: <code>transform-block-scoping</code> captures the variables of the method in the loop (<a href="https://github.com/liuxingbaoyu"><code>@liuxingbaoyu</code></a>)</li> </ul> </li> </ul> <h4>:nail_care: Polish</h4> <ul> <li><code>babel-traverse</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15797">#15797</a> Expand evaluation of global built-ins in <code>@babel/traverse</code> (<a href="https://github.com/lorenzoferre"><code>@lorenzoferre</code></a>)</li> </ul> </li> <li><code>babel-plugin-proposal-explicit-resource-management</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15985">#15985</a> Improve source maps for blocks with <code>using</code> declarations (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> </ul> <h4>:microscope: Output optimization</h4> <ul> <li><code>babel-core</code>, <code>babel-helper-module-transforms</code>, <code>babel-plugin-transform-async-to-generator</code>, <code>babel-plugin-transform-classes</code>, <code>babel-plugin-transform-dynamic-import</code>, <code>babel-plugin-transform-function-name</code>, <code>babel-plugin-transform-modules-amd</code>, <code>babel-plugin-transform-modules-commonjs</code>, <code>babel-plugin-transform-modules-umd</code>, <code>babel-plugin-transform-parameters</code>, <code>babel-plugin-transform-react-constant-elements</code>, <code>babel-plugin-transform-react-inline-elements</code>, <code>babel-plugin-transform-runtime</code>, <code>babel-plugin-transform-typescript</code>, <code>babel-preset-env</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15984">#15984</a> Inline <code>exports.XXX =</code> update in simple variable declarations (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> </ul> <h2>v7.22.20 (2023-09-16)</h2>  </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/babel/babel/commit/b4b9942a6cde0685c222eb3412347880aae40ad5"><code>b4b9942</code></a> v7.23.2</li> <li><a href="https://github.com/babel/babel/commit/b13376b346946e3f62fc0848c1d2a23223314c82"><code>b13376b</code></a> Only evaluate own String/Number/Math methods (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-traverse/issues/16033">#16033</a>)</li> <li><a href="https://github.com/babel/babel/commit/ca58ec15cb6dde6812c36997477e44880bec0bba"><code>ca58ec1</code></a> v7.23.0</li> <li><a href="https://github.com/babel/babel/commit/0f333dafcf470f1970083e4e695ced6aec8bead0"><code>0f333da</code></a> Add <code>createImportExpressions</code> parser option (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-traverse/issues/15682">#15682</a>)</li> <li><a href="https://github.com/babel/babel/commit/3744545649fdc21688a2f3c97e1e39dbebff0d21"><code>3744545</code></a> Fix linting</li> <li><a href="https://github.com/babel/babel/commit/c7e6806e2194deb36c330f543409c792592b22d4"><code>c7e6806</code></a> Add <code>t.buildUndefinedNode</code> (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-traverse/issues/15893">#15893</a>)</li> <li><a href="https://github.com/babel/babel/commit/38ee8b4dd693f1e2bd00107bbc1167ce84736ea0"><code>38ee8b4</code></a> Expand evaluation of global built-ins in <code>@babel/traverse</code> (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-traverse/issues/15797">#15797</a>)</li> <li><a href="https://github.com/babel/babel/commit/9f3dfd90211472cf0083a3234dd1a1b857ce3624"><code>9f3dfd9</code></a> v7.22.20</li> <li><a href="https://github.com/babel/babel/commit/3ed28b29c1fb15588369bdd55187b69f1248e87d"><code>3ed28b2</code></a> Fully support <code>||</code> and <code>&&</code> in <code>pluginToggleBooleanFlag</code> (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-traverse/issues/15961">#15961</a>)</li> <li><a href="https://github.com/babel/babel/commit/77b0d7359909c94f3797c24006f244847fbc8d6d"><code>77b0d73</code></a> v7.22.19</li> <li>Additional commits viewable in <a href="https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=@babel/traverse&package-manager=npm_and_yarn&previous-version=7.18.13&new-version=7.23.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/Shopify/polaris/network/alerts). </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…hopify#11062) ### WHAT is this pull request doing? This PR updates the ContextualSaveBar icon from CircleAlertMajor to RiskMajor. It also updates the examples to render the Shopify logo instead of an app logo. | [Before](https://storybook.polaris.shopify.com/?path=/story/all-components-contextualsavebar--default) | [After](https://5d559397bae39100201eedc1-vcjcqwedfu.chromatic.com/?path=/story/all-components-contextualsavebar--default)| |--------|--------| |<img width="1228" alt="Screenshot 2023-10-30 at 3 28 02 PM" src="https://github.com/Shopify/polaris/assets/18447883/01e75949-1e49-44bb-bfdd-02b1131b85aa"> | <img width="1227" alt="Screenshot 2023-10-30 at 3 29 18 PM" src="https://github.com/Shopify/polaris/assets/18447883/6875beb4-d2d4-41fe-9a5f-8cdecaf3c24b">| ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide

### WHY are these changes introduced? Fixes incorrect top right border radius on `Textfield.Spinner` component. ### WHAT is this pull request doing? In the Polaris v12 bug hunt, it was reported that the step for numeric text inputs had an incorrect top right border radius of `2px`, whereas all other points were `4px`. <details> <summary>TextField — before</summary> <img src="https://github.com/Shopify/polaris/assets/26749317/4c1ca28c-2e7c-4b66-baf1-59b13796f335" alt="TextField — before"> </details> <details> <summary>TextField — after</summary> <img src="https://github.com/Shopify/polaris/assets/26749317/65278946-122c-40aa-9725-1c539629f287" alt="TextField — after"> </details> ### How to 🎩 [Storybook](https://5d559397bae39100201eedc1-krxwnbabjn.chromatic.com/?path=/story/all-components-textfield--number) [Prod Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-textfield--number) 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide

@lgriffee

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-migrator@0.26.2 ### Patch Changes - [Shopify#11029](Shopify#11029) [`ca67934e0`](Shopify@ca67934) Thanks [@lgriffee](https://github.com/lgriffee)! - Update `v12-styles-replace-custom-property-color` migration with additional tokens - Updated dependencies \[[`73b1d5d2c`](Shopify@73b1d5d)]: - @shopify/polaris-tokens@8.0.2 - @shopify/stylelint-polaris@15.0.2 ## @shopify/polaris@12.0.2 ### Patch Changes - [Shopify#11037](Shopify#11037) [`f81abddba`](Shopify@f81abdd) Thanks [@chloerice](https://github.com/chloerice)! - Added tests for `buttonFrom` and `buttonsFrom` utility functions - [Shopify#11061](Shopify#11061) [`74fb5d5c6`](Shopify@74fb5d5) Thanks [@laurkim](https://github.com/laurkim)! - Fixed border radius styling on `TextField.Spinner` component - [Shopify#11062](Shopify#11062) [`78ff4e665`](Shopify@78ff4e6) Thanks [@chloerice](https://github.com/chloerice)! - Updated `ContextualSaveBar` icon to `RiskMajor` and updated logos in examples to Shopify logo - [Shopify#11052](Shopify#11052) [`27317aa4b`](Shopify@27317aa) Thanks [@kyledurand](https://github.com/kyledurand)! - Fixed destructive states for PageActions and Page SecondaryActions - [Shopify#11053](Shopify#11053) [`caf553126`](Shopify@caf5531) Thanks [@laurkim](https://github.com/laurkim)! - Removed `experimental` flag from Badge `tone` types - [Shopify#11049](Shopify#11049) [`7508e7014`](Shopify@7508e70) Thanks [@sophschneider](https://github.com/sophschneider)! - Fixed Banner InlineIconBanner variant dismiss icon position when hideIcon is true - [Shopify#10808](Shopify#10808) [`b0d5750b0`](Shopify@b0d5750) Thanks [@jesstelford](https://github.com/jesstelford)! - [IndexFilters] Loading spinner moved to be a suffix within the search box. - Updated dependencies \[[`73b1d5d2c`](Shopify@73b1d5d)]: - @shopify/polaris-tokens@8.0.2 ## @shopify/polaris-tokens@8.0.2 ### Patch Changes - [Shopify#10602](Shopify#10602) [`73b1d5d2c`](Shopify@73b1d5d) Thanks [@patrickDouglas](https://github.com/patrickDouglas)! - Export types missing for the Typescript Compiler (tsc) when using Node16/Bundler Module Resolution. ## @shopify/stylelint-polaris@15.0.2 ### Patch Changes - Updated dependencies \[[`73b1d5d2c`](Shopify@73b1d5d)]: - @shopify/polaris-tokens@8.0.2 ## polaris.shopify.com@0.60.0 ### Minor Changes - [Shopify#11045](Shopify#11045) [`a1c13938f`](Shopify@a1c1393) Thanks [@lgriffee](https://github.com/lgriffee)! - Add v12 polaris migrator documentation ### Patch Changes - [Shopify#10795](Shopify#10795) [`e78051a80`](Shopify@e78051a) Thanks [@SMAKSS](https://github.com/SMAKSS)! - Fixed typos in `<Text />` variant tokens - [Shopify#11051](Shopify#11051) [`f2fabff25`](Shopify@f2fabff) Thanks [@lgriffee](https://github.com/lgriffee)! - Alphabetize component list in v11 to v12 migration guide - [Shopify#11029](Shopify#11029) [`ca67934e0`](Shopify@ca67934) Thanks [@lgriffee](https://github.com/lgriffee)! - Update `v12-styles-replace-custom-property-color` migration with additional tokens - Updated dependencies \[[`f81abddba`](Shopify@f81abdd), [`74fb5d5c6`](Shopify@74fb5d5), [`78ff4e665`](Shopify@78ff4e6), [`27317aa4b`](Shopify@27317aa), [`caf553126`](Shopify@caf5531), [`7508e7014`](Shopify@7508e70), [`73b1d5d2c`](Shopify@73b1d5d), [`b0d5750b0`](Shopify@b0d5750)]: - @shopify/polaris@12.0.2 - @shopify/polaris-tokens@8.0.2 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…d components (spinner and input) (Shopify#11018)  ### WHY are these changes introduced? Fixes Shopify#10948 ### WHAT is this pull request doing? Prevent `onBlur` in TextField from triggering when moving focus between the `<input />` and `<Spinner />` child elements within a `<TextField />`   ### How to 🎩 [Spin HQ](https://web-polaris-text-field.zak-lee.us.spin.dev/) - `web` checked out on [ZL/quantity-price-break-minimum-quantity-fix](Shopify/web#100618) - `polaris` checked out on this PR's branch (ZL/text-field-blur) Tophat steps: - Observe the buggy behavior here: https://github.com/Shopify/polaris/assets/4310197/f298a261-76ca-452b-b9f0-984d789bcd26 - Go to the [CatalogEditor](https://admin.web.web-polaris-text-field.zak-lee.us.spin.dev/store/shop1/catalogs/9/editor) for a given Catalog - Open the QuantitySettingsModal by hovering over a row in the table and clicking in the column underneath "Quantity rules" - Test against the behavior in the buggy video linked above - note: the expected `onBlur` behavior that should occur when manipulating the "Increment" TextField: - "Minimum" value "snaps" (adjusts) to match the minimum behavior - any relevant "snap" messages should appear below - verify that subsequent increases to the "Increment" value via the `<Spinner />` does not trigger `onBlur` logic to occur UNTIL the user blurs off of the entire TextField component - verify that changes to "Increment" TextField value via the `<input />` does not trigger `onBlur` logic to occur UNTIL the user blurs off the entire TextField component - e.g. set input value to "5", then, without blurring off the "Increment" TextField, click the up arrow to bump the value to "6". this should not trigger any `onBlur` logic 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)  <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [x] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide --------- Co-authored-by: Chloe Rice <chloerice@users.noreply.github.com>

### WHY are these changes introduced? Fixes disabled button text color that was flagged on `ContextualSaveBar` during v12 bug hunt. ### WHAT is this pull request doing? Updates disabled button styles in `ContextualSaveBar`. <details> <summary>ContextualSaveBar — before</summary> <img src="https://github.com/Shopify/polaris/assets/26749317/ed54d30a-2888-48d9-8f73-ec4caced2fea" alt="ContextualSaveBar — before"> </details> <details> <summary>ContextualSaveBar — after</summary> <img src="https://github.com/Shopify/polaris/assets/26749317/66b3e9c3-0e2e-4f32-a763-2e5a81bd7dea" alt="ContextualSaveBar — after"> </details> ### How to 🎩 [Storybook](https://5d559397bae39100201eedc1-tcijtkhntq.chromatic.com/?path=/story/all-components-contextualsavebar--disabled) 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)  <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page, Frame, ContextualSaveBar} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} <div style={{height: '250px'}}> <Frame logo={{ width: 86, contextualSaveBarSource: 'https://cdn.shopify.com/s/files/1/2376/3301/files/Shopify_Secondary_Inverted.png', }} > <ContextualSaveBar message="Unsaved changes" saveAction={{ onAction: () => console.log('add form submit logic'), loading: false, disabled: true, }} discardAction={{ onAction: () => console.log('add clear form logic'), }} /> </Frame> </div> </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide

### WHY are these changes introduced? Fixes issue reported during v12 bughunt for incorrect Tooltip styling on IndexTable headers. ### WHAT is this pull request doing? Fixes values passed in from `defaultHeaderTooltipProps` to use the correct padding and border radius token values. <details> <summary>IndexTable Heading — before</summary> <img src="https://github.com/Shopify/polaris/assets/26749317/176a0b58-88b2-4ba6-9bba-2a10819dec2f" alt="IndexTable Heading — before"> </details> <details> <summary>IndexTable Heading — after</summary> <img src="https://github.com/Shopify/polaris/assets/26749317/635cbef9-3fec-46a5-a65a-6fa61d77abdf" alt="IndexTable Heading — after"> </details> ### How to 🎩 [Storybook](https://5d559397bae39100201eedc1-noluxcicog.chromatic.com/?path=/story/all-components-indextable--with-heading-tooltips) [Prod storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-indextable--with-heading-tooltips) 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide

> [!important] > This should be merged next week when the new production environment is stable and tested ### WHY are these changes introduced? Removes old production environment actions that are no longer used. ### WHAT is this pull request doing? - [x] Removes action for staging deploy - [x] Removes old production action - [x] Renames `prod-kit` action to the website deploy action ### Follow ups - [ ] Remove `polaris-site-container-builder` - [ ] Remove shipit stacks - [ ] Remove buildkite builder - [ ] Remove service entry

> [!Warning] > This includes multiple breaking changes to `@shopify/polaris-icons`. Do not merge until this is thoroughly tested and approved by internal consuming teams. ### What this PR does Removed Major and Minor icon sizing. All icons are the same size. Added `BillIcon`, `BillFilledIcon`, `LogoCriteo`, `LogoMeta`, `LogoGoogle`, `MetaobjectFilledIcon`, `PriceListIcon` and `PriceListFilledIcon` Updated icon design for `JobsIcon`, `JobsFilledIcon`, `AutomationIcon`, `AutomationFilledIcon`, `GiftCardIcon`, `InventoryFilledIcon`, `ReportsIcon`, `ShipmentFilledIcon`, `AppsFilledIcon`, `MarketsIcon`, `MarketsFilledIcon`, `BillingStatementDollarFilledIcon`, `BillingStatementEuroFilledIcon`, `BillingStatementPoundFilledIcon`, `BillingStatementRupeeFilledIcon`, `BillingStatementYenFilledIcon`, `LegalFilledIcon`, `IdentityCardIcon`, `IdentityCardFilledIcon`, `DomainsIcon`, `DomainNewIcon`, `DomainsFilledIcon`, `StoreIcon`, `OnlineStoreIcon`, `ManagedStoreIcon`, `ImportStoreIcon`, `TaxIcon`, `TaxFilledIcon`, `PackageFilledIcon`, `LocationIcon`, `LocationFilledIcon`, `InactiveLocationIcon`, `PinIcon`, `GlobeIcon`, `TransportIcon`, `NatureIcon`, `FoodIcon`, `ColorsIcon` Removed icons `ReportFilledMinor`, `ReportMinor`, `ListMajor`, `ListFilledMajor` Removed `version` and `set` from icon `.yml` files --- Closes Shopify#11259 Closes Shopify#11088 --------- Co-authored-by: Sam Rose <11774595+sam-b-rose@users.noreply.github.com> Co-authored-by: Aaron Casanova <aaron.casanova@shopify.com> Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com> Co-authored-by: Alex Bratsos <12677111+bratsos@users.noreply.github.com>

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases > The changelog information of each package has been omitted from this message, as the content exceeds the size limit. ## @shopify/polaris-icons@8.0.0 ## @shopify/polaris-migrator@0.27.0 ## @shopify/polaris@12.9.1 ## polaris.shopify.com@0.61.8 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

### WHY are these changes introduced? Fixes Shopify/web#114283 We currently have a bug in the FiltersBar component, where if all filters are pinned on mount, and a merchant either clicks the "Clear all" button, or clears a filter individually, then that filter vanishes until the merchant refreshes the page. The cause of this was some missing logic to determine whether to show the Add filter button. Previously, it only checked for pinned filters on mount, and not for changes to the pinned filter state. ### How to 🎩 Spin URL: https://admin.web.vanishing-filters.marc-thomas.eu.spin.dev/store/shop1/collections?selectedView=all Story instance: https://5d559397bae39100201eedc1-epgxutgfws.chromatic.com/?path=/story/all-components-filters--with-all-filters-pinned ### 🎩 checklist - [x] Tested a [snapshot](https://github.com/Shopify/polaris/blob/main/documentation/Releasing.md#-snapshot-releases) - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [x] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [x] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide

### WHY are these changes introduced? Builds are breaking currently due to some incorrect icon names still hanging around in stories within `polaris-react`. This PR updates all of those. ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#install-dependencies-and-build-workspaces) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [x] Tested a [snapshot](https://github.com/Shopify/polaris/blob/main/documentation/Releasing.md#-snapshot-releases) - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [x] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [x] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide

@mrcthms

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris@12.10.0 ### Minor Changes - [Shopify#11417](Shopify#11417) [`cea2dd22b`](Shopify@cea2dd2) Thanks [@mrcthms](https://github.com/mrcthms)! - [FiltersBar] Fixed bug where filters would disappear from the FiltersBar when clicking the Clear all button ### Patch Changes - [Shopify#11446](Shopify#11446) [`6e40eca5e`](Shopify@6e40eca) Thanks [@mrcthms](https://github.com/mrcthms)! - [Icons] Fixed references to incorrect icon imports that were causing Storybook to break ## polaris.shopify.com@0.61.9 ### Patch Changes - [Shopify#11446](Shopify#11446) [`6e40eca5e`](Shopify@6e40eca) Thanks [@mrcthms](https://github.com/mrcthms)! - [Icons] Fixed references to incorrect icon imports that were causing Storybook to break - Updated dependencies \[[`6e40eca5e`](Shopify@6e40eca), [`cea2dd22b`](Shopify@cea2dd2)]: - @shopify/polaris@12.10.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Right now the Icon details page has a link to a figma page that 404s ### WHY are these changes introduced? - resolves: Shopify#11435 ### WHAT is this pull request doing? Change the icon details link from: https://www.figma.com/community/file/1110993965108325096 to https://www.figma.com/community/file/1293614863849914283 ### Is this the right page to link to? I just found what looked like the right community page but I haven't confirmed with anyone from the polaris team! ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#install-dependencies-and-build-workspaces) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) Test that the link goes to the right page now. ### 🎩 checklist - [ ] Tested a [snapshot](https://github.com/Shopify/polaris/blob/main/documentation/Releasing.md#-snapshot-releases) - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide

…e in IndexFilters (Shopify#11412) ### WHY are these changes introduced? Fixes Shopify/shopify#407738 Updates the TextField component with new `loading` and `autoSize` props. The `loading` prop will show a spinner at the right of the input if `true`, whereas the `autoSize` prop will make the input grow with the value of the input itself. This is a required update to cater for the desired UX we want in the IndexFilters to persist the view name to the immediate right of the search query. This PR also updates the SearchField within the Filters component to utilise these new props on the TextField, as well as update stories and examples to show off the new functionality. ### WHAT is this pull request doing?  ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#install-dependencies-and-build-workspaces) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) Spin URL: https://admin.web.persistent-view-name.marc-thomas.eu.spin.dev/store/shop1/products?selectedView=archived&status=ARCHIVED - Navigate to the URL - Confirm that a placeholder is visible in the search TextField - Start typing into the search TextField - Confirm that the TextField grows as you type - Confirm that a suffix saying "in: [View name]" is visible only when a value is present in the TextField - Confirm that the suffix always stays a consistent spacing apart from the TextField - Confirm that other UI, such as the loading indicator, remain placed where they should be, right-aligned to the edge of the search area ### 🎩 checklist - [x] Tested a [snapshot](https://github.com/Shopify/polaris/blob/main/documentation/Releasing.md#-snapshot-releases) - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [x] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [x] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide --------- Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

Fixes missing icons on Foundations, Design, Content, Tools, and Version guides pages. | Before | After | | --- | --- | | <img width="1300" alt="before" src="https://github.com/Shopify/polaris/assets/11774595/6fb007d3-7af3-4f5c-8de9-4232add0b4c5"> | <img width="1300" alt="after" src="https://github.com/Shopify/polaris/assets/11774595/fde5c93d-47dd-41d2-83ec-d5d485439a0e"> |

Removes the `preversion` scripts that allowed us to call the `preversion` npm script hook before creating a new release with `@changesets/cli`.

This PR: - Adds a status message to inform user to use the newly named icon in `@shopify/polaris-icons@8.0.0` - Displays the Icon `id` rather than the `name` to better distinguish from the old `Major|Minor` suffix <img width="1788" alt="Screenshot 2024-01-17 at 3 59 45 PM" src="https://github.com/Shopify/polaris/assets/11774595/4a3d7fa2-2bd8-4935-94dc-cc6765c650c0">

…pify#11462) ### WHY are these changes introduced? Part of Shopify/polaris-internal#1343 ### WHAT is this pull request doing? Lower `Filter` container z-index (currently `100`) to be below `Card`'s shadow bevel z-index which is `32`. This is a similar bug/fix as [this issue](Shopify#11411). |Before|After| |-|-| |<img width="503" alt="Screenshot 2024-01-17 at 3 53 30 PM" src="https://github.com/Shopify/polaris/assets/20652326/88edab7c-aed8-44b8-9f5c-b9bd319405dc">|<img width="382" alt="Screenshot 2024-01-17 at 4 48 45 PM" src="https://github.com/Shopify/polaris/assets/20652326/7dc33fc8-333b-4e1d-afa7-f3efed5ad7a1">| ### How to 🎩 https://admin.web.web-kkgf.sophie-schneider.us.spin.dev/store/shop1/orders 1. Press search button on index table or verify shadow bevel is on the filter search bar in this story https://5d559397bae39100201eedc1-vszwcambil.chromatic.com/?path=/story/all-components-indexfilters--with-filtering-by-default (vs.[ on prod](https://storybook.polaris.shopify.com/?path=/story/all-components-indexfilters--with-filtering-by-default)) ### 🎩 checklist - [x] Tested a [snapshot](https://github.com/Shopify/polaris/blob/main/documentation/Releasing.md#-snapshot-releases) - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) --------- Co-authored-by: Laura Griffee <laura@mailzone.com>

### WHY are these changes introduced? Related to Shopify/web#102861 We want to improve the UX of the bulk actions and select actions in IndexTables and ResourceLists. The BulkActions should display in the sticky table header, the Pagination should now be sticky, and the SelectAllActions should behave in the same way as the pagination, sticky to the bottom of the table. Spin URL for ResourceList: https://admin.web.bulk-ui-3.marc-thomas.eu.spin.dev/store/shop1/products/13 Spin URL for IndexTable: https://admin.web.bulk-ui-3.marc-thomas.eu.spin.dev/store/shop1/products?selectedView=all Spin URL for ResourceListWithHeader: https://admin.web.bulk-ui-3.marc-thomas.eu.spin.dev/store/shop1/draft_orders?selectedView=all Resume Spin link: https://spin-control.shopify.io/instances/bulk-ui-3.marc-thomas.eu.spin.dev/resume https://github.com/Shopify/polaris/assets/2562596/372d275d-1138-451b-8457-5b3664818994 https://github.com/Shopify/polaris/assets/2562596/a80aaf5e-8f44-4ca0-9227-8debdf7d8445 ### WHAT is this pull request doing? - Transferring a lot of the logic that was in BulkActions to SelectAllActions, due to BulkActions no longer being sticky and SelectAllActions now being sticky - Updating button styles within BulkActions to match the more condensed mode of the sticky bar - Match SelectAllActions styling to match pagination - Pagination is now sticky  ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [x] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [x] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide

@sarahill

### WHY are these changes introduced? This slightly increases the contrast on the underline. Maybe we need a new token for dotted borders cc @sarahill Fixes Shopify/polaris-internal#1364 ### WHAT is this pull request doing? Before | After ---|--- ![image](https://screenshot.click/18-20-6boe5-pnt9r.png) | ![image](https://screenshot.click/18-21-g0c9q-eygvb.png)

…tton visible (Shopify#11466) ### WHY are these changes introduced? The loading spinner currently sits flat against the right-hand edge of the TextField when there is no clear button visible on screen, which we do not want. This PR adds some margin between the loading spinner and the edge of the TextField in this case, and makes sure to remove the margin when there is both the loading spinner and clear button present. Before: <img width="1624" alt="Screenshot 2024-01-18 at 12 06 40" src="https://github.com/Shopify/polaris/assets/2562596/bff82a29-8cc2-4491-a394-ba5eeae946f4"> After: <img width="1624" alt="Screenshot 2024-01-18 at 12 16 44" src="https://github.com/Shopify/polaris/assets/2562596/5438b423-2a2a-4307-9e6a-41d5d90006b2"> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#install-dependencies-and-build-workspaces) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [x] Tested a [snapshot](https://github.com/Shopify/polaris/blob/main/documentation/Releasing.md#-snapshot-releases) - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [x] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [x] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide

Closes Shopify#11422 Reduces the focus ring closer to the original size for the `plain` and `plainMonochrome` button variants. This PR also applied the underline text decoration styles when focused for the `plain` varaint. ### `plain` https://github.com/Shopify/polaris/assets/11774595/a46629d5-d0e5-414d-8296-7caba60d0831 ### `plainMonochrome` https://github.com/Shopify/polaris/assets/11774595/785757b2-7b9b-4f15-b3b0-53b0b2ce8285

Closes Shopify#11377 This PR: - Updates the `--p-shadow-button-*` tokens to the new button style values from the Button refactor - Replaces the hardcoded values in Button component styles with shadow tokens There should be no visual changes. --------- Co-authored-by: Chloe Rice <chloerice@users.noreply.github.com>

…to roll up (Shopify#11441) Fixes Shopify/shopify#466571 ### WHY are these changes introduced? The current implementation of the logic to determine which actions and groups get shown, and which get rolled up, is a little flaky. We are seeing actions get rolled up on mount, and then render as normal on re-render. We are also seeing inconsistent results when resizing the browser. This is not ideal, as we want our merchants to experience a predictable UI each time they visit a page. ### WHAT is this pull request doing? This PR switches out the existing logic for measuring all the actions and groups, and replaces it with logic used in the Tabs component, which should be more reliable. ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#install-dependencies-and-build-workspaces) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) Spin URL: https://admin.web.page-actions-bug.marc-thomas.eu.spin.dev/store/shop1/email_templates/payment_reminder/preview Spin resume URL: https://spin-control.shopify.io/instances/page-actions-bug.marc-thomas.eu.spin.dev/resume ### 🎩 checklist - [x] Tested a [snapshot](https://github.com/Shopify/polaris/blob/main/documentation/Releasing.md#-snapshot-releases) - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [x] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [x] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide --------- Co-authored-by: Chloe Rice <chloerice@users.noreply.github.com>

@mrcthms

This PR adds async translations requested in Shopify#11412, which was opened by @mrcthms. It will append multiple commits and may add, modify, or delete translations. Feel free to merge the PR any time; we'll open a new PR if any more translations come in. [Check the source PR's overall translation progress here.](https://translation-platform.shopify.io/repos/Shopify/polaris/pulls/11412/progress) ## Before you deploy - Check translations for malicious HTML. ## Merge conflicts? <details> If this PR has been open long enough that it has drifted out of sync from the base branch and it has developed merge conflicts as a result, follow these steps, in order: 1. Close this PR. 2. Run the following Spy command in Slack: > `@spy translation-platform force-pull Shopify/polaris pull_request_number=11412` Translation Platform will recreate the translation commits based on the latest commit on the base branch and open a new PR. </details> ## Missing completed translations? <details> If the translations were completed within the last several hours, Translation Platform may just be holding on to them for a bit to see if any others come in before creating a commit (multiple file changes are committed together to reduce noise). If it's been a while and completed translations are still missing, or if you're just in a hurry, you can run the following Spy command in Slack to download or re-download any completed translations to this PR: > `@spy translation-platform force-pull Shopify/polaris pull_request_number=11412` - The translations might have been added to the source PR, but the PR was rebased before it was shipped and the translations were accidentally dropped. - A later change to the translation files might have overwritten the previously downloaded translations. - Translation Platform might have failed to download the translations-- if you suspect this to be the case, please reach out at the link below. </details> ## Questions? Visit [#help-localization](https://shopify.slack.com/messages/C7TJQLVC7) for questions about this pull request. --------- Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> Co-authored-by: Marc Thomas <marc.thomas@shopify.com>

…Actions and SelectAllActions (Shopify#11474) ### WHY are these changes introduced? As part of a recent update to how we do Bulk UI in IndexTable and ResourceLists, we moved some props around between the SelectAllActions and BulkActions components. We need to ensure that these props remain on the components and get deprecated, rather than remove them entirely to ensure that the update doesn't fall into a breaking release, rather than a minor one. This PR re-introduces the props that were moved between BulkActions and SelectAllActions, and includes tests to ensure functionality remains as it was if these deprecated props were provided, and stories to show how the components look with the deprecated props. I have not added the BulkActions and SelectAllAction stories to the polaris.shopify.com site as these components should only really ever be consumed internally by other Polaris components. ### How to 🎩 Snapshot testing: https://admin.web.deprecated-props-playground.marc-thomas.eu.spin.dev/store/shop1/products?selectedView=all Storybook: https://5d559397bae39100201eedc1-pihlxmllju.chromatic.com/ ### 🎩 checklist - [x] Tested a [snapshot](https://github.com/Shopify/polaris/blob/main/documentation/Releasing.md#-snapshot-releases) - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [x] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [x] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide

…ify#11487)  ### WHY are these changes introduced? ⚠️ **Important** **This PR needs to be released with changes to Shopify/web https://github.com/Shopify/web/pull/115536** Context: This PR is re-doing the changes of Shopify#11354. When Shopify#11354 there was a regression in Shopify POS that needed to be rolled back. I've since found a fix for the issue in https://github.com/Shopify/web/pull/115536. These two PRs need to be released to web at the same time in order to fix the issue in the Modal component AND prevent the regression in POS when polaris-react version gets bumped. Addresses Shopify#11185  Before https://github.com/Shopify/polaris/assets/4642404/8afa1dc4-7193-4616-8537-bbe86db9168f After https://github.com/Shopify/polaris/assets/4642404/c463c9e7-14e5-4edd-be65-430e69abb19d  ### WHAT is this pull request doing?  ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#install-dependencies-and-build-workspaces) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [ ] Tested a [snapshot](https://github.com/Shopify/polaris/blob/main/documentation/Releasing.md#-snapshot-releases) - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide

![datasource-connect](https://github.com/Shopify/polaris/assets/4304867/ad60005e-9f33-449a-9438-9a53d3d0c168) ### Adds support for dynamic source connect icon * This icon is used when a dynamic source is connected, and powering part of the experience: either data, or functionality. * This icon is used in context of Shopify Admin, and Shopify Mobile for merchandising flows. ### WHY are these changes introduced? * Provides additional specificity in how we communicate dynamic source connections in admin and online store ### WHAT is this pull request doing? * Adds support for dynamic source connect icon * Updates description for add dynamic source icon ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#install-dependencies-and-build-workspaces) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [ ] Tested a [snapshot](https://github.com/Shopify/polaris/blob/main/documentation/Releasing.md#-snapshot-releases) - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide --------- Co-authored-by: Kyle Durand <kyledurand@users.noreply.github.com> Co-authored-by: kyledurand <kyle.durand@shopify.com>

### WHY are these changes introduced? This change adds back the documentation to deprecated components and keeps the recommendation to migrate to AppBridge. This is related to the feedback received in Shopify#11460. ### WHAT is this pull request doing? - [x] Adds component documentation back to deprecrated components - [x] Ensures documentation links to other deprecated components and not internal only routes

github-actions · 2024-10-17T03:37:33Z

Hi! We noticed there hasn’t been activity on this PR in a while. After 30 days, it will close automatically.

If it’s still relevant, or you have updates, comment and let us know. And don’t worry, you can always re-open later if needed.

dependabot bot and others added 30 commits October 23, 2023 10:15

Update index.md

1e23aac

Do should be a Don't

Add Section, Row, Column components for MDX (Shopify#11033)

e7e6658

[Sandbox] Enforce null origin for sandbox preview iframes (Shopify#11032

24a256e

)

Complete layout for new Design guidance documentation (Shopify#11025)

33ac8ed

Closes Shopify#11019

fix(polaris-tokens): 🐛 Export types missing for the Typescript Compil…

73b1d5d

…er (tsc) when using Node16/Bundler Module Resolution. Fixes Shopify#10601

alex-page and others added 27 commits January 15, 2024 09:12

Update DragHandleIcon.yml

58b2b45

Remove preversion workaround for Changesets (Shopify#11449)

cc702cd

Removes the `preversion` scripts that allowed us to call the `preversion` npm script hook before creating a new release with `@changesets/cli`.

Add Polaris Tokens for Mobile typography (Shopify#11344)

c9abd3c

Add subtitle support to the PageSkeleton component

a1f7121

Add changeset

d4f34f8

aaronccasanova force-pushed the main branch from 9f6fc03 to b71eff5 Compare April 20, 2024 02:33

github-actions bot added the no-pr-activity label Oct 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PageSkeleton] Add subtitle prop #11513

[PageSkeleton] Add subtitle prop #11513

ryanrphillips commented Jan 27, 2024

github-actions bot commented Oct 17, 2024

[PageSkeleton] Add subtitle prop #11513

Are you sure you want to change the base?

[PageSkeleton] Add subtitle prop #11513

Conversation

ryanrphillips commented Jan 27, 2024

WHY are these changes introduced?

WHAT is this pull request doing?

How to 🎩

🎩 checklist

github-actions bot commented Oct 17, 2024