[Icons] Adds 4 new icons with new shapes #12449
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurgouveia
requested review from
alex-page,
sam-b-rose and
gwyneplaine
as code owners
|
@arthurgouveia what is the timeline and necessity for these icons? We are rebuilding the icons library and if this could wait that would be appreciated. Can you use these |
|
@alex-page feel free to deprioritze this entirely. It is a tech debt and right now we are hosting that inside Email repo. We just ideally want to fetch from Polaris directly when the time is right. cc @mpboucher3 |
|
Thank you! I will keep this in mind in the future. Feel free to nudge me in a couple of weeks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12010
Closes #12011
Closes #12012
Closes #12013
WHY are these changes introduced?
This adds 4 new icons to Polaris to represent shapes.
Icon Figma link
https://www.figma.com/design/x3mlbLESgBoqQrUAHz570E/Editor-improvements?node-id=436%3A35753&t=GWGMqbgUPWaGJAJk-1
WHAT is this pull request doing?
Adding icons
🎩 checklist
README.mdwith documentation changes