Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default and null info on hover #494

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add default and null info on hover #494

wants to merge 3 commits into from
+73 −36

Conversation

damienlethiec
Copy link

@damienlethiec damienlethiec commented Oct 25, 2024 •
edited
Loading

To get rid of annotate in my apps, the only missing thing in my opinion is displaying defaults and null information for the model on hover.

This small PR tries to solve this problem.

CleanShot 2024-10-26 at 01 35 52@2x

Please let me know if it needs improvements 🙂

@damienlethiec damienlethiec requested a review from a team as a code owner October 25, 2024 23:38
@damienlethiec
Copy link
Author

I have signed the CLA!

@damienlethiec
Copy link
Author

@Mapiou

andyw8
andyw8 requested changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@andyw8 andyw8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this looks good, just a few suggestions.

test/ruby_lsp_rails/hover_test.rb Outdated Show resolved Hide resolved
test/ruby_lsp_rails/runner_client_test.rb Show resolved Hide resolved
lib/ruby_lsp/ruby_lsp_rails/hover.rb Outdated Show resolved Hide resolved
lib/ruby_lsp/ruby_lsp_rails/hover.rb Outdated Show resolved Hide resolved
lib/ruby_lsp/ruby_lsp_rails/hover.rb Outdated Show resolved Hide resolved
lib/ruby_lsp/ruby_lsp_rails/hover.rb Outdated Show resolved Hide resolved
@damienlethiec
Copy link
Author

Thanks for the review @andyw8 . I made the changes 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyw8 andyw8 andyw8 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@damienlethiec @andyw8