Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix bin/rails with ruby on Windows #353

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented Apr 29, 2024

As discussed in #351, and documented here, we should prefix the bin/rails call with ruby on Windows.

@andyw8 andyw8 requested a review from a team as a code owner April 29, 2024 17:24
@andyw8 andyw8 requested review from st0012 and vinistock April 29, 2024 17:24
@andyw8 andyw8 force-pushed the andyw8/prefix-bin-rails-for-windows branch from 18b777b to 2468eea Compare April 29, 2024 17:27
if Gem.win_platform?
"ruby " + BASE_COMMAND
else
BASE_COMMAND
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we get rid of the constant? It seems that using the constant directly is not something we would want, so we can encapsulate the full command here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, updated.

@andyw8 andyw8 force-pushed the andyw8/prefix-bin-rails-for-windows branch from 2468eea to ebe0b61 Compare April 29, 2024 18:10
@andyw8 andyw8 added the bugfix This PR fixes an existing bug label Apr 29, 2024
@andyw8 andyw8 merged commit ea4d735 into main Apr 29, 2024
56 checks passed
@andyw8 andyw8 deleted the andyw8/prefix-bin-rails-for-windows branch April 29, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This PR fixes an existing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants