-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Ruby LSP dependency to v0.17.9 #415
Conversation
test/ruby_lsp_rails/hover_test.rb
Outdated
@@ -47,14 +47,8 @@ class User < ApplicationRecord | |||
RUBY | |||
|
|||
assert_equal(<<~CONTENT.chomp, response.contents.value) | |||
```ruby |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just verifying this passes in CI, still need to understand why this has changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suspected related to Shopify/ruby-lsp#2322
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Instead of removing the content, let's add stub_no_typechecker: true
to the with_server
invocation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated with that, but I'm still seeing one failure, looking into...
839b0a0
to
abfd255
Compare
abfd255
to
fc95578
Compare
No description provided.