Bump Ruby LSP dependency to v0.17.9 #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
commented
Jul 23, 2024
test/ruby_lsp_rails/hover_test.rb
Outdated
| @@ -47,14 +47,8 @@ class User < ApplicationRecord | |||
| RUBY | |||
|
|
|||
| assert_equal(<<~CONTENT.chomp, response.contents.value) | |||
| ```ruby | |||
There was a problem hiding this comment.
Just verifying this passes in CI, still need to understand why this has changed.
There was a problem hiding this comment.
Suspected related to Shopify/ruby-lsp#2322
There was a problem hiding this comment.
Yes. Instead of removing the content, let's add stub_no_typechecker: true to the with_server invocation.
There was a problem hiding this comment.
Updated with that, but I'm still seeing one failure, looking into...
andyw8
force-pushed
the
andyw8/ruby-lsp-0.17.9
branch
from
839b0a0
to
abfd255
Compare
vinistock
approved these changes
Jul 24, 2024
andyw8
force-pushed
the
andyw8/ruby-lsp-0.17.9
branch
from
abfd255
to
fc95578
Compare
This was referenced Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.