Fix exception output capturing #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
approved these changes
Oct 16, 2024
andyw8
force-pushed
the
andy8/fix-exception-output-capturing
branch
from
c987284
to
d1f04bc
Compare
andyw8
commented
Oct 16, 2024
| rescue => e | ||
| send_message({ error: e.full_message(highlight: false) }) | ||
| log_message("Request #{request_name} failed:\n" + e.full_message(highlight: false)) |
There was a problem hiding this comment.
@vinistock I updated this so that we show the request name for both rescue clauses.
andyw8
commented
Oct 16, 2024
| @@ -119,12 +119,17 @@ def execute(request, params) | |||
| require params[:server_addon_path] | |||
| ServerAddon.finalize_registrations!(@stdout) | |||
| when "server_addon/delegate" | |||
| server_addon_name = params.delete(:server_addon_name) | |||
There was a problem hiding this comment.
We need to avoid deleting the params here since they may be needed in the error message.
andyw8
commented
Oct 16, 2024
| rescue => e | ||
| send_message({ error: e.full_message(highlight: false) }) | ||
| log_message("Request #{request_name} failed:\n" + e.full_message(highlight: false)) |
There was a problem hiding this comment.
log_message just writes to $stderr, which we are already capturing.
|
FYI @KaanOzkan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/Shopify/team-ruby-dx/issues/1297
This ensure the failure output can be displayed in the Ruby LSP output panel.
To 🎩 :
dev downon CoreNote: Failures that were previously silent, such as hovering over a ActiveRecord model when the DB isn't set up, will now show in the logs.