Add machineId to common telemetry properties

Shopify · Jul 18, 2024 · 10e0d77 · 10e0d77
1 parent bf8ada6
commit 10e0d77
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/vscode/src/commands.ts b/vscode/src/commands.ts
@@ -35,7 +35,6 @@ export async function openFile(
       type: "counter",
       attributes: {
         label: "open_file",
-        vscodemachineid: vscode.env.machineId,
       },
     });
   }

diff --git a/vscode/src/extension.ts b/vscode/src/extension.ts
@@ -133,6 +133,7 @@ async function createLogger(context: vscode.ExtensionContext) {
     additionalCommonProperties: {
       extensionVersion: context.extension.packageJSON.version,
       environment: os.platform(),
+      machienId: vscode.env.machineId,
     },
   });
 }
diff --git a/vscode/src/testController.ts b/vscode/src/testController.ts
@@ -151,7 +151,6 @@ export class TestController {
       type: "counter",
       attributes: {
         label: "test_in_terminal",
-        vscodemachineid: vscode.env.machineId,
       },
     });
   }
@@ -231,7 +230,7 @@ export class TestController {
 
     this.telemetry.logUsage("ruby_lsp.code_lens", {
       type: "counter",
-      attributes: { label: "debug", vscodemachineid: vscode.env.machineId },
+      attributes: { label: "debug" },
     });
   }
 
@@ -323,7 +322,7 @@ export class TestController {
 
     this.telemetry.logUsage("ruby_lsp.code_lens", {
       type: "counter",
-      attributes: { label: "test", vscodemachineid: vscode.env.machineId },
+      attributes: { label: "test" },
     });
   }