Address feedback

Shopify · Aug 19, 2024 · ba82b4b · ba82b4b
1 parent b5df1aa
commit ba82b4b
Showing 1 changed file with 11 additions and 8 deletions.
diff --git a/vscode/src/issueDiagnosingHelper.ts b/vscode/src/issueDiagnosingHelper.ts
@@ -31,16 +31,13 @@ async function collectDiagnosticInfo(
   const extensions = await getPublicExtensions();
 
   return {
-    // eslint-disable-next-line @typescript-eslint/naming-convention
+    /* eslint-disable @typescript-eslint/naming-convention */
     "VS Code Version": vscodeVersion,
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     "Ruby LSP Extension Version": rubyLspExtensionVersion,
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     "Ruby LSP Server Version": rubyLspVersion,
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     "Ruby LSP Addons": rubyLspAddons,
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     "Installed Extensions": extensions,
+    /* eslint-enable @typescript-eslint/naming-convention */
   };
 }
 
@@ -52,9 +49,15 @@ async function getPublicExtensions(): Promise<string[]> {
         return false;
       }
 
-      // Check for marketplace identifier
-      const galleryExtension = ext.packageJSON?.extensionPack?.[0] ?? ext.id;
-      return galleryExtension.includes(".");
+      // Assume if an extension doesn't have a license, it's private and should not be listed
+      if (
+        ext.packageJSON.license === "UNLICENSED" ||
+        !ext.packageJSON.license
+      ) {
+        return false;
+      }
+
+      return true;
     })
     .map((ext) => `${ext.packageJSON.name} (${ext.packageJSON.version})`);
 }