Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link to outdated repo in grammars/ruby.cson #1737

Closed
joevandyk opened this issue Oct 10, 2023 · 2 comments · Fixed by Shopify/vscode-ruby-lsp#823
Closed

Link to outdated repo in grammars/ruby.cson #1737

joevandyk opened this issue Oct 10, 2023 · 2 comments · Fixed by Shopify/vscode-ruby-lsp#823
Labels
transferred This issue was transferred from vscode-ruby-lsp

Comments

@joevandyk
Copy link
Contributor

https://github.com/Shopify/vscode-ruby-lsp/blob/f9a6ff9117ea340ca7634111ec8af03269182c0e/grammars/ruby.cson.json#L2-L6

I was looking at getting HAML and ERB heredoc highlighting support, like what exists for HTML and JS and others, I noticed that there was a link to the https://github.com/atom/language-ruby/ repo which is now archived.

To get HAML and other syntax highlighting - should I submit a PR against this repository? Or somewhere else?
@vinistock
Copy link
Member

Ah, yeah. We imported these grammar files without any modifications. The information for contributors is definitely outdated given that the original repository is now archived.

Yes, you can contribute to this repository. Feel free to put up a PR removing that information_for_contributors key completely as well - since it's really not reflecting the current state of things.

joevandyk referenced this issue in joevandyk/vscode-ruby-lsp Oct 11, 2023
@joevandyk
remove outdated information_for_contributors section from grammars/ru…
c041545 
…by.cson.json

fixes https://github.com/Shopify/vscode-ruby-lsp/issues/820#issuecomment-1757703769

(atom repository is now archived)
@joevandyk joevandyk mentioned this issue Oct 11, 2023
Merged
@joevandyk
Copy link
Contributor Author

joevandyk commented Oct 11, 2023 •
edited
Loading

Shopify/vscode-ruby-lsp#823 and Shopify/vscode-ruby-lsp#824

joevandyk referenced this issue in joevandyk/vscode-ruby-lsp Oct 16, 2023
@joevandyk
remove outdated information_for_contributors section from grammars/ru…
cb8152e 
…by.cson.json

fixes https://github.com/Shopify/vscode-ruby-lsp/issues/820#issuecomment-1757703769

(atom repository is now archived)
vinistock referenced this issue in Shopify/vscode-ruby-lsp Oct 17, 2023
@joevandyk
remove outdated information_for_contributors section in grammar file (#…
d7cb6f1 
…823)

remove outdated information_for_contributors section from grammars/ruby.cson.json

fixes https://github.com/Shopify/vscode-ruby-lsp/issues/820#issuecomment-1757703769

(atom repository is now archived)
@st0012 st0012 transferred this issue from Shopify/vscode-ruby-lsp Mar 18, 2024
@st0012 st0012 added the transferred This issue was transferred from vscode-ruby-lsp label Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
transferred This issue was transferred from vscode-ruby-lsp
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove outdated information_for_contributors section in grammar file joevandyk/vscode-ruby-lsp
3 participants
@joevandyk @st0012 @vinistock